From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.182 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793524995; b=gK80kkyAr5rvD/DvAbZKXQqkjQ3Prj4RHdj2anMb8f20diI8iS4d9lecgMb5Pe4gTekN bPIm24d62hgyfH8QhV9oSZHQ1JA7gT6lGBQzj79BetsZJ8gAgtBCJwGbr/avceyfjjbYu 7IBlB03JBdSaqsxEEWjzuUrHf27gC/JZJmazygWPXRbESLaaEBWYK5Hxctbq3SuPpOfis CmyLAznfqDEMg4fiSsBNeEPPmLsv/SduZ6qWXUwthQo0UGhqVGLqKijsN0fuQ8InfYHWL nEjeuACiHeTC6FAiiuzQVYJqOh+glCGV0FS2HWgQ+lbVJwfCkm23SHgqA/JsKvRkvyQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793524995; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=QKQXXPx0TtnAH7kUYwvPG35lGpK3RW8/bNQYeuZv+r0=; b=E7yuI1y/jtkZuqf3ANOT7Nei4jTeozn76P01oZrUb/y+8o/Z6SvnnCt5Yh23/2Ao92xF yMEb7SVQ5vl2ufYvtp95maIEteyauaOlBT2W9TFPIFCZ28TDeRVC9q4iseN4WQ77SOT1K QHXUz54+JrZw3RM/2IKVx0pFAeYpwCTuJ2I1weLaCD8RJ8jDs3i9kuXxm/z0aUfl6b1LN CmS9vpXUcasmMHMDVTLsa8c/pFnMDGH+J1ZTwR1sRBc5QHbsKzd/hD5EIUi954s0mWLxD Gsw4tk1t84/j4vNmdhTeyvhCjhE+/cp6Fj4WKsARnPD+XCIplaxPtD73Er7qA3jjQlA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=pHyohmlz; arc=none smtp.remote-ip=74.125.82.182 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B83A9606A324 for ; Sun, 1 Nov 2026 09:23:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B83A9606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=pHyohmlz Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-36a2551d7b5so4048518eec.1 for ; Sun, 01 Nov 2026 01:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793524994; x=1794129794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=QKQXXPx0TtnAH7kUYwvPG35lGpK3RW8/bNQYeuZv+r0=; b=pHyohmlz234FO5ddhkGK3CGghjQSnOPw0U+b7mp+iQ2Qog0pyEnV05r2o/KWSU8x+s XyjePTJfY4Yr90NiqcD310MAxjgzU08691YReLHd9Ggq1HqgtsSRdWXu1Z750l8s5MRs kJZG2JtcISaQT7kwDUOLBQgnOSMK5S7CMmRAX3pN4Vx6w/yqbQZ5OK1jyKmCDPzcSItk GB1gzj365eeujHiPjay8quZNM7Q0AlRzc+b7Mktp7Jkjc769Xz4IMEwmhpaBWTUPr1Dn +Kdrx+IqzROl9knrPszFTYBKlorg0c3x8NxszRwtQ+NiKpjQG2Ejy3xcUFkBKP3RH1Gl atlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793524994; x=1794129794; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QKQXXPx0TtnAH7kUYwvPG35lGpK3RW8/bNQYeuZv+r0=; b=OTw9oO7zsRLdHl7uLXjJzFJ20/olk2UYgBqDcKXsan/5TqC/VrKxxjInGnApdLIepb mxUl/CTwxGaGydTiEYJpZdqvqbnutJ16ZrsvJ4sq21LY1MatDUZKz2lqfIvuTxtzMZzt GUMK21RmfELKeYm9hgMr0btmB38JkjamsU7HUQ/LL3f45NA5ma9SPUinZrjI+xmXufy0 KwGJ5t23BWFKI1ktLSjXwVyyDTICZ0/D89k0/insI1cattZemig+lR1w5y1cFwMNQ+vp u2nXEIgnw294HIgET5cJARG3J6yXqCJAtdyUQAMS7RIQYlDFXToyWjlgkVPxAQCPD/Qi cn8g== X-Forwarded-Encrypted: i=1; AKwUvByhBhZnuVpa7hhuudT14H5iB+5tt72XFQbkn0WpFJUfKIfGnn8/0eM1XhBAfqYdI8EC56SOtNk=@vger.kernel.org X-Gm-Message-State: AFq9FYJ3j/w2acZRD2Kks4EXWae+GO0fDnXYQH4y3v1/OXg+dmjKw5PB d9DthHYVxk/jU3b3VGYToi1QyX79eUq9gLzsq7XxnwOK53xpnZgMKwZw X-Gm-Gg: AYBFou2/spPZFLzRn8PPJp0bawJ2b/pXvc2OM/XOR2Uyt1sPciS/EDmv0HqtoEAYhUP tPnGgX3pAYi0ZIMIIN61DJ1GBGRIqrpLqUlisk70sbE5fyGVA4OiucBubCsk2RlNtBHmffmRilP aurURywaf4sGVp6XiF5JiWk3dPRMM6Nlc9cBi3EIteaoCSsvZJlwlFDmjsA1AujWzSgIf/OwQV8 6UxPLRsnG8rlk8Jr5oTJsdLfgN9KmOT2jlcWFUPh2EUOKW87Kxsvdobzi61FN/uu+a5rASa28iE WtAp8o10SXq/FjwKRrl5gz79ql3o2Y24JLur0+qIPk5KILLOayEeaqnlm1ihZM7xkRs9Ms8PMcJ nmSV8i3nFFgW0aApzNYZjhCz3hhXPwqzz79l0r2vST0h0RpBYZmkHK8yRByj88QOtTWAjJr65iU KWyu3OPtnKucXqC0O4NHq/k5G2QGYt65E4S3dSwQpEZzrfBDQLEYTillfT++8MejaVxDKvECpDA 1qEDIu10atgVcqEo6wUL5ehwoieV9vQ2kf10GtuW8NdknnqsERxrln39uskHyZhb8G8MJioXKDG CsaH0E9f7VQCUdxKbMWeg958KZ1QqoVKtvQm X-Received: by 2002:a05:7301:53c8:b0:36a:22de:d85b with SMTP id 5a478bee46e88-36a2fd48fb3mr13979029eec.2.1793524993618; Sun, 01 Nov 2026 01:23:13 -0800 (PST) Received: from xploitoverload ([2406:b400:f11:1bac:4040:640b:8a1:8629]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36a42a77c0dsm29407539eec.26.2026.11.01.01.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Nov 2026 01:23:12 -0800 (PST) From: Kalpesh Solanki To: alex.aring@gmail.com, stefan@datenfreihafen.org, miquel.raynal@bootlin.com, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com Cc: horms@kernel.org, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+9ea34da5ca6100593c90@syzkaller.appspotmail.com, Kalpesh Solanki , stable@vger.kernel.org Subject: [PATCH] ieee802154: nl-mac: validate device pointers before dereference Date: Sun, 1 Nov 2026 14:52:19 +0530 Message-ID: <20261101092219.1278751-1-skalpesh942@gmail.com> X-Mailer: git-send-email 2.53.0 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A virtual network device (such as a TUN interface) can have its link type set to ARPHRD_IEEE802154 via ioctl(tun_fd, TUNSETLINK, ARPHRD_IEEE802154). However, such devices do not have an IEEE 802.15.4 private context allocated (dev->ieee802154_ptr is NULL) and do not register MAC operations (dev->ml_priv / ieee802154_mlme_ops(dev) is NULL). When dumping security keys via IEEE802154_LLSEC_LIST_KEY, ieee802154_llsec_dump_table() iterates through all net devices and dereferences data.ops->llsec assuming that any ARPHRD_IEEE802154 device has valid mlme ops. Because data.ops is NULL, this causes an immediate null-pointer dereference / General Protection Fault: Oops: general protection fault, probably for non-canonical address KASAN: null-ptr-deref in range [0x0000000000000038-0x000000000000003f] RIP: 0010:ieee802154_llsec_dump_table+0x204/0x5d0 Call Trace: genl_dumpit+0x125/0x230 net/netlink/genetlink.c:1026 netlink_dump+0x53b/0xd00 net/netlink/af_netlink.c:2351 __netlink_dump_start+0x6d6/0x990 net/netlink/af_netlink.c:2466 Similarly, ieee802154_dump_iface() and ieee802154_nl_get_dev() assume that ARPHRD_IEEE802154 devices have valid dev->ieee802154_ptr and ieee802154_mlme_ops(dev) pointers. Fix this by ensuring dev->ieee802154_ptr and ieee802154_mlme_ops(dev) are non-NULL before proceeding in ieee802154_nl_get_dev(), ieee802154_dump_iface(), and ieee802154_llsec_dump_table(). Fixes: 3e9c156e2c21 ("ieee802154: add netlink interfaces for llsec") Cc: stable@vger.kernel.org Reported-by: syzbot+9ea34da5ca6100593c90@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=9ea34da5ca6100593c90 Tested-by: syzbot+9ea34da5ca6100593c90@syzkaller.appspotmail.com Signed-off-by: Kalpesh Solanki --- net/ieee802154/nl-mac.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/ieee802154/nl-mac.c b/net/ieee802154/nl-mac.c index 74ef0a310af..1acde5af4b5 100644 --- a/net/ieee802154/nl-mac.c +++ b/net/ieee802154/nl-mac.c @@ -162,7 +162,8 @@ static struct net_device *ieee802154_nl_get_dev(struct genl_info *info) if (!dev) return NULL; - if (dev->type != ARPHRD_IEEE802154) { + if (dev->type != ARPHRD_IEEE802154 || !dev->ieee802154_ptr || + !ieee802154_mlme_ops(dev)) { dev_put(dev); return NULL; } @@ -437,7 +438,8 @@ int ieee802154_dump_iface(struct sk_buff *skb, struct netlink_callback *cb) idx = 0; for_each_netdev(net, dev) { - if (idx < s_idx || dev->type != ARPHRD_IEEE802154) + if (idx < s_idx || dev->type != ARPHRD_IEEE802154 || + !dev->ieee802154_ptr || !ieee802154_mlme_ops(dev)) goto cont; if (ieee802154_nl_fill_iface(skb, NETLINK_CB(cb->skb).portid, @@ -771,7 +773,8 @@ ieee802154_llsec_dump_table(struct sk_buff *skb, struct netlink_callback *cb, int rc; for_each_netdev(net, dev) { - if (idx < first_dev || dev->type != ARPHRD_IEEE802154) + if (idx < first_dev || dev->type != ARPHRD_IEEE802154 || + !dev->ieee802154_ptr || !ieee802154_mlme_ops(dev)) goto skip; data.ops = ieee802154_mlme_ops(dev); --