From: Gustavo Luiz Duarte <gustavold@gmail.com>
To: Breno Leitao <leitao@debian.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Gustavo Luiz Duarte <gustavold@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net v5 4/4] netconsole: stop waiting for carrier once the device is unregistered
Date: Mon, 02 Nov 2026 19:54:52 +0000 [thread overview]
Message-ID: <20261102-netcons-fixes-v5-4-bdada2f03563@gmail.com> (raw)
In-Reply-To: <20261102-netcons-fixes-v5-0-bdada2f03563@gmail.com>
netcons_netpoll_setup() releases RTNL and waits in netcons_wait_carrier()
for up to carrier_timeout seconds for the device to report carrier. If
the device is unregistered in the meantime, the loop keeps polling until
the timeout expires.
Stop waiting as soon as the device is no longer NETREG_REGISTERED.
Closes: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261021-netcons-fixes-v4-0-3857120c6340@gmail.com
Signed-off-by: Gustavo Luiz Duarte <gustavold@gmail.com>
---
drivers/net/netconsole.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index 238acf300d23..895d33b179e7 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -383,6 +383,8 @@ static void netcons_wait_carrier(struct netpoll *np, struct net_device *ndev)
atmost = jiffies + netpoll_get_carrier_timeout() * HZ;
while (!netif_carrier_ok(ndev)) {
+ if (READ_ONCE(ndev->reg_state) != NETREG_REGISTERED)
+ break;
if (time_after(jiffies, atmost)) {
np_notice(np, "timeout waiting for carrier\n");
break;
--
2.56.0
next prev parent reply other threads:[~2026-11-02 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 19:54 [PATCH net v5 0/4] netconsole: fix target enable race and configfs read locking Gustavo Luiz Duarte
2026-11-02 19:54 ` [PATCH net v5 1/4] netconsole: finish enabling the target before releasing RTNL Gustavo Luiz Duarte
2026-11-03 12:08 ` Breno Leitao
2026-11-02 19:54 ` [PATCH net v5 2/4] netconsole: read np.dev under target_list_lock in local_mac_show() Gustavo Luiz Duarte
2026-11-03 12:08 ` Breno Leitao
2026-11-02 19:54 ` [PATCH net v5 3/4] netconsole: recheck device registration after waiting for carrier Gustavo Luiz Duarte
2026-11-03 12:09 ` Breno Leitao
2026-11-02 19:54 ` Gustavo Luiz Duarte [this message]
2026-11-03 12:28 ` [PATCH net v5 4/4] netconsole: stop waiting for carrier once the device is unregistered Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102-netcons-fixes-v5-4-bdada2f03563@gmail.com \
--to=gustavold@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox