From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793632575; b=hh6GoLBRd3wrsg8+UAxpG/WpAK56UjGE8Jjj5Scs0tfyBF1ybl3H9PxMrDim7pdHX0rC gPYlV/K5P+UVrYeQwIfBJV0zHkri3SE6fPMhQpv+NxLaSj4Vj3bnh4eB88OyFCMKQ1xar sy+Bj5H9641lfrutfN8hGyA9EjUa9dIWchqxyWHqQiWMdx10I0Zf5c1WZE2gI2y3EvWiJ VIKDz3XnR67+fTe9XMgFhxTYlYoYsyA11oyTUtqyUZ6WDjJbpHU68Z4mAG1aHEeBfuuDm QIw6avpP28pjxNUuEVRE4oPHgxANfiDu7lykMnljwYImTjEM14LOruM703s0awX1/bQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793632575; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=goLGxFor5aDHmq+/63YZ7VsFVk0WPo8/IlwPxf0/q/E=; b=PvViG6YL6Q022EZFeB5bsQFq6rDBKnbA/JoaN3tHMcrLjHohnRf2eqUIFqO7QOVLI0KB 3HP6CDXan7JovGefOYN87bfBc/rrqJ8p+LmwTG/X2rNqFa6WFg2NUsmxhlcRoc+o0j3PQ UV9gLGZ2SDcZDOm59GPJIvpoo61jOUyxrpKehjf3yJqFFArnsu6n8TQr2BJJiW05xc6PX sS1NpSdRuhLyJq1uLd6y5oA+VV3qPXeB8yefAroAzI4tu01Cyn9+GCAcOxHpnAeoK8E25 wf48zJfbCq2U6CsqDOAgm1YAGh251NNlJvNHYz0nlGLY00j+HaJ1yQrmd1dxRNplrqw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="ej70vPT/"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37C4A606A592; Mon, 2 Nov 2026 15:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ej70vPT/ Received: by smtp.kernel.org (Postfix) with ESMTPSA id B757A1F00A16; Mon, 2 Nov 2026 15:15:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793632574; bh=goLGxFor5aDHmq+/63YZ7VsFVk0WPo8/IlwPxf0/q/E=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=ej70vPT/y7NrhBgRnVeJZJCWCJCY4Ir+tDI0qb3+EynguB83LrhQsFn2l3M5OZtXE 2VH+S87/JA3tEOQ5oF6NbafdeM5dvCGs7k+Pl66iGGY0VzHGdvfeTuOHMGET++saO9 8CMGsO+isRtfapDtsUOvJJ1+uTuGk8RHjvFSx0T6P4hnrtLPTR2SSKodt/mLQIBmk2 SzbEgwffy1kv1xXhMujkkGK8afuda14vw1NrfhyqY3qJhPF7pdO3kkpnpsfKhmpNYh jxGaC2jmsD4TftiMbXuIK38lcVEqXr7YxWPTdZiDHhvMHLfLf4/cExgZfn7c5HC9H0 J+psMOIMcn0fQ== From: Christian Brauner Date: Mon, 02 Nov 2026 16:07:24 +0100 Subject: [PATCH RFC 17/23] usb: gadget: function: rndis: let procfs copy in writes X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261102-work-procfs-drivers-v1-17-a994bd4d3b1a@kernel.org> References: <20261102-work-procfs-drivers-v1-0-a994bd4d3b1a@kernel.org> In-Reply-To: <20261102-work-procfs-drivers-v1-0-a994bd4d3b1a@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Jann Horn , Josef Bacik , Chris Mason , Jeff Layton , NeilBrown , Eric Dumazet , Thomas Gleixner , Al Viro , Jonathan Corbet , Christoph Hellwig , Greg Kroah-Hartman , Joel Granados , Kees Cook , Jan Kara , Jan Kara , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-um@lists.infradead.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, platform-driver-x86@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, netfilter-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-doc@vger.kernel.org, linux-serial@vger.kernel.org, linux-atm-general@lists.sourceforge.net, Takashi Iwai , linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, linux-debuggers@vger.kernel.org, "Christian Brauner (Amutable)" , Chuck Lever X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1569; i=brauner@kernel.org; h=from:subject:message-id; bh=saz4p5rW2UOPmCRi+6zEslqjX7E5721ehvji7/y2TLU=; b=kA0DAAoWkcYbwGV43KIByyZiAGropzGhaJWnu9+4zvQgXLhUThJNad18i/diIL3NsOXTHFLIm Yh1BAAWCgAdFiEEQIc0Vx6nDHizMmkokcYbwGV43KIFAmropzEACgkQkcYbwGV43KIUZwD+IHp+ nA7hxed0nI3IkqLBHaX8l90Mx69iUsGXRMOlkboA/3KH9SLJ/MMw6rQ8ujZlKhQxzG1q+lU/vjC oZkDuYDUH X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Implement ->proc_write_buf() so procfs copies in what is written to /proc/driver/rndis- before it pins the entry, and handle the commands from that copy. Writes larger than PAGE_SIZE - 1 bytes fail with -EINVAL now. Signed-off-by: Christian Brauner (Amutable) --- drivers/usb/gadget/function/rndis.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c index 3c7bd30b8a3a..e05e0c6ae8fb 100644 --- a/drivers/usb/gadget/function/rndis.c +++ b/drivers/usb/gadget/function/rndis.c @@ -1138,7 +1138,7 @@ static int rndis_proc_show(struct seq_file *m, void *v) return 0; } -static ssize_t rndis_proc_write(struct file *file, const char __user *buffer, +static ssize_t rndis_proc_write(struct file *file, char *buffer, size_t count, loff_t *ppos) { rndis_params *p = pde_data(file_inode(file)); @@ -1146,9 +1146,8 @@ static ssize_t rndis_proc_write(struct file *file, const char __user *buffer, int i, fl_speed = 0; for (i = 0; i < count; i++) { - char c; - if (get_user(c, buffer)) - return -EFAULT; + char c = *buffer; + switch (c) { case '0': case '1': @@ -1185,7 +1184,7 @@ static ssize_t rndis_proc_write(struct file *file, const char __user *buffer, static const struct proc_ops rndis_proc_ops = { .proc_show = rndis_proc_show, - .proc_write = rndis_proc_write, + .proc_write_buf = rndis_proc_write, }; #define NAME_TEMPLATE "driver/rndis-%03d" -- 2.53.0