From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=217.70.190.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793581032; b=ay4Yyj7J+WwqTxyGY4gEp3lM0bOdXFb1jIbYUJRzISXwYM1uUkoxYWqRpMGWC1GhYht0 wi1Yqn4W/9Kwt8/x/qyf4j++AMKLnmGQbnDEaBalT173zY7vu9NEr5cI/Bv1+/aJOjK6b x6SRKKjodYibKu1bcfH9wz3rhRmm5eWj8xMKK/Tc2gRDQIMH8TNmPHDip0V8T1k6hD3fJ nVnow7JLKYs2uxHrp2QTc7C/gArcCm63ihu9dQxWzEYQmp62JkMiqiL51uIkx7XzJi1/+ 3ddqjih01MEHkcIx5xYuA3FPFOf+ryEtUD2idu7/YMYOboc0EChn8VZoVWwp3ygOd7A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793581032; h=DMARC-Filter:DKIM-Signature:Received:From:To:Cc:Subject:Date: Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Spam-Status:X-Spam-Checker-Version; bh=ACw4Crf3hJuHvBnGGimGcJkB6r441MIl6lESNzI1wQ8=; b=3Wtd3QXpwFwYPSEfXIIupwWVdAd9OTE1QKWRbAdBu1alVbkyqf77NNu+bHbeaW+Qu4v9 LQ4Bout56hlNsZ8kkIsQZhxGhTCSo+K/A2vGmi8bI9mAMkIzn7ZMIA85zwOf6wvoqn7ck x7nK99rRLsybmQh+ubaQKV4kAfxL+U79hkUSq91TuXlgNYkdaC7KDEVY42savw7sEcZlH PDhQys08E40lN98koxu1sSZT7nlPCfPS97Dry5GdsS84UVNwQmQQtdqmuSNil56GjfU/K pyA74YvhXp78rrKCkKm0/DjzJry2rHJ5lnXkvXZRxWW+U3TEv21ssAbrAI8pnqClaRg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=netfilter.org; spf=pass smtp.mailfrom=netfilter.org; dkim=pass header.d=netfilter.org header.i=@netfilter.org header.a=rsa-sha256 header.s=2025 header.b=DJ1qAxkE; arc=none smtp.remote-ip=217.70.190.124 Received: from mail.netfilter.org (mail.netfilter.org [217.70.190.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF2BF60A2611; Mon, 2 Nov 2026 00:57:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org CF2BF60A2611 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netfilter.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=netfilter.org header.i=@netfilter.org header.a=rsa-sha256 header.s=2025 header.b=DJ1qAxkE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org; s=2025; t=1793581029; bh=ACw4Crf3hJuHvBnGGimGcJkB6r441MIl6lESNzI1wQ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DJ1qAxkEYfi2SQ7aJRN/Nv6yS5DmWe+ke8JU8ya/T9ADbHWOATvqedzA68j5AKVNo cOIINcj/dU1miC/S3BcyL5I3UtxMmfJB1Ask4wJASXqnZ+JDYXlvwV8Odgq0ocmEJt PXkIr9vGtWl7/VYWtpPJ/tUV5ZBl2d854rYiqPDs9B7r9/2a/PZWx022WMwqacBBdN n0hmfsIC3Czfqvii5loDHLBNLu4Vyj9txc/tsWG4GZKbaEkND/aPb/cn+RR93Q2BwY zoliTCr/6J/5rS1bOcI66WRI4lN74KUX3LrrFAPwvRv47165BMe46max8RJJIfvEfu Sasi11QsGTL4g== Received: from localhost.localdomain (mail-agni [217.70.190.124]) by mail.netfilter.org (Postfix) with ESMTPSA id 5266460078; Mon, 2 Nov 2026 01:57:09 +0100 (CET) From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com, edumazet@kernel.org, horms@kernel.org, fw@strlen.de, ja@ssi.bg Subject: [PATCH net 04/15] ipvs: fix protocol data lifetime during namespace teardown Date: Mon, 2 Nov 2026 01:56:43 +0100 Message-ID: <20261102005654.532438-5-pablo@netfilter.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261102005654.532438-1-pablo@netfilter.org> References: <20261102005654.532438-1-pablo@netfilter.org> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chengfeng Ye IPVS frees its per-net protocol data before control cleanup cancels defense work and unregisters the sysctl table. A defense worker can load a protocol data pointer, then namespace cleanup can unlink and free that object before the worker dereferences pd->pp or pd->next. The worker's securetcp_lock does not serialize with protocol cleanup. A concurrent defense-mode sysctl write can reach the same timeout update path. KASAN reported: BUG: KASAN: slab-use-after-free in ip_vs_protocol_timeout_change Workqueue: events_long defense_work_handler Call Trace: ip_vs_protocol_timeout_change+0x1b4/0x1e0 update_defense_level+0x63e/0xd80 defense_work_handler+0x1e/0xc0 Allocated by task 125: ip_vs_protocol_net_init+0xda/0x2f0 __ip_vs_init+0x16b/0x240 setup_net+0xfc/0x310 Freed by task 12: ip_vs_protocol_net_cleanup+0x1d6/0x2e0 __ip_vs_cleanup_batch+0x7d/0x100 cleanup_net+0x38c/0x770 Run control cleanup before protocol cleanup so that defense work and active sysctl handlers have finished before their protocol data is freed. Initialize protocols before exposing the control interface, and unwind in reverse order, to enforce the same lifetime on initialization failure. Protocol initialization and exit do not depend on control state. Fixes: 9330419d9aa4 ("IPVS: netns, use ip_vs_proto_data as param.") Cc: stable@vger.kernel.org Signed-off-by: Chengfeng Ye Acked-by: Julian Anastasov Signed-off-by: Pablo Neira Ayuso --- net/netfilter/ipvs/ip_vs_core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c index fd503f0efb57..8a3c880fdb26 100644 --- a/net/netfilter/ipvs/ip_vs_core.c +++ b/net/netfilter/ipvs/ip_vs_core.c @@ -2502,12 +2502,12 @@ static int __net_init __ip_vs_init(struct net *net) if (ip_vs_estimator_net_init(ipvs) < 0) goto estimator_fail; - if (ip_vs_control_net_init(ipvs) < 0) - goto control_fail; - if (ip_vs_protocol_net_init(ipvs) < 0) goto protocol_fail; + if (ip_vs_control_net_init(ipvs) < 0) + goto control_fail; + if (ip_vs_app_net_init(ipvs) < 0) goto app_fail; @@ -2527,10 +2527,10 @@ static int __net_init __ip_vs_init(struct net *net) conn_fail: ip_vs_app_net_cleanup(ipvs); app_fail: - ip_vs_protocol_net_cleanup(ipvs); -protocol_fail: ip_vs_control_net_cleanup(ipvs); control_fail: + ip_vs_protocol_net_cleanup(ipvs); +protocol_fail: ip_vs_estimator_net_cleanup(ipvs); estimator_fail: net->ipvs = NULL; @@ -2547,8 +2547,8 @@ static void __net_exit __ip_vs_cleanup_batch(struct list_head *net_list) ipvs = net_ipvs(net); ip_vs_conn_net_cleanup(ipvs); ip_vs_app_net_cleanup(ipvs); - ip_vs_protocol_net_cleanup(ipvs); ip_vs_control_net_cleanup(ipvs); + ip_vs_protocol_net_cleanup(ipvs); ip_vs_estimator_net_cleanup(ipvs); IP_VS_DBG(2, "ipvs netns %d released\n", ipvs->gen); net->ipvs = NULL; -- 2.47.3