Netdev List
 help / color / mirror / Atom feed
From: Dave Seddon <dave.seddon.ca@gmail.com>
To: Michal Kubecek <mkubecek@suse.cz>, netdev@vger.kernel.org
Cc: Dave Seddon <dave.seddon.ca@gmail.com>,
	Taehee Yoo <ap420073@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH ethtool v2 0/2] netlink: require a value for hds-thresh and the TDR parameters
Date: Mon,  2 Nov 2026 10:51:19 -0800	[thread overview]
Message-ID: <20261102185122.1357927-1-dave.seddon.ca@gmail.com> (raw)

hds-thresh (-G) and first, last, step and pair (--cable-test-tdr) take
a value but leave min_argc at 0, so a missing value prints
"invalid value '(null)'" instead of "no value for parameter". Each
patch sets min_argc to 1 for one command.

Changes in v2:
- Split into one patch per command, each with its own Fixes tag
  (Andrew Lunn).
- v1: https://lore.kernel.org/netdev/20261102023919.1472495-1-dave.seddon.ca@gmail.com/

Checked by hand on a build of each patch on bae2dbd: the parameters
it covers print "no value for parameter", the others are unchanged.
make check passes.

Claude found the issue while porting the code from C to Go, and drafted
the patches; I reviewed them and take responsibility for them.

Dave Seddon (2):
  netlink: rings: require a value for hds-thresh
  netlink: cable_test: require a value for the TDR parameters

 netlink/cable_test.c | 4 ++++
 netlink/rings.c      | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.56.0


             reply	other threads:[~2026-11-02 18:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 18:51 Dave Seddon [this message]
2026-11-02 18:51 ` [PATCH ethtool v2 1/2] netlink: rings: require a value for hds-thresh Dave Seddon
2026-11-02 18:51 ` [PATCH ethtool v2 2/2] netlink: cable_test: require a value for the TDR parameters Dave Seddon
2026-11-03 13:31   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261102185122.1357927-1-dave.seddon.ca@gmail.com \
    --to=dave.seddon.ca@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=ap420073@gmail.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox