Re: [PATCH net v1] igmp: use copy-on-write RCU updates in ip_mc_source()

[kernel test robot <lkp@intel.com>]

Hi Binbin,

kernel test robot noticed the following build errors:

[auto build test ERROR on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Binbin-Deng/igmp-use-copy-on-write-RCU-updates-in-ip_mc_source/20261102-175312
base:   net/main
patch link:    https://lore.kernel.org/r/20261102095312.47767-1-18983559317%40163.com
patch subject: [PATCH net v1] igmp: use copy-on-write RCU updates in ip_mc_source()
config: sparc64-randconfig-1001-20261102 (https://download.01.org/0day-ci/archive/20261103/202611030211.aklzSdgm-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261103/202611030211.aklzSdgm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611030211.aklzSdgm-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/ipv4/igmp.c:2646:1: error: function definition is not allowed here
    2646 | {
         | ^
   net/ipv4/igmp.c:2737:1: error: function definition is not allowed here
    2737 | {
         | ^
   net/ipv4/igmp.c:2802:1: error: function definition is not allowed here
    2802 | {
         | ^
   net/ipv4/igmp.c:2851:1: error: function definition is not allowed here
    2851 | {
         | ^
   net/ipv4/igmp.c:2898:1: error: function definition is not allowed here
    2898 | {
         | ^
   net/ipv4/igmp.c:2924:1: error: function definition is not allowed here
    2924 | {
         | ^
   net/ipv4/igmp.c:3277:1: error: function definition is not allowed here
    3277 | {
         | ^
>> net/ipv4/igmp.c:3294:19: error: use of undeclared identifier 'igmp_netdev_event'; did you mean 'igmp_ifc_event'?
    3294 |         .notifier_call = igmp_netdev_event,
         |                          ^~~~~~~~~~~~~~~~~
         |                          igmp_ifc_event
   net/ipv4/igmp.c:884:13: note: 'igmp_ifc_event' declared here
     884 | static void igmp_ifc_event(struct in_device *in_dev)
         |             ^
>> net/ipv4/igmp.c:3294:19: error: incompatible function pointer types initializing 'notifier_fn_t' (aka 'int (*)(struct notifier_block *, unsigned long, void *)') with an expression of type 'void (struct in_device *)' [-Wincompatible-function-pointer-types]
    3294 |         .notifier_call = igmp_netdev_event,
         |                          ^~~~~~~~~~~~~~~~~
   net/ipv4/igmp.c:3298:1: error: function definition is not allowed here
    3298 | {
         | ^
>> net/ipv4/igmp.c:3316:2: error: expected '}'
    3316 | }
         |  ^
   net/ipv4/igmp.c:2485:1: note: to match this '{'
    2485 | {
         | ^
   11 errors generated.


vim +3294 net/ipv4/igmp.c

4aa5dee4d99978 Jiri Pirko      2013-07-20  3292  
4aa5dee4d99978 Jiri Pirko      2013-07-20  3293  static struct notifier_block igmp_notifier = {
4aa5dee4d99978 Jiri Pirko      2013-07-20 @3294  	.notifier_call = igmp_netdev_event,
4aa5dee4d99978 Jiri Pirko      2013-07-20  3295  };
4aa5dee4d99978 Jiri Pirko      2013-07-20  3296  
72c1d3bdd5bf10 WANG Cong       2014-01-10  3297  int __init igmp_mc_init(void)
7091e728c57015 Alexey Dobriyan 2008-12-25  3298  {
72c1d3bdd5bf10 WANG Cong       2014-01-10  3299  #if defined(CONFIG_PROC_FS)
4aa5dee4d99978 Jiri Pirko      2013-07-20  3300  	int err;
4aa5dee4d99978 Jiri Pirko      2013-07-20  3301  
4aa5dee4d99978 Jiri Pirko      2013-07-20  3302  	err = register_pernet_subsys(&igmp_net_ops);
4aa5dee4d99978 Jiri Pirko      2013-07-20  3303  	if (err)
4aa5dee4d99978 Jiri Pirko      2013-07-20  3304  		return err;
4aa5dee4d99978 Jiri Pirko      2013-07-20  3305  	err = register_netdevice_notifier(&igmp_notifier);
4aa5dee4d99978 Jiri Pirko      2013-07-20  3306  	if (err)
4aa5dee4d99978 Jiri Pirko      2013-07-20  3307  		goto reg_notif_fail;
4aa5dee4d99978 Jiri Pirko      2013-07-20  3308  	return 0;
4aa5dee4d99978 Jiri Pirko      2013-07-20  3309  
4aa5dee4d99978 Jiri Pirko      2013-07-20  3310  reg_notif_fail:
4aa5dee4d99978 Jiri Pirko      2013-07-20  3311  	unregister_pernet_subsys(&igmp_net_ops);
4aa5dee4d99978 Jiri Pirko      2013-07-20  3312  	return err;
72c1d3bdd5bf10 WANG Cong       2014-01-10  3313  #else
72c1d3bdd5bf10 WANG Cong       2014-01-10  3314  	return register_netdevice_notifier(&igmp_notifier);
^1da177e4c3f41 Linus Torvalds  2005-04-16  3315  #endif
72c1d3bdd5bf10 WANG Cong       2014-01-10 @3316  }

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki