From: John Garry <john.garry@arm.com>
To: bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, hkallweit1@gmail.com,
nic_swsd@realtek.com, netdev@vger.kernel.org,
john.garry@linux.dev, John Garry <john.garry@arm.com>
Subject: [RFC PATCH] PCI: Avoid bus reset for Realtek RTL8126
Date: Tue, 3 Nov 2026 17:27:58 +0000 [thread overview]
Message-ID: <20261103172758.1816004-1-john.garry@arm.com> (raw)
From testing on a Orion O6 board, a bus level reset for a RTL8126 may not
recover:
root@radxa-kernel:/sys/devices/pci0000:00/0000:00:00.0/0000:01:00.0# more reset_method
bus
root@radxa-kernel:/sys/devices/pci0000:00/0000:00:00.0/0000:01:00.0# echo 1 > reset
r8169 0000:01:00.0: resetting
r8169 0000:01:00.0: not ready 1023ms after bus reset; waiting
r8169 0000:01:00.0: not ready 2047ms after bus reset; waiting
r8169 0000:01:00.0: not ready 4095ms after bus reset; waiting
r8169 0000:01:00.0: not ready 8191ms after bus reset; waiting
r8169 0000:01:00.0: not ready 16383ms after bus reset; waiting
r8169 0000:01:00.0: not ready 32767ms after bus reset; waiting
SError Interrupt on CPU6, code 0x00000000be000011 -- SError
Add a quirk to avoid this reset method.
Signed-off-by: John Garry <john.garry@arm.com>
---
I'm sending as an RFC as I am not sure that this is an issue with the
development board and not the controller.
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 7f1f47ea2ee4..69eef714838a 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3850,6 +3850,9 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ASMEDIA, 0x1164, quirk_no_bus_reset);
/* Intel DG1 0x4905 may not recover from bus reset */
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x4905, quirk_no_bus_reset);
+/* Realtek RTL8126 may not recover from a bus reset */
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_REALTEK, 0x8126, quirk_no_bus_reset);
+
static void quirk_no_pm_reset(struct pci_dev *dev)
{
/*
--
2.47.3
reply other threads:[~2026-11-03 17:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103172758.1816004-1-john.garry@arm.com \
--to=john.garry@arm.com \
--cc=bhelgaas@google.com \
--cc=hkallweit1@gmail.com \
--cc=john.garry@linux.dev \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox