From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.176 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793917272; b=OMXWDcENQrIken27Wz/ycWVWOaIUhKG/X2vE4yhU5B63b+PGy4nle+20Lg0wbODn2p7z ZMWTv+62hE8kFZdT1Bj2T4dL6O+sxSSRwtz62iZVFinrwGSUOl5ZJ6ANfKv4dWEwCzqha XYIusPNfSsfJQRfXx6ESh5bALXyiNCmQwFVw6UNMhanZIbsUNEAlMLC9AcFVJkuXuG6DG T6RiEQVJ4BNbrIgeGfuLYOwj4V3zocl267WbEqYSm/rkSXa9JgXJcr6+Pb3PdxqzGSh2k LLGihY6JITJGn/pQJ7MJVwyAbuVgMjp7I8nynv4BqIWYmrFvZjVkywOw6tG6/h5ZIpA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793917272; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From: X-Google-Original-From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=Acd/QpdNjaZoFfEYKM7452m8zFvnMYypavI01EcAq44=; b=zsLxnWAu3G55XDFDKUP/ZcNoaHumZqY0pbx67xV8r9RzZ5MTWhxK+pFuv4D8w+8E6zeS MdDxFgtYjiFu64gzPkkN9X59PDCdK0rXXiff04aptw1xFR+nZgs2ixncJ06zjhbT7NxbV FHJcFgKb6dBC4T9mkZTpzii8zegUjxdQ0qeZ/E189mSZUlffICI4jqTgcz4+/T6nw5Qzy I3wTmLFPetd/MPn0pf3haXeWx+kkNq6knqNG5+Suo9cU+wtfD2f23ngw5jUyXN4yyd9u+ ANdUi92VOgs0OONXb/mJW/DVhlqRzaMjhqml9dumGb1e2rHrWkV/wFPVKRVrUvr9B+Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=gpahHltS; arc=none smtp.remote-ip=74.125.82.176 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 046C8606A335 for ; Thu, 5 Nov 2026 22:21:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 046C8606A335 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=gpahHltS Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-36e795af1d4so38537eec.1 for ; Thu, 05 Nov 2026 14:21:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793917271; x=1794522071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Acd/QpdNjaZoFfEYKM7452m8zFvnMYypavI01EcAq44=; b=gpahHltSOyFyzTfMXDIYVv/IO8fAwDTU17+d5bpsCt+yDVFs0wG1xrAMoRJicRmKPa gKI8s57ZpODIASUIp5wXVVvn0dIMueFV6tmFExcufTlIvRDJ4FwcnjfpO1YiuNJYskh9 wLBlCA5zt/TFk4FPt/ikmVcTIxK+DS/GQI6BDUCn7xk5eRTj+QDNPe7/IfzP0+PoqJDO f6Klxp95jMLnpk15i8axVytxSGb3KcE2gi3iZOQscKPFpp/t5tmXo2nxodEhCP4PNuci E7Zsalf+0684reRO+DpFrYWLcmSLFMcGH2zy2tw6XNi9+YUIR+sge4x6dG1zkuero/lF dJQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793917271; x=1794522071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Acd/QpdNjaZoFfEYKM7452m8zFvnMYypavI01EcAq44=; b=vQ+FwxQprF20V39ZVpA1DuaGOtUSQRZ38cMRpDOZ5fxKp/E3tpfwBZtsbgyVSy/Ra6 v8ApwsgYlhntr+c99SxDnIH1+unVhFspH1reIKGGZrv93CLxt4yB9wjSosjFIItePeQx kalFd7ZAatDyZPD496QlZHu6FJwotVQsocBB68N/qBANMo0TdA/0Al0JtCYEyJKu+sW0 VjjXmE3ve5cOVbr566szElF9k1QipGGxwI4jmYXT8G8laRWP4+KgvX5B8WyMGr2u7YgC zl7f4xTV7AEn95nXWWl8D4eKQ+wl3DWzuKwrLetHVrpfPj1csyxr/7Tgukpjma+KuIwI ApsA== X-Gm-Message-State: APuU4Z8YzNoJfpxqQ49ctOjKS5OLUYMdRcrtUDbn+ZFXVgsGEAvdv45b cQr7oMkiOhzwW+u/e/Z/mgexHy/Wnq7jdoZoQTVUPqF3MhlcWPO6fj4OKl4ohEq2 X-Gm-Gg: AYBFou19raJA+nFDNOm3lwgqUpHcurBKqjrJ0lHbjz9LQlYh8xCmlSUa9uILq/HhepF HYAxoBb3JkBpv5VSa0WHLCLUVnp+r+SMMh8MglAeSRbJT0L8RERGl/v7r3rE9106yL68iYuH77S P+ty6kdGNnOr1kEHqiP3WJr7ZtN/QzfhCfxzauxasPxVJmGFPS9SBfmFNDpK7tINXvpB+REs5+Y c4KV3bkjB94OcWIx9aploIa87EJNFVc12QmAplMT22GMwChXCt/RCO5Jph0QsjiSehsi8W3ebG2 ZB9ddSGvZMTMHLA9ba/MH1lDxjltbcM2RXRZGwbT5SiErb64FF3PzXuRnt2KiPE7PaXBYL89XP8 FT3GIflDa94Zns3qgNAfXX+jjLr3qldarK0uvGQHbvuz4SrD/RmMRxQKlu2zDbEQZd2x847baor Y3wvJ3Mg8knwE6UTkxwWjd9dfLe7HrBg1y+A27Kf43RaZot0KnIyW3UkfC1LIrlQJVRID0MPg6r c3DUpvlsvGALyAlIXgHrxo0lyo/YqJcp7b3VzAwKCIGgr7P8+CvNYtnZLPzOAGKE2O30SXR1sN4 Q0IrYZ7b37C9UTPRcloGRG4= X-Received: by 2002:a05:693c:8854:b0:36c:a1bc:6102 with SMTP id 5a478bee46e88-36f6f88bc79mr764065eec.0.1793917270504; Thu, 05 Nov 2026 14:21:10 -0800 (PST) Received: from localhost ([2a03:2880:9ff:72::]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36fa8d44500sm51197eec.5.2026.11.05.14.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 14:21:09 -0800 (PST) From: Stanislav Fomichev X-Google-Original-From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, edumazet@kernel.org, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, sdf@fomichev.me, dimitri.daskalakis1@gmail.com, almasrymina@google.com, dtatulea@nvidia.com, bobbyeshleman@meta.com, asml.silence@gmail.com, daniel@iogearbox.net, razor@blackwall.org, leitao@debian.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org Subject: [PATCH net-next v3 8/9] net: devmem: size TX net_iovs from the dmabuf sg table Date: Thu, 5 Nov 2026 14:20:57 -0800 Message-ID: <20261105222058.944293-9-sdf@fomichev.me> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261105222058.944293-1-sdf@fomichev.me> References: <20261105222058.944293-1-sdf@fomichev.me> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PAGE_SIZE TX net_iovs cap devmem skbs at MAX_SKB_FRAGS pages (~68KB), which makes BIG TCP ineffective. TX net_iovs only need to be DMA contiguous. Use the largest power of 2, from PAGE_SIZE up to 2MB, which aligns every DMA segment of the dmabuf: - 2MB hugepage-backed udmabufs get 2MB net_iovs - no UAPI change, TX addresses are dmabuf offsets - skbs are still bounded by TCP's size_goal, only frags get larger The net_iov size doesn't depend on the device: frags are capped to the device limit when they are built, and many frags share a net_iov. Capping the net_iov instead would only split frags at net_iov boundaries and allocate more net_iovs. Signed-off-by: Stanislav Fomichev Reviewed-by: Mina Almasry Reviewed-by: Dragos Tatulea --- net/core/devmem.c | 28 ++++++++++++++++++++++++++-- net/core/netdev-genl.c | 2 +- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/net/core/devmem.c b/net/core/devmem.c index 19c039ed2cb2..98c9594dbf99 100644 --- a/net/core/devmem.c +++ b/net/core/devmem.c @@ -181,6 +181,20 @@ int net_devmem_bind_dmabuf_to_queue(struct net_device *dev, u32 rxq_idx, return err; } +static bool net_devmem_sgt_aligned(struct sg_table *sgt, size_t size) +{ + struct scatterlist *sg; + unsigned int i; + + for_each_sgtable_dma_sg(sgt, sg, i) { + if (!IS_ALIGNED(sg_dma_address(sg), size) || + !IS_ALIGNED(sg_dma_len(sg), size)) + return false; + } + return true; +} + +/* niov_shift == 0 picks the net_iov size from the dmabuf, TX only */ struct net_devmem_dmabuf_binding * net_devmem_bind_dmabuf(struct net_device *dev, void *vdev, struct device *dma_dev, @@ -191,11 +205,11 @@ net_devmem_bind_dmabuf(struct net_device *dev, void *vdev, struct netlink_ext_ack *extack) { struct net_devmem_dmabuf_binding *binding; - size_t niov_size = 1UL << niov_shift; static u32 id_alloc_next; struct scatterlist *sg; struct dma_buf *dmabuf; unsigned int sg_idx; + size_t niov_size; size_t niov_idx; size_t i; long err; @@ -221,7 +235,6 @@ net_devmem_bind_dmabuf(struct net_device *dev, void *vdev, binding->tx_max_frag_size = dev->netmem_tx_max_frag_size; write_pnet(&binding->net, sock_net(nl_sk)); binding->uid = sk_uid(nl_sk); - binding->niov_shift = niov_shift; xa_init_flags(&binding->bound_rxqs, XA_FLAGS_ALLOC); err = percpu_ref_init(&binding->ref, @@ -266,6 +279,17 @@ net_devmem_bind_dmabuf(struct net_device *dev, void *vdev, goto err_unmap; } + if (!niov_shift) { + niov_size = SZ_2M; + while (niov_size > PAGE_SIZE && + (!IS_ALIGNED(dmabuf->size, niov_size) || + !net_devmem_sgt_aligned(binding->sgt, niov_size))) + niov_size /= 2; + niov_shift = ilog2(niov_size); + } + binding->niov_shift = niov_shift; + niov_size = 1UL << niov_shift; + if (!IS_ALIGNED(dmabuf->size, niov_size)) { err = -EINVAL; NL_SET_ERR_MSG_FMT(extack, diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c index 384fdc5ae514..bfd229bd31ca 100644 --- a/net/core/netdev-genl.c +++ b/net/core/netdev-genl.c @@ -1261,7 +1261,7 @@ int netdev_nl_bind_tx_doit(struct sk_buff *skb, struct genl_info *info) binding = net_devmem_bind_dmabuf(bind_dev, bind_dev != netdev ? netdev : NULL, dma_dev, DMA_TO_DEVICE, dmabuf_fd, - PAGE_SHIFT, priv, NETLINK_CB(skb).sk, + 0, priv, NETLINK_CB(skb).sk, info->extack); if (IS_ERR(binding)) { err = PTR_ERR(binding); -- 2.53.0-Meta