From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.181 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793965595; b=Bg8XNs7X3ixus9sk2G/zrLvBlBWurHzRQwSjWyrUFDV7n36ru6yvR511CR4YpbgwsPj7 TDITLbxxx6D1UMLW8NcYrlqwxl3IqPckieC9/FMZ8CMch0Pu53YbXLsjwk4Jpiw7WYiqk G5hQqR/tZY0PIi5haNTC93w52r9uQnk4kAqc81ZWucQvRGiyzzWowVopZSKuje6i6rFlS ihoCawib0J3kaRcbzpBr98xEXko1UojKFTm5OqbKXexx+pT2XzulcyV+GYvD97KanZdD9 xo21qzxCznnkdAVk6Sq+Ba8wu+V7RaWsMEZcqPSNnVDrUkcLVb5G/nOW1yAA3+4z9sg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793965595; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=PW7RojDyoN5co1CXu90PKl7ieBhUmfH8TTR5WzS4o3I=; b=zWWTDedEdQkEcx/T9oQ05qXJay19N9V13jXQ20tqCchhItQ/Y0fpo1QTxyu8BVFLsgR3 xTxmKyxuAOU/mDrxIcfYzhpeXwj0ZN/loqaC36n5t39lNCXwD/J+DYl97s5ykrjc8ClWz RCGe0tA+rN/L5bXAcMFGGrAylYxnZkn3LwHeb1q4BpnY80RFZs9vZ1vF2uH/B5dtjPYQw x/w78zwnAJIubE/s/WZSCyIncUNHzwDh496765yf3PHmKfbfuhuHs9dqDTT+bQN+QXuA6 FNr252s9lt3DvICaMZyvZ/O/madWIbxBno7ax6rc6XhcOGTz8smswFTyV2il8kHRsqA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b="Vh0eTN7/"; arc=none smtp.remote-ip=74.125.82.181 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25CC7606BD5A for ; Fri, 6 Nov 2026 11:46:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 25CC7606BD5A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Vh0eTN7/ Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-36e99cf7bb3so870604eec.0 for ; Fri, 06 Nov 2026 03:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793965594; x=1794570394; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PW7RojDyoN5co1CXu90PKl7ieBhUmfH8TTR5WzS4o3I=; b=Vh0eTN7/JxSWLK60P1Mlw0WMnnGjwEufQsnkS/70TwLqJyiLgyjfzu0TzMvysjSjxb 9A4tdCkcJWiifGJ91fFW39s6dbSNrbCvQyrf5OL23e3lOErtHxyivpLEJmJ5mFXKDOes POZmcdujx1Jwpwg4sGQMNAwTOCQntkckNVJ4LyUhdlLmIMadXQ+iit9qCyrnXMwJgvQj TFaRTCi/P5HVLdhMrSQCgRuUiQIXKOTnThoMYbiaC68EwADTAubRICeVz+ElrEmVQlSh w2Xv3sCTm/XOt/dvB0+SzqmwhAYSZrwLmHPLVWTMgmI1sGl/2xc9z9yAZKgSGzpsPx+i 7A0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793965594; x=1794570394; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PW7RojDyoN5co1CXu90PKl7ieBhUmfH8TTR5WzS4o3I=; b=JTUx+WKdrUHg+7Ew4jHpKFcqtyQbgxLbvrl+wiHyOlZiJkBTB3Sz9hn+x9UOY1F3CO 5WlwZxdRe6rZeTisYASkXUfFNGSXFXcFClWCIi5zg2BuBybthOVUTXfj/dlxtn0jEQRD Khebyx6SknmC3I99/UcpaSAVnq1V7/d1E7bMf1ZVOi/emA9Snk9C8CzO3Bhoh1SwRIKh k+gmlNUB3TQWq1yUUaJPbto1PrTtHtli9IAdVohPn52sgFdk5NO1JSa2c46HSa9sEsY9 UgfsLI9MaKphf7d1JWldZ+TLtiUDOVWjjINW+1eDqiBLPTayNA2MmvE3xHlrj7cEW10G eTIQ== X-Gm-Message-State: APuU4Z8Aq7UuW/rc2vhk49Hk/rlkGTGfHo+GzO5O9EfYWedkFAI/pBb1 NVpdRBZb/KzckOFH1djalLDtp0X+VNKytYx3//WyG1zY5/klehw4mcHjMJKY9oiF X-Gm-Gg: AYBFou2aE40PwUG6uNrVL5K+YqbiMlUl4TsLvN8efK1s6uOmEnxnegMj4hBmUSuG8pK hcqIklSNQ9SevvyMTph6/JW5B7zPLL0QhBfBxVjqUqqRe4voqkwUUZjt3IjGY+J82JK2Wo8munA TtEhcYeKjiH7ciRenQdk5NfacVo4i6/Q3zYmConKLkq35384pWJtZHX2PiXaEJvszlbUMJQK9Ok 4hIdVVCWXbO7WB6hlU8xXzjjsXX6VPGjk3dHi7d+xOPcxNoTy+5f9TsbmT/m12JtE7OodDeViDX QLIZwSAD7+Lek9YWOwdmyrfLkI+kQEjaenjhBJOmRdpnrvJAWODrJzpMRwyHH/Ja/C74gE4fl+5 t+HKTZWVrc/THr6oK31ubgwu4XkqAYDs5udcws9Do7hx8RL91Fn5nGSA6aazGT5hjmV9R/CeXjm EJeaOpgTFDGpY9ZwMwjwjDqIGhScwm7fyBQboIdln3Vhb1XVgnbBd8FwyI0uD/dURlgYIyZu+BL R3SyqxOPDCpl93drE075a2nRRA2rn9cnTs5vTzz7YBT8OIRzE6m8J9yuBIQuQl8TOAM0TeeOqOu w484axDJbPFsAI+rpJ2vfRgmEvFA/afqmayb4BLIIGXK X-Received: by 2002:a05:7301:1522:b0:35d:4e41:d2c2 with SMTP id 5a478bee46e88-36f77eda447mr2941017eec.33.1793965594008; Fri, 06 Nov 2026 03:46:34 -0800 (PST) Received: from localhost.localdomain ([2406:7400:51:1d31:c2b6:f9ff:fe77:10a0]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36fa9be7077sm6167055eec.17.2026.11.06.03.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2026 03:46:33 -0800 (PST) From: Amaan Cheval To: netdev@vger.kernel.org Cc: joshwash@google.com, hramamurthy@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, bcf@google.com, jordanrhee@google.com, przemyslaw.kitszel@intel.com, maciej.fijalkowski@intel.com, pkaligineedi@google.com, maolson@google.com, csully@google.com, willemb@google.com, yangchun@google.com, npl@google.com, awogbemila@google.com, shailend@google.com, nktgrg@google.com, maxyuan@google.com, bpf@vger.kernel.org, john.fastabend@gmail.com, hawk@kernel.org, sdf@fomichev.me, daniel@iogearbox.net, ast@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Amaan Cheval Subject: [PATCH net v4 1/2] gve: block XDP on the DQO-QPL queue format Date: Fri, 6 Nov 2026 17:15:50 +0530 Message-ID: <20261106114551.212675-2-amaan.cheval@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20261106114551.212675-1-amaan.cheval@gmail.com> References: <20261106114551.212675-1-amaan.cheval@gmail.com> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit d8a8ca14c937 ("gve: add XDP_TX and XDP_REDIRECT support for DQ RDA") enabled XDP on DQO-RDA by dropping the queue_format check from verify_xdp_configuration(), which until then refused every format but GQI-QPL. Nothing replaced it for DQO-QPL: gve_set_netdev_xdp_features() advertises no XDP features there and gve_xdp_xmit() rejects it, but the core only checks that ndo_bpf exists, so a native XDP program, and an AF_XDP socket on top of it, can still be attached on DQO-QPL. The DQO-QPL RX path was never written for that. Its page accounting assumes the driver keeps a reference of its own across every handoff: gve_xdp_done_dqo() passes the buffer to xdp_do_redirect() and then recycles it with gve_reuse_buffer(), so a redirect target that releases the buffer synchronously, such as an AF_XDP socket in copy mode, can drop the page's last reference when pagecnt_bias runs out. The page is then freed while it is still DMA-mapped and registered in the QPL, and the driver posts it back to the device. Refuse XDP program setup on DQO-QPL in gve_verify_xdp_configuration(), matching the features the driver advertises. A zero-copy XSK pool bind is already refused by the core for the same reason, and a copy-mode bind never reaches the driver and is harmless without a program. Fixes: d8a8ca14c937 ("gve: add XDP_TX and XDP_REDIRECT support for DQ RDA") Cc: stable@vger.kernel.org Signed-off-by: Amaan Cheval --- drivers/net/ethernet/google/gve/gve_main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c index 2437cd8ba633..4e9e692a0ed0 100644 --- a/drivers/net/ethernet/google/gve/gve_main.c +++ b/drivers/net/ethernet/google/gve/gve_main.c @@ -1723,6 +1723,12 @@ static int gve_verify_xdp_configuration(struct net_device *dev, struct gve_priv *priv = netdev_priv(dev); u16 max_xdp_mtu; + if (priv->queue_format == GVE_DQO_QPL_FORMAT) { + NL_SET_ERR_MSG_MOD(extack, + "XDP is not supported in DQO QPL queue format."); + return -EOPNOTSUPP; + } + if (dev->features & NETIF_F_GRO_HW) { NL_SET_ERR_MSG_MOD(extack, "XDP is not supported when HW-GRO is on."); -- 2.47.3