From: Jakub Kicinski <kuba@kernel.org>
To: Mengyuan Lou <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com,
duanqiangwen@net-swift.com, linglingzhang@net-swift.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, hramamurthy@google.com,
jacob.e.keller@intel.com, stable@vger.kernel.org
Subject: Re: [PATCH net v7] net: libwx: fix VF PM suspend/resume flow
Date: Fri, 6 Nov 2026 13:20:52 -0800 [thread overview]
Message-ID: <20261106132052.1c719cad@kernel.org> (raw)
In-Reply-To: <20261029104220.77344-1-mengyuanlou@net-swift.com>
On Thu, 29 Oct 2026 18:42:20 +0800 Mengyuan Lou wrote:
> +open_failed:
> +hard_failure:
The labels should be named after what they do, not the source.
Please read the coding style guide.
> + /* Do not retry interrupt setup or reopen from the service task. Keep the
> + * netdev detached and down, and disable PCI.
> + * Retry by rebinding the driver or through a later PM resume; bring the
> + * interface up after recovery.
> + */
> + timer_delete_sync(&wx->service_timer);
--
pw-bot: cr
next prev parent reply other threads:[~2026-11-06 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 10:42 [PATCH net v7] net: libwx: fix VF PM suspend/resume flow Mengyuan Lou
2026-10-29 10:46 ` netdev-bot+sinfo
2026-11-06 21:20 ` Jakub Kicinski [this message]
2026-11-07 12:43 ` mengyuanlou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261106132052.1c719cad@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=linglingzhang@net-swift.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox