Re: [PATCH net v5 2/2] enic: require DEVCMD2 and set the V2 VF mailbox source

[Satish Kharat <satishkh@cisco.com>]

Thanks for the review.

The statistics ABI keeps the version-1 prefix stable when later fields
are added. V6 will therefore accept version 1 or later, while continuing
to reject version 0 and the PF-source sentinel. Focused tests accepted a
synthetic version-2 response and rejected version 0 and the sentinel.

CMD_SRIOV_STATS_GET is intentionally mandatory for V2 VF probe. Without
it the driver cannot determine a trustworthy mailbox source ID. A
CMD_CAPABILITY check would only detect the same unsupported-command case
earlier; it cannot provide the VF ID or a safe fallback. A V2 VF whose
device does not implement the command will continue to fail probe. V6
will state this explicitly.

I will also narrow the sriov_stats_dma_unresolved comment to the two
completion observations implemented by the code: a blocking QP command
or CMD_CLOSE.

I have made these changes in V6 and will post the revision shortly.

pw-bot: cr