Re: [PATCH net-next 2/2] net sysfs: simplify creating empty wireless directory

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sun, Nov 08, 2026 at 03:12:04PM +0100, Heiner Kallweit wrote:
> On 08.11.2026 15:06, Greg Kroah-Hartman wrote:
> > On Sun, Nov 08, 2026 at 02:46:03PM +0100, Heiner Kallweit wrote:
> >> Now that an empty directory can be created with attrs being NULL,
> >> make use of this new functionality and remove the dummy attribute list.
> >>
> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >> ---
> >>  net/core/net-sysfs.c | 5 -----
> >>  1 file changed, 5 deletions(-)
> >>
> >> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> >> index 5c0402389c6..f58b59e1126 100644
> >> --- a/net/core/net-sysfs.c
> >> +++ b/net/core/net-sysfs.c
> >> @@ -910,13 +910,8 @@ static const struct attribute_group netstat_group = {
> >>  	.attrs  = netstat_attrs,
> >>  };
> >>  
> >> -static struct attribute *wireless_attrs[] = {
> >> -	NULL
> >> -};
> >> -
> >>  static const struct attribute_group wireless_group = {
> >>  	.name = "wireless",
> >> -	.attrs = wireless_attrs,
> > 
> > Why does this want to create an empty directory?  Surely you aren't
> > adding attributes later to it, right?  If so, that's not ok either...
> > 
> 
> For compatibility reasons. See 38c1a01cf10c ("wireless: add back sysfs directory")

How long do we have to keep that?  That was a very long time ago, 2012,
why not just remove it entirely now?  And if the sysfs core hasn't
needed this since then, why give other people the opportunity to abuse
it this way as well?  That doesn't feel like a good idea to me.

thanks,

greg k-h