From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next v3 3/4] selftests: drv-net: add a kperf runner
Date: Mon, 9 Nov 2026 15:44:04 -0800 [thread overview]
Message-ID: <20261109154404.691d94ac@kernel.org> (raw)
In-Reply-To: <20261102190827.989117-4-sdf@fomichev.me>
On Mon, 2 Nov 2026 11:08:26 -0800 Stanislav Fomichev wrote:
> + def _wait_exit(self, remote, timeout=60):
> + """Wait for the sessions of a server to exit.
> +
> + Killing the server leaves its sessions, which exit once they have
> + released their devmem and RX steering, which the next test needs.
> + Being forked, they run with the server's command line. The
> + bracket keeps pgrep from matching the shell which runs it.
> + """
> + host = self.env.remote if remote else None
> + args = ["pgrep", "-f",
> + f"[k]perf-server --pid-file {self._pid_file(remote)}"]
> + deadline = time.monotonic() + timeout
> + while True:
> + pgrep = cmd(shlex.join(args) if remote else args, host=host,
> + fail=False)
> + if pgrep.ret:
> + return None
> + if time.monotonic() > deadline:
> + return pgrep
> + time.sleep(0.1)
bit ugly, can we not make sure kperf --kill does the right thing?
next prev parent reply other threads:[~2026-11-09 23:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 19:08 [PATCH net-next v3 0/4] selftests: net: add performance metric reporting Stanislav Fomichev
2026-11-02 19:08 ` [PATCH net-next v3 1/4] selftests: net: py: add metric output Stanislav Fomichev
2026-11-03 4:54 ` Björn Töpel
2026-11-09 23:41 ` Jakub Kicinski
2026-11-02 19:08 ` [PATCH net-next v3 2/4] selftests: drv-net: add an iperf performance test Stanislav Fomichev
2026-11-03 5:02 ` Björn Töpel
2026-11-03 19:10 ` Stanislav Fomichev
2026-11-02 19:08 ` [PATCH net-next v3 3/4] selftests: drv-net: add a kperf runner Stanislav Fomichev
2026-11-03 5:03 ` Björn Töpel
2026-11-09 23:44 ` Jakub Kicinski [this message]
2026-11-02 19:08 ` [PATCH net-next v3 4/4] selftests: drv-net: measure devmem performance with kperf Stanislav Fomichev
2026-11-03 5:05 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109154404.691d94ac@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox