Re: [PATCH net v3 2/2] net/sched: sch_teql: keep skb->dev consistent on the arp-queue path

[Simon Horman <horms@kernel.org>]

On Mon, Nov 09, 2026 at 06:44:09AM -0500, Jamal Hadi Salim wrote:
> On Sat, Nov 7, 2026 at 10:16 AM <netdev-bot+sashiko@kernel.org> wrote:
> >
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider.
> >
> > Critical: 0 · High: 0 · Medium: 1 · Low: 1
> >
> > If you believe none of the issues are legitimate, please reply to each
> > issue of Medium severity or higher and explain why the AI is wrong.
> > If any of them are legitimate and you plan to respin, please let patchwork
> > know by including "pw-bot: cr" as a separate line at the end of your reply
> > (one such reply per series is enough).
> >
> > - [Medium] The new gate in neigh_update_process_arp_queue()
> >   (net/core/neighbour.c), `if (!n1->dev->header_ops) skb->dev =…
> > - [Low] The comment added in neigh_update_process_arp_queue()
> >   (net/core/neighbour.c), '/* headerless outputs (teql, shaper) transmit…
> >
> 
> I think i missed responding to this one. Sashiko-nipa responses are
> very erratic. For some threads (not mine) a review shows up 2-3 days
> later. For mine the average time seems to be 7 days and sometimes a vN
> review appears a few days later after a vN+1.
> 
> Summary: I will not be spinning anything for this series since there
> are no new code change requirements. I have addressed the
> neigh_update_process_arp_queue() issue as a separate (producer) issue
> in the past; it's a separate net-next focusing on producers. The
> comment (Low) i would have rectified if there was something meaningful
> to make me respin.

Reviewed-by: Simon Horman <horms@kernel.org>