From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, YehezkelShB@gmail.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH 1/2] net: thunderbolt: Stop queueing Rx buffers if allocation fails
Date: Tue, 10 Nov 2026 15:21:45 +0100 [thread overview]
Message-ID: <20261110142145.GA259790@black.igk.intel.com> (raw)
In-Reply-To: <179406690879.994134.8991092134542553771@kernel.org>
Hi,
On Sat, Nov 07, 2026 at 03:55:08PM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 5 potential
> issue(s) to consider.
>
> Critical: 0 · High: 3 · Medium: 0 · Low: 2
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] tbnet_poll() (drivers/net/thunderbolt/main.c) can stop Rx
> permanently when a refill fails.
> - [High] The new deficit-based cleaned_count in tbnet_poll() (lines
> 829-831) lets a NAPI poll that runs after teardown allocate and strand…
> - [High] tbnet_poll() no longer completes NAPI while allocations keep
> failing and the ring is empty (the new `return budget` at line 936),…
I agree all of them. I will submit v2 with these fixed.
pw-bot: cr
prev parent reply other threads:[~2026-11-10 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 12:56 [PATCH 1/2] net: thunderbolt: Stop queueing Rx buffers if allocation fails Mika Westerberg
2026-11-03 12:56 ` [PATCH 2/2] net: thunderbolt: Prevent Tx descriptor leak in tbnet_start_xmit() Mika Westerberg
2026-11-03 12:57 ` [PATCH 1/2] net: thunderbolt: Stop queueing Rx buffers if allocation fails netdev-bot+sinfo
2026-11-07 15:55 ` netdev-bot+sashiko
2026-11-10 14:21 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110142145.GA259790@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox