Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: netdev-bot+sinfo@kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Kuniyuki Iwashima <kuni1840@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH v1 net] net: Fix memory_allocated leak in __sk_mem_raise_allocated().
Date: Tue, 10 Nov 2026 15:25:41 -0800	[thread overview]
Message-ID: <20261110152541.04462dda@kernel.org> (raw)
In-Reply-To: <CAAVpQUCYHbdAdfxckQO=T5L8Y6896SZynJeGFUwP9Hv2dXDpTw@mail.gmail.com>

On Thu, 5 Nov 2026 13:45:21 -0800 Kuniyuki Iwashima wrote:
> > This is an automated message. This series looks like a fix, but its
> > commit messages seem to be missing some information:
> >
> >  - Whether the issue was actually triggered, or is only theoretical
> >    (e.g. found by code inspection).  
> 
> "Found this while converting sk_memcg to obj_cgroup."

I assume you mean to imply that this sentence answers the question of
whether it was triggered, but either I'm too limited or it doesn't.
It only explains how you find the issue, which is _not_ what the bot
is asking.

> > If it was triggered please include
> >    the symptoms, like the stack trace or error messages.  
> 
> "Then, if mem_cgroup_sk_charge() succeeds, sk_prot_mem_limits()
> checks are bypassed, and if mem_cgroup_sk_charge() fails,
> sk_memory_allocated_sub() is not called, leaking counters."

"symptoms" mean dmesg basically. Please suggest better phrasing,
if you can think of it. 

  reply	other threads:[~2026-11-10 23:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 21:29 [PATCH v1 net] net: Fix memory_allocated leak in __sk_mem_raise_allocated() Kuniyuki Iwashima
2026-11-05 21:37 ` netdev-bot+sinfo
2026-11-05 21:45   ` Kuniyuki Iwashima
2026-11-10 23:25     ` Jakub Kicinski [this message]
2026-11-11  0:19       ` Kuniyuki Iwashima
2026-11-10 23:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110152541.04462dda@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=kuniyu@google.com \
    --cc=netdev-bot+sinfo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox