Netdev List
 help / color / mirror / Atom feed
From: Minxi Hou <houminxi@gmail.com>
To: netdev@vger.kernel.org
Cc: Aaron Conole <aconole@redhat.com>,
	Eelco Chaudron <echaudro@redhat.com>,
	Ilya Maximets <i.maximets@ovn.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	dev@openvswitch.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v2 2/2] selftests/net/openvswitch: check that a failed set keeps the features
Date: Tue, 10 Nov 2026 12:51:34 -0500	[thread overview]
Message-ID: <20261110175134.977835-1-houminxi@gmail.com> (raw)
In-Reply-To: <179423058020.994134.14656142555028492016@kernel.org>

On 2026-11-09 08:23, Sashiko wrote:
> [Medium] In test_dp_features, the skip path does not call ovs_exit_sig.
> [Low] CONFIG_NET_TC_SKB_EXT is not in sort order.
> [Low] Should CONFIG_NET_SCHED=y be added to the fragment too?

All three are in v3. The recirc round is a test of its own now, and it
calls ovs_exit_sig before it returns the skip code, like the other skips
in the middle of a test in that file.

The fragment has CONFIG_NET_SCHED=y, CONFIG_NET_CLS_ACT=y and
CONFIG_NET_TC_SKB_EXT=y, with the last one after CONFIG_NET_IPGRE_DEMUX
in the order that ignores underscores.

Two more changes on the way. The skip reason is printed to stdout, so a
run that skipped the recirc round no longer ends as a plain pass with no
sign that the round did not run. And the expected errno is read from
python rather than written as 95, because EOPNOTSUPP is 45 on alpha and
sparc, 122 on mips and 223 on parisc, where a hardcoded number would
turn a real failure into a skip.

      reply	other threads:[~2026-11-10 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08 12:34 [PATCH net v2 0/2] net: openvswitch: fix a feature leak on a failed change Minxi Hou
2026-11-08 12:34 ` [PATCH net v2 1/2] net: openvswitch: do not record user features when the change fails Minxi Hou
2026-11-09 13:22   ` netdev-bot+sashiko
2026-11-10 17:51     ` Minxi Hou
2026-11-08 12:34 ` [PATCH net v2 2/2] selftests/net/openvswitch: check that a failed set keeps the features Minxi Hou
2026-11-09 13:23   ` netdev-bot+sashiko
2026-11-10 17:51     ` Minxi Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110175134.977835-1-houminxi@gmail.com \
    --to=houminxi@gmail.com \
    --cc=aconole@redhat.com \
    --cc=dev@openvswitch.org \
    --cc=echaudro@redhat.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox