Netdev List
 help / color / mirror / Atom feed
From: Ralf Lici <ralf@mandelbit.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
	Ido Schimmel <idosch@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Neal Cardwell <ncardwell@google.com>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Florian Westphal <fw@strlen.de>,
	Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH net-next 2/3] ipv6: add ip6_dst_lookup_flow_cookie
Date: Wed, 11 Nov 2026 08:30:09 +0100	[thread overview]
Message-ID: <20261111073009.18754-1-ralf@mandelbit.com> (raw)
In-Reply-To: <20261110152928.4ef1bf6b@kernel.org>

Hi,

On Tue, 10 Nov 2026 15:29:28 -0800, Jakub Kicinski <kuba@kernel.org> wrote:
> On Wed,  4 Nov 2026 16:53:30 +0100 Ralf Lici wrote:
> > +/**
> > + *	ip6_dst_lookup_flow_cookie - perform route lookup on flow with ipsec
> > + *				     and return the matching dst cookie
> > + *	@net: Network namespace to perform lookup in
> > + *	@sk: socket which provides route info
> > + *	@fl6: flow to lookup
> > + *	@final_dst: final destination address for ipsec lookup
> > + *	@cookie: where to store the cookie for the returned dst
> > + *
> > + *	Same as ip6_dst_lookup_flow(), but also returns the cookie describing
> > + *	the routing state the dst was obtained from. A caller caching the dst
> > + *	should use this cookie when validating it with dst_check(). If the
> > + *	IPv6 FIB changed during the lookup, a route dst no longer validates
> > + *	with it. An xfrm bundle is validated by xfrm and ignores the cookie.
> > + *
> > + *	It returns a valid dst pointer on success, or a pointer encoded
> > + *	error code.
>
> Warning: net/ipv6/ip6_output.c:1325 No description found for return value of 'ip6_dst_lookup_flow_cookie'
>
> You need to use the appropriate keyword (Return: or Returns:)
>

Yep, saw that, nonetheless I was hoping for some feedback on the general
approach, but I'll respin with the kdoc fix.

BTW is the kdoc error the reason why netdev/contest reports "Failed gate
checks"?

Thanks!

-- 
Ralf Lici
Mandelbit Srl

  reply	other threads:[~2026-11-11  7:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 15:53 [PATCH net-next 0/3] ipv6: tie the dst cookie to the lookup that returned the dst Ralf Lici
2026-11-04 15:53 ` [PATCH net-next 1/3] ipv6: stamp the default route node with a fresh serial on link failure Ralf Lici
2026-11-04 15:53 ` [PATCH net-next 2/3] ipv6: add ip6_dst_lookup_flow_cookie Ralf Lici
2026-11-10 23:29   ` Jakub Kicinski
2026-11-11  7:30     ` Ralf Lici [this message]
2026-11-11 21:12       ` Jakub Kicinski
2026-11-04 15:53 ` [PATCH net-next 3/3] ipv6: use the lookup cookie when caching the dst in sockets Ralf Lici

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111073009.18754-1-ralf@mandelbit.com \
    --to=ralf@mandelbit.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sd@queasysnail.net \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox