From: Jakub Kicinski <kuba@kernel.org>
To: Arthur Kiyanovski <akiyano@amazon.com>
Cc: Avi Weiss <thnkslprpt@gmail.com>,
David Arinzon <darinzon@amazon.com>, <netdev@vger.kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] net: ena: avoid double-counting TX DMA mappings on failure
Date: Wed, 11 Nov 2026 17:11:27 -0800 [thread overview]
Message-ID: <20261111171127.7ce982b5@kernel.org> (raw)
In-Reply-To: <179444039825.7144.5680478965949082764.b4-review@b4>
On Wed, 11 Nov 2026 23:39:58 +0000 Arthur Kiyanovski wrote:
> Therefore please do the following:
>
> 1. Add a From: tag to give credit to Evgeny Ostrovsky, who wrote this fix
> (without leading "-"):
>
> - From: Evgeny Ostrovsky <evostrov@amazon.com>
Unclear whether that's warranted TBH.
Avi is making the effort to upstream the fix, they deserve the credit.
> This should be first line before "ena_tx_map_skb() increme..."
>
> 2. Evgeny has agreed, please also add (without leading "-"):
>
> - Signed-off-by: Evgeny Ostrovsky <evostrov@amazon.com>
SoB indeed seems appropriate if the patch is based on prior work.
next prev parent reply other threads:[~2026-11-12 1:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 12:39 [PATCH net] net: ena: avoid double-counting TX DMA mappings on failure Avi Weiss
2026-11-09 12:41 ` netdev-bot+sinfo
2026-11-11 23:39 ` Arthur Kiyanovski
2026-11-12 1:11 ` Jakub Kicinski [this message]
2026-11-12 1:30 ` Kiyanovski, Arthur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111171127.7ce982b5@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thnkslprpt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox