Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: "Robin Murphy" <robin.murphy@arm.com>,
	m.szyprowski@samsung.com, netdev@vger.kernel.org,
	iommu@lists.linux.dev, joro@8bytes.org, will@kernel.org,
	"Björn Töpel" <bjorn@kernel.org>
Subject: Re: [PATCH 04/11] dma-contiguous: pass the NUMA node to dma_alloc_contiguous()
Date: Thu, 12 Nov 2026 08:17:44 -0800	[thread overview]
Message-ID: <20261112081744.3ba9cd82@kernel.org> (raw)
In-Reply-To: <c014414f-fdd2-4a79-b133-44671c0e4475@redhat.com>

On Thu, 12 Nov 2026 16:43:51 +0100 Paolo Abeni wrote:
> >> I'm possibly over-thinking here, but AFAICS there are a bunch of dma_map_ops that
> >> are using dev_to_node():
> >>
> >> dma_iommu_alloc_coherent() in arch/powerpc/kernel/dma-iommu.c
> >> vio_dma_iommu_alloc_coherent() in arch/powerpc/platforms/pseries/vio.c
> >> gart_alloc_coherent() in arch/x86/kernel/amd_gart_64.c
> >>
> >> With this series they will stop using the driver provided numa node.
> >> Probably not a blocker but possibly worth to call out?  
> > 
> > Nothing "stops" - this series adds a *new* interface by which
> > drivers can now indicate a specific preferred node, but DMA API
> > backends are still free to ignore the caller-provided hint and
> > continue doing whatever they want. This is already called out all
> > over the series in commit messages, documentation and comments
> > including the one above.  
>
> I mean: the series also replaces the old hacks with the new APIs usage
> in a few drivers, and in the above cases there could be actual
> regressions.
> 
> But I guess we could handle them if and when they will surface.

I know AI helps people surface unlikely cases but we need to draw 
the line somewhere.

  reply	other threads:[~2026-11-12 16:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 18:44 [PATCH 00/11] dma-mapping: add dma_alloc_attrs_node() and dma_alloc_coherent_node() Jakub Kicinski
2026-11-06 18:44 ` [PATCH 01/11] " Jakub Kicinski
2026-11-06 23:41   ` Marek Szyprowski
2026-11-06 18:44 ` [PATCH 02/11] dma-direct: add dma_direct_alloc_node() Jakub Kicinski
2026-11-06 18:44 ` [PATCH 03/11] iommu/dma: pass the NUMA node to iommu_dma_alloc() Jakub Kicinski
2026-11-06 18:44 ` [PATCH 04/11] dma-contiguous: pass the NUMA node to dma_alloc_contiguous() Jakub Kicinski
2026-11-12  9:53   ` Paolo Abeni
2026-11-12 13:28     ` Robin Murphy
2026-11-12 15:43       ` Paolo Abeni
2026-11-12 16:17         ` Jakub Kicinski [this message]
2026-11-12 16:21         ` Robin Murphy
2026-11-06 18:44 ` [PATCH 05/11] eth: libwx: restore the device's NUMA node after ring allocation Jakub Kicinski
2026-11-06 18:44 ` [PATCH 06/11] eth: libwx: use dma_alloc_coherent_node() Jakub Kicinski
2026-11-06 18:44 ` [PATCH 07/11] eth: ixgbe: " Jakub Kicinski
2026-11-06 18:44 ` [PATCH 08/11] eth: xgbe: " Jakub Kicinski
2026-11-06 18:44 ` [PATCH 09/11] eth: fungible: " Jakub Kicinski
2026-11-06 18:44 ` [PATCH 10/11] eth: mlx5: " Jakub Kicinski
2026-11-12 12:31   ` Tariq Toukan
2026-11-06 18:44 ` [PATCH 11/11] eth: mlx4: " Jakub Kicinski
2026-11-12 12:32   ` Tariq Toukan
2026-11-12 16:16 ` [PATCH 00/11] dma-mapping: add dma_alloc_attrs_node() and dma_alloc_coherent_node() Jakub Kicinski
2026-11-12 16:51 ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112081744.3ba9cd82@kernel.org \
    --to=kuba@kernel.org \
    --cc=bjorn@kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=m.szyprowski@samsung.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox