From: Christian Marangi <ansuelsmth@gmail.com>
To: Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Christian Marangi <ansuelsmth@gmail.com>
Subject: [PATCH net-next 2/2] net: phy: fix trivial whitespace/format issue
Date: Thu, 12 Nov 2026 14:13:57 +0100 [thread overview]
Message-ID: <20261112131358.106442-2-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20261112131358.106442-1-ansuelsmth@gmail.com>
Running checkpatch on phylink code, points out some trivial issue with
whitespace instead of tab, if-else condition with a return in the if
condition and manually printing the function name instead of using
__func__.
Fix all of these trivial issue to mute checkpatch warning.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/net/phy/phylink.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index bf1962e572f8..e7734e45376c 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -3151,7 +3151,7 @@ int phylink_ethtool_ksettings_get(struct phylink *pl,
EXPORT_SYMBOL_GPL(phylink_ethtool_ksettings_get);
static bool phylink_validate_pcs_inband_autoneg(struct phylink *pl,
- phy_interface_t interface,
+ phy_interface_t interface,
unsigned long *adv)
{
unsigned int inband = phylink_inband_caps(pl, interface);
@@ -4080,12 +4080,12 @@ static int phylink_sfp_module_start(void *upstream)
if (pl->phydev) {
phy_start(pl->phydev);
return 0;
- } else {
- ret = phylink_add_sfp_mod_port(pl);
- if (ret)
- return ret;
}
+ ret = phylink_add_sfp_mod_port(pl);
+ if (ret)
+ return ret;
+
/* If the module may have a PHY but we didn't detect one we
* need to configure the MAC here.
*/
@@ -4207,6 +4207,7 @@ void phylink_resolve_c73(struct phylink_link_state *state)
for (i = 0; i < ARRAY_SIZE(phylink_c73_priority_resolution); i++) {
int bit = phylink_c73_priority_resolution[i].bit;
+
if (linkmode_test_bit(bit, state->advertising) &&
linkmode_test_bit(bit, state->lp_advertising))
break;
@@ -4635,7 +4636,8 @@ void phylink_replay_link_end(struct phylink *pl)
if (WARN(!test_bit(PHYLINK_DISABLE_REPLAY,
&pl->phylink_disable_state),
- "phylink_replay_link_end() called without a prior phylink_replay_link_begin()\n"))
+ "%s called without a prior phylink_replay_link_begin()\n",
+ __func__))
return;
pl->force_major_config = true;
--
2.55.0
prev parent reply other threads:[~2026-11-12 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 13:13 [PATCH net-next 1/2] net: phy: use const char * const for phylink_an_mode_str Christian Marangi
2026-11-12 13:13 ` Christian Marangi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112131358.106442-2-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox