From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@kernel.org, andrew+netdev@lunn.ch,
netdev@vger.kernel.org
Cc: Mohammad Heib <mheib@redhat.com>,
anthony.l.nguyen@intel.com, fballuch@redhat.com,
aleksandr.loktionov@intel.com, luoxuanqiang@kylinos.cn,
jbrandeb@kernel.org, Joe Damato <joe@dama.to>,
Alexander Nowlin <alexander.nowlin@intel.com>
Subject: [PATCH net 1/6] i40e: fix napi_disable hang in i40e_down() during firmware update
Date: Thu, 12 Nov 2026 16:45:55 -0800 [thread overview]
Message-ID: <20261113004602.129864-2-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20261113004602.129864-1-anthony.l.nguyen@intel.com>
From: Mohammad Heib <mheib@redhat.com>
i40e_down() expects its caller to set __I40E_VSI_DOWN before calling it,
as noted in the comment at the top of the function. All callers do this
except i40e_vsi_reinit_locked(), which calls i40e_down() directly
without setting the flag.
Normally this doesn't cause problems because NAPI drains cleanly on its
own. But when the hardware is in a bad state, like during an NVM
firmware update, the ring descriptors can contain garbage that
i40e_napi_poll() sees as real work. Since __I40E_VSI_DOWN isn't set, the
poll function has no reason to bail out. It keeps returning budget,
napi_disable() keeps waiting, and the whole thing hangs. The thread
stuck in napi_disable() is usually NetworkManager, and because it holds
the RTNL lock, the system can end up completely frozen.
Set __I40E_VSI_DOWN in i40e_vsi_reinit_locked() before calling
i40e_down(). i40e_up_complete() already clears the flag when the VSI
comes back up, so no additional cleanup is needed.
Fixes: 41c445ff0f48 ("i40e: main driver core")
Signed-off-by: Mohammad Heib <mheib@redhat.com>
Reviewed-by: Joe Damato <joe@dama.to>
Tested-by: Alexander Nowlin <alexander.nowlin@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index abbc71e815ae..dd729776c64d 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -7461,6 +7461,8 @@ static void i40e_vsi_reinit_locked(struct i40e_vsi *vsi)
while (test_and_set_bit(__I40E_CONFIG_BUSY, pf->state))
usleep_range(1000, 2000);
+ /* required by i40e_down() */
+ set_bit(__I40E_VSI_DOWN, vsi->state);
i40e_down(vsi);
i40e_up(vsi);
--
2.47.1
next prev parent reply other threads:[~2026-11-13 0:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 0:45 [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-12 (i40e, iavf) Tony Nguyen
2026-11-13 0:45 ` Tony Nguyen [this message]
2026-11-17 0:47 ` [PATCH net 1/6] i40e: fix napi_disable hang in i40e_down() during firmware update netdev-bot+sashiko
2026-11-13 0:45 ` [PATCH net 2/6] i40e: fix freeing of TX rings on RX allocation failure Tony Nguyen
2026-11-13 0:45 ` [PATCH net 3/6] i40e: avoid resetting BQL state when freeing temporary Tx rings in set_ringparam Tony Nguyen
2026-11-17 0:47 ` netdev-bot+sashiko
2026-11-13 0:45 ` [PATCH net 4/6] iavf: fix QoS capabilities memory leak Tony Nguyen
2026-11-13 0:45 ` [PATCH net 5/6] iavf: fix ASQ command buffer leak on init failure Tony Nguyen
2026-11-13 0:46 ` [PATCH net 6/6] iavf: add missing PTP adjustment callbacks Tony Nguyen
2026-11-13 0:52 ` [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-12 (i40e, iavf) netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113004602.129864-2-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=alexander.nowlin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fballuch@redhat.com \
--cc=jbrandeb@kernel.org \
--cc=joe@dama.to \
--cc=kuba@kernel.org \
--cc=luoxuanqiang@kylinos.cn \
--cc=mheib@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox