Netdev List
 help / color / mirror / Atom feed
From: Wei Tao <taowei@kylinos.cn>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Jiri Pirko <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next v2] net/sched: cls_flow: avoid integer overflow in perturb_period
Date: Fri, 13 Nov 2026 10:40:24 +0800	[thread overview]
Message-ID: <20261113024024.68282-1-taowei@kylinos.cn> (raw)
In-Reply-To: <62abc297-daf8-415f-9450-202d226ebd9e@redhat.com>

On Thu, 12 Nov 2026 08:44:46 -0500, Paolo Abeni wrote:
> Sashiko noted the added code could by simplified/substituted with
> a NLA_POLICY_FULL_RANGE(NLA_U32, &range):
> https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106063823.99731-1-taowei@kylinos.cn

Thanks.  I replaced the open-coded checks with
NLA_POLICY_FULL_RANGE(NLA_U32, &flow_perturb_range) and passed extack to
nla_parse_nested_deprecated(), so both the create and the change paths are
validated by the parser.  The range is 0 .. INT_MAX / HZ.

I will post v3 as a new thread shortly.

Thanks,
Wei Tao


      reply	other threads:[~2026-11-13  2:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16  4:03 [PATCH net] net/sched: cls_flow: avoid integer overflow in perturb_period Wei Tao
2026-10-16  4:08 ` netdev-bot+sinfo
2026-10-20 21:24 ` Jakub Kicinski
2026-10-21 12:43   ` Wei Tao
2026-11-06  6:38 ` [PATCH net-next v2] " Wei Tao
2026-11-12 13:43   ` Paolo Abeni
2026-11-13  2:40     ` Wei Tao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113024024.68282-1-taowei@kylinos.cn \
    --to=taowei@kylinos.cn \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox