Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: ast@kernel.org
Cc: Rongguang Wei <clementwei90@163.com>,
	netdev@vger.kernel.org, bpf@vger.kernel.org,
	willemdebruijn.kernel@gmail.com, jasowangio@gmail.com,
	andrew+netdev@lunn.ch, davem@davemloft.net, daniel@iogearbox.net,
	andrii@kernel.org, eddyz87@gmail.com,
	Rongguang Wei <weirongguang@kylinos.cn>,
	Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net v10 1/2] tun: keep a kernel copy of the socket filter program
Date: Fri, 13 Nov 2026 16:27:51 -0800	[thread overview]
Message-ID: <20261113162751.309d3544@kernel.org> (raw)
In-Reply-To: <20261109023848.59575-2-clementwei90@163.com>

On Mon,  9 Nov 2026 10:38:47 +0800 Rongguang Wei wrote:
> TUNATTACHFILTER copies only the sock_fprog header, so tun->fprog.filter
> stays a pointer into the address space of the process that issued the
> ioctl. tun_attach() reads it again whenever a queue is attached to the
> persistent device later on.

Alexei, would you mind glancing over this one?
Nothing stands out but the net/core/filter.c changes deserve a BPF ack.
(Or feel free to take it via bpf if you prefer.) 

https://lore.kernel.org/all/20261109023848.59575-2-clementwei90@163.com/

  parent reply	other threads:[~2026-11-14  0:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  2:38 [PATCH net v10 0/2] tun: fix re-attaching the socket filter Rongguang Wei
2026-11-09  2:38 ` [PATCH net v10 1/2] tun: keep a kernel copy of the socket filter program Rongguang Wei
2026-11-11 20:41   ` netdev-bot+sashiko
2026-11-12  1:40     ` weirongguang
2026-11-14  0:27   ` Jakub Kicinski [this message]
2026-11-09  2:38 ` [PATCH net v10 2/2] selftests: net: add TAP socket filter attach tests Rongguang Wei
  -- strict thread matches above, loose matches on Subject: below --
2026-11-09  2:37 [PATCH net v10 0/2] tun: fix re-attaching the socket filter Rongguang Wei
2026-11-09  2:37 ` [PATCH net v10 1/2] tun: keep a kernel copy of the socket filter program Rongguang Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113162751.309d3544@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=clementwei90@163.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=eddyz87@gmail.com \
    --cc=jasowangio@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=weirongguang@kylinos.cn \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox