From: Henry Martin <bsdhenrymartin@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
Stanislav Fomichev <sdf.kernel@gmail.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Yuyang Huang <sigefriedhyy@gmail.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Henry Martin <bsdhenrymartin@gmail.com>,
stable@vger.kernel.org
Subject: [PATCH] net: fix uninitialized heap leak in multicast address dumps
Date: Mon, 16 Nov 2026 10:40:56 +0800 [thread overview]
Message-ID: <20261116024056.1274402-1-bsdhenrymartin@gmail.com> (raw)
__hw_addr_create() allocates entries with kmalloc() and initializes
only addr_len bytes of ha->addr. Dump paths emit entries using the
current dev->addr_len, which can grow after the entry was created:
tun's TUNSETLINK changes a device from ARPHRD_NONE (addr_len 0) to
ARPHRD_IP6GRE (addr_len 16). Both the RTM_GETMULTICAST dump and
/proc/net/dev_mcast then emit up to 16 bytes of never-written slab
memory per entry.
This discloses leftover kernel heap contents to anyone reading those
interfaces.
Zero the tail of ha->addr at creation time, so dumps can only emit
initialized bytes.
Cc: stable@vger.kernel.org
Fixes: a748ee242681 ("net: move address list functions to a separate file")
Link: https://lists.openwall.net/linux-kernel/2026/09/10/320
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
---
net/core/dev_addr_lists.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c
index d827cc21867b..53a2dfa2706c 100644
--- a/net/core/dev_addr_lists.c
+++ b/net/core/dev_addr_lists.c
@@ -100,6 +100,11 @@ __hw_addr_create(const unsigned char *addr, int addr_len,
if (!ha)
return NULL;
memcpy(ha->addr, addr, addr_len);
+ /* Entries are dumped with the current dev->addr_len, which can grow
+ * after creation (e.g. tun TUNSETLINK), so never leave the tail
+ * uninitialized.
+ */
+ memset(ha->addr + addr_len, 0, MAX_ADDR_LEN - addr_len);
ha->type = addr_type;
ha->refcount = 1;
ha->global_use = global;
--
2.43.7
next reply other threads:[~2026-11-16 2:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 2:40 Henry Martin [this message]
2026-11-16 2:43 ` [PATCH] net: fix uninitialized heap leak in multicast address dumps netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116024056.1274402-1-bsdhenrymartin@gmail.com \
--to=bsdhenrymartin@gmail.com \
--cc=aleksandr.loktionov@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=sdf.kernel@gmail.com \
--cc=sigefriedhyy@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox