From: Nathan Chancellor <nathan@kernel.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH net] qca_spi: Avoid unsequenced accesses to jiffies in qcaspi_netdev_tx_timeout()
Date: Sun, 15 Nov 2026 20:44:21 -0700 [thread overview]
Message-ID: <20261116034421.GA47691@ax162> (raw)
In-Reply-To: <490e6ccf-0cc0-4db6-b076-5d4ac5f5b8a4@gmx.net>
On Sun, Nov 15, 2026 at 03:08:23PM +0100, Stefan Wahren wrote:
> In general agree, but imo the jiffies itself were not helpful to debug a
> transmit timeout in the first place, so I hope we can avoid adding a local
> variable here.
>
> How about this:
>
> netdev_info(qca->net_dev, "Transmit timeout, latency %ld\n",
> jiffies - dev_trans_start(dev));
>
> The timestamp from netdev_info() is much more helpful.
Sure, that is totally fine with me. I will send a v2 with that shortly.
--
Cheers,
Nathan
prev parent reply other threads:[~2026-11-16 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 4:39 [PATCH net] qca_spi: Avoid unsequenced accesses to jiffies in qcaspi_netdev_tx_timeout() Nathan Chancellor
2026-11-15 14:08 ` Stefan Wahren
2026-11-16 3:44 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116034421.GA47691@ax162 \
--to=nathan@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox