From: Ralf Lici <ralf@mandelbit.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, dsahern@kernel.org, idosch@nvidia.com,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, ncardwell@google.com,
kuniyu@google.com, steffen.klassert@secunet.com,
herbert@gondor.apana.org.au, fw@strlen.de, sd@queasysnail.net
Subject: Re: [PATCH net-next v2 1/3] ipv6: stamp the default route node with a fresh serial on link failure
Date: Mon, 16 Nov 2026 09:49:10 +0100 [thread overview]
Message-ID: <20261116084912.78030-1-ralf@mandelbit.com> (raw)
In-Reply-To: <179473299065.2199510.876988869343037585@kernel.org>
On Sun, 15 Nov 2026 08:56:30 +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
>
> Low priority / nit picks for your consideration:
>
> - [Low] The commit "ipv6: stamp the default route node with a fresh
> serial on link failure" fixes a real, long-standing bug but carries no…
> - [Low] The commit message's account of nexthop objects is misleading.
>
> --
>
> ipv6: stamp the default route node with a fresh serial on link failure
>
> For an RTF_DEFAULT route, this patch makes ip6_link_failure() allocate a
> fresh serial with fib6_update_sernum() under tb6_lock. Before, it wrote
> -1 into the node's fn_sernum. With the change, repeated link failures
> invalidate cached dsts, and the change becomes visible through the
> netns-wide generation.
>
> > ipv6: stamp the default route node with a fresh serial on link failure
> >
> > [ ... ]
> >
> > The write is also a no-op when the node already holds -1, so dsts cached
> > after one link failure survive the next one. dsts of nexthop objects are
> > validated against the generation and ignore fn_sernum, so a link failure
> > never invalidated them.
> >
> > Allocate a fresh serial under tb6_lock instead, as for any other FIB
> > change. A link failure now invalidates the nexthop-object dsts of the
> > namespace too, as a route insertion does.
Agreed, I'll correct that wording when revising the patch. The intent is
to make this path follow the usual fresh-serial allocation pattern,
which also makes the invalidation visible to the generation checks in
patch 2/3.
>
> [Severity: Low]
> Is this account of nexthop objects accurate? The second paragraph lists
> "a link failure never invalidated them" as a defect. The third paragraph
> then presents invalidating them as part of the fix.
>
> Can a route that uses a nexthop object ever reach the RTF_DEFAULT branch
> of ip6_link_failure()? RTF_DEFAULT seems to be set in only three places:
> rt6_add_route_info() for a zero prefixlen, rt6_add_dflt_router(), and the
> legacy SIOCADDRT ioctl path. None of them attach a nexthop object.
>
> The netlink path is the only one that sets fc_nh_id. It starts from:
>
> net/ipv6/route.c:rtm_to_fib6_config() {
> ...
> .fc_flags = RTF_UP,
> ...
> }
>
> and never adds RTF_DEFAULT.
>
> In practice, every default router link failure now goes through
> fib6_update_sernum()->fib6_new_sernum(), which advances
> net->ipv6.fib6_sernum. After that, rt6_is_valid() fails for every
> unrelated nexthop-object dst in the namespace:
>
> return rt6->sernum == rt_genid_ipv6(dev_net(rt6->dst.dev));
>
> The global bump looks fine in itself, and the follow-up "ipv6: add
> ip6_dst_lookup_flow_cookie" depends on the generation moving.
>
> Could the changelog call the nexthop-object invalidation a harmless side
> effect, rather than a deficiency being fixed?
>
> > diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> > index 04098cf32eabe..89fddc9df55ce 100644
> > --- a/net/ipv6/route.c
> > +++ b/net/ipv6/route.c
> > @@ -2867,13 +2867,13 @@ static void ip6_link_failure(struct sk_buff *skb)
> > rt6_remove_exception_rt(rt);
> > } else {
> > struct fib6_info *from;
> > - struct fib6_node *fn;
> >
> > from = rcu_dereference(rt->from);
> > - if (from) {
> > - fn = rcu_dereference(from->fib6_node);
> > - if (fn && (rt->rt6i_flags & RTF_DEFAULT))
> > - WRITE_ONCE(fn->fn_sernum, -1);
> > + if (from && from->fib6_table &&
> > + (rt->rt6i_flags & RTF_DEFAULT)) {
> > + spin_lock_bh(&from->fib6_table->tb6_lock);
> > + fib6_update_sernum(rt6_exception_net(rt), from);
> > + spin_unlock_bh(&from->fib6_table->tb6_lock);
>
> [Severity: Low]
> This fixes a long-standing bug in ip6_link_failure(). Should the commit
> carry a Fixes: tag, and possibly Cc: stable and a target tree?
>
> With the old code, the first link failure writes -1. A socket that
> re-validates its dst then caches it again with cookie 0xffffffff, taken
> from:
>
> rt6_get_cookie()
> fib6_get_cookie_safe()
> READ_ONCE(fn->fn_sernum)
>
> The next link failure writes -1 again, so this check in rt6_check() does
> not fire:
>
> if (!from || !fib6_get_cookie_safe(from, &rt_cookie) ||
> rt_cookie != cookie)
> return NULL;
>
> The socket then keeps using the failed default router until some
> unrelated FIB change restamps the node.
>
> git blame on the removed line points at aafc2e3285c2d7, the WRITE_ONCE()
> conversion. The surrounding block was shaped by a68886a691804d and
> c5cff8561d2d00, but the -1 sentinel itself appears to be older than all
> three.
>
> Without a reference to the commit that introduced the -1 write, how would
> stable maintainers know which trees need this?
>
The -1 assignment is already present in the initial git import, so a
Fixes tag would have to point to 1da177e4c3f4 rather than the actual
introducing change.
I deliberately targeted net-next because this is also a prerequisite for
the lookup-cookie API introduced by the series. Before pursuing broader
conversions or backports, I would appreciate maintainer feedback on that
approach. I can clarify the historical origin in the changelog when
revising the patch.
--
Ralf Lici
Mandelbit Srl
next prev parent reply other threads:[~2026-11-16 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 8:22 [PATCH net-next v2 0/3] ipv6: tie the dst cookie to the lookup that returned the dst Ralf Lici
2026-11-11 8:22 ` [PATCH net-next v2 1/3] ipv6: stamp the default route node with a fresh serial on link failure Ralf Lici
2026-11-15 8:56 ` netdev-bot+sashiko
2026-11-16 8:49 ` Ralf Lici [this message]
2026-11-11 8:22 ` [PATCH net-next v2 2/3] ipv6: add ip6_dst_lookup_flow_cookie Ralf Lici
2026-11-15 8:56 ` netdev-bot+sashiko
2026-11-11 8:22 ` [PATCH net-next v2 3/3] ipv6: use the lookup cookie when caching the dst in sockets Ralf Lici
2026-11-15 8:56 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116084912.78030-1-ralf@mandelbit.com \
--to=ralf@mandelbit.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox