Netdev List
 help / color / mirror / Atom feed
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: netdev@vger.kernel.org
Cc: magnus.karlsson@intel.com, stfomichev@gmail.com, kuba@kernel.org,
	pabeni@redhat.com, tushar.vyavahare@intel.com,
	kerneljasonxing@gmail.com, bjorn@kernel.org,
	maxime.chevallier@bootlin.com,
	Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Subject: [PATCH net-next] selftests: xsk: drop asm/barrier.h to fix the riscv build
Date: Mon, 16 Nov 2026 11:51:59 +0100	[thread overview]
Message-ID: <20261116105159.1050557-1-maciej.fijalkowski@intel.com> (raw)

xsk.c includes <asm/barrier.h>, a leftover from libbpf's AF_XDP code;
nothing in it uses a barrier, the ring helpers in xsk.h use C11
atomics. On riscv, the tools asm/barrier.h includes <asm/fence.h> from
tools/arch/riscv/include. selftests/bpf had that directory on the
include path but selftests/net does not, so since the move both
xskxceiver and xdp_hw_metadata fail to build on riscv:

  asm/barrier.h:13:10: fatal error: asm/fence.h: No such file or directory

Drop the redundant include.

Fixes: e8f9d8237988 ("selftests: xsk: move the AF_XDP test suite to selftests/net")
Fixes: d01fb5c81130 ("selftests: net: move xdp_hw_metadata from selftests/bpf")
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
 tools/testing/selftests/net/lib/xsk/xsk.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/net/lib/xsk/xsk.c b/tools/testing/selftests/net/lib/xsk/xsk.c
index 6bd32caf5d08..4e9d14f883ac 100644
--- a/tools/testing/selftests/net/lib/xsk/xsk.c
+++ b/tools/testing/selftests/net/lib/xsk/xsk.c
@@ -13,7 +13,6 @@
 #include <string.h>
 #include <unistd.h>
 #include <arpa/inet.h>
-#include <asm/barrier.h>
 #include <linux/compiler.h>
 #include <linux/ethtool.h>
 #include <linux/filter.h>

base-commit: 6964ff21c5d8b75649211a52dbfd92753e605649
-- 
2.43.0


             reply	other threads:[~2026-11-16 10:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:51 Maciej Fijalkowski [this message]
2026-11-16 11:45 ` [PATCH net-next] selftests: xsk: drop asm/barrier.h to fix the riscv build Jason Xing
2026-11-16 18:06 ` Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116105159.1050557-1-maciej.fijalkowski@intel.com \
    --to=maciej.fijalkowski@intel.com \
    --cc=bjorn@kernel.org \
    --cc=kerneljasonxing@gmail.com \
    --cc=kuba@kernel.org \
    --cc=magnus.karlsson@intel.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stfomichev@gmail.com \
    --cc=tushar.vyavahare@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox