From: Stephen Hemminger <stephen@networkplumber.org>
To: ojab <ojab@ojab.ru>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] tc: fix build with flex>=2.6.5
Date: Mon, 16 Nov 2026 11:41:44 -0800 [thread overview]
Message-ID: <20261116114144.45ccac93@phoenix.local> (raw)
In-Reply-To: <20261112084107.517-1-ojab@ojab.ru>
On Thu, 12 Nov 2026 08:41:07 +0000
ojab <ojab@ojab.ru> wrote:
> Since flex-2.6.5 [1] `yyunput` takes a single argument and build fails
> with:
> ```
> emp_ematch.l:35:69: error: macro ‘yyunput’ passed 2 arguments, but takes just 1
> 35 | static void __attribute__ ((unused)) yyunput (int c,char *buf_ptr );
> | ^
> emp_ematch.lex.c:466:9: note: macro ‘yyunput’ defined here
> 466 | #define yyunput(c) yyunput_r( c, (yytext_ptr) )
> | ^~~~~~~
> emp_ematch.l:35:39: error: variable or field ‘yyunput’ declared void
> 35 | static void __attribute__ ((unused)) yyunput (int c,char *buf_ptr );
> | ^~~~~~~
> emp_ematch.lex.c:1836:13: warning: ‘yyunput_r’ defined but not used [-Wunused-function]
> 1836 | static void yyunput_r (int c, char * yy_bp )
> | ^~~~~~~~~
> make[1]: *** [../config.mk:34: emp_ematch.lex.o] Error 1
> ```
>
> Use new `YY_NO_YYUNPUT` to silence redefinition warning in this case
> and skip `__attribute__ ((unused))`.
>
> [1] https://github.com/westes/flex/commit/721622ea6e6aaf3aa7e55d939679f21e98b76d86
>
> Signed-off-by: ojab <ojab@ojab.ru>
> ---
There are couple of concerns with this patch.
First, Signed-off-by should be a "Known identity" not short alias because it is interpreted
as Developers Certificate of Origin. If you resend, please use something more than just "ojab".
Also, it looks like flex version 2.6.5 change was later reverted.
AI discovered:
flex 2.6.5 renamed yyunput() to yyunput_r(), but 2.6.12 reverted that
and restored the 2.6.4 behaviour (flex commit 160a160). Every version
in that window, 2.6.5 through 2.6.15, was tagged within the last week;
flex had been on 2.6.4 since 2017. So this works around a rename that
upstream has already backed out, in releases no distro ships.
Bottom line: don't use development versions of flex
NAK
prev parent reply other threads:[~2026-11-16 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:41 [PATCH] tc: fix build with flex>=2.6.5 ojab
2026-11-16 19:41 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116114144.45ccac93@phoenix.local \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=ojab@ojab.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox