From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794832841; b=Xz8m6L7bsT/X3NNhAKrrHSzfGITULF0xK2e5ZtuWmTUeVVVufcWOTib95jNa0VS2NIoQ 5ikgocurCR5KPXPUus2+1rd/J21USSOqC/szUdmQaU4pBsuExuYWt/uMGgcq3Qqhd4HvO Dy0JHcip3/fLMpbGN7d8iZuqu/71s0eK4eGEIFZbvJUPqvsrPMJGkYBp4P4y0Nb7fXHdo ONhgkBtWnrF+bt3KspUkvUTTuxcKiYIVa7rrY5XBfyJ2jc6aARmkFUy46Izf1CfAqVC6v ew+uJ6UHQhoc20B81kq1pumpkIESE8R6SNczmBI9EhPRzzXch/dpcoF1TlG1L0V39bw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794832841; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-Id:X-Mailer:MIME-Version:Content-Transfer-Encoding; bh=ofU1FQthecJu2OVRI80kc6txKndxQX32EBE9heySnKk=; b=hBUAIXC2vQh5TJ2l+sockCQ2AmkW7HXpzjVtq9NC+EvLbAnUstk+ZCgIMQIJ0wg411c6 vzfMHcKDCVH22GqsCey6eZaCc2yj+eqyDPZMkyx8vNPHX69ZZerdGtSqMAgAJlqqnUBeN ifMLNVRZUsNrl9Cs4hZ4Nt/vpKpIXZ5/SUNcwb1IvBK5vTSH1ZQXq6LJiwR8pFPHhiMeK ce4cmYZ0IR0aLnJEqy6SccDModcSN7cBmSdKeUhdAdiT2Oj1NAvUvmqi3hfAIXfSiJoZu hcrTQ4u6DTilmRAj+v8oeNU/Tq4v1u5/YIHrVB5lOx/tRk6XRjWb1xOYOwMHst9TIzA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=tZlH4qsy; arc=none smtp.remote-ip=209.85.210.45 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4731606A31C for ; Mon, 16 Nov 2026 12:40:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C4731606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=tZlH4qsy Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-862b3938d98so721114a34.3 for ; Mon, 16 Nov 2026 04:40:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794832840; x=1795437640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ofU1FQthecJu2OVRI80kc6txKndxQX32EBE9heySnKk=; b=tZlH4qsyeVyp85D/7jfuml2Bo9iSsV9/vvMVPvLbOjuqa9ZzlFCuWOOMPLFa4lcyhz +XgH3VuEcWu/sJbcLqS1Aebt7m3+vqAToTw8VySUA/AnsTzsqb7Uh27tE9K4RImxd4ri uHf2EdZKQlA70FqigwldTyC+ox1IImIoUe83gInR24PllyxytHuJ0D1zETZDRBvAH/Pe xTs6BNuHqVyh/utWQjtSdoZ3jVFi2KXCQFuu6SQiAE+jEwfSdjAZH5SZrHIUwPuDAqsW zne0aXtsjD1G7Eq0/thFuqndNXzCIOkCav79MIoClzJnr2b2a5MzAvMb51XiApQTxdj2 u8AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794832840; x=1795437640; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ofU1FQthecJu2OVRI80kc6txKndxQX32EBE9heySnKk=; b=iv9oY3bEG0a1PE1KzhgZqlD9Zgz8Z3fKj2qHaz982Q+CEM+70/ZTx2t0vmreY05FIu 6fccTaPI2M9ol/tbUPd7M8yYVQXCBnz4RNSUp+mekbTB8VbdE4V2O6Rp998GlrPtEv40 hV08b/8Xt1VD10VxqNMQ3aCzJu/WKyFQfyAeB0bkVHRE45qp8XCaVt375XKk41T8arVO eknwpxYcjJt2EVqxFwM+Y3Yj4hoeg5hlqO+EwNwxbEibu40TSBWdayYErSiUxI+zTnLo krLlrW5H1r7Qah9ltBecqF58E8Rh6F+gljkpqNtO5pizI0CE1kcHcSzDP3WafIdJqB1o DB8Q== X-Gm-Message-State: APuU4Z8PQGMTSYSS0qXSE2hXxcGSwPHg5zmE4RzpDbNRQXuwj5P/qJdj MTjriwWfSyoLCVW+BYh6PhR+cvpmob1sPllv6EAR0ZCnwjQ63fpzNEEO+nPyAQ== X-Gm-Gg: AYBFou321DhZ1hvWGAUW5ghKla00ythKA41Rweip0qfFWvMH7sBlX7AWR8JZUlkggp5 PiVRZR8Jxa3TWriaGBf1eN9TfUPPEIAI0y+QWoYriDnKKFm5wbQ2r0ZN+6qqMr2N8egxxYiUKTz ZO3c1zJZbDWtA6lCCqcbQdH0SontRtFudfxDdiKZozcSpsa6gugc9DZIp4P+Ic7aKykGcsK6adh 3m1Wuso0zRnm64oo9ECJF2uHZQUnpeq20BHR2M1/L3e66doAYo/ilQUg1mXaZKcPl8L2GV1Skzt 2JMpCCLlQvCONrSjvkIgwyO/i322VCWU+O6oidxa+IvxDZ0Wz9CQTgyQLUKEjt9r0ZblryG4Qvz 2y/fkd+hfpJAJOSqPj2Q1FdfLMZREk6XgDv9/gx4E3oE4svOsTrJyvJ73VSB9AZQn38pe4ViAt2 NKMYuWVeuqLz+xDuyAMrUyKve3tvHZwNhoNy/aF1RXdqKQQgOHL5+8WRkRIkDuSwJ2LdlCn9ORC 8o5ALZ2LkdPogvSevnp3IEkkpL4pD/QWy7UmY6Dlcuvka9k6eS13wKJB1lgXncGcbd3oc5SxxCx 7MlilSUYnX69f5J+JmCJdjB/IcwSXP6inXK2vrgSmwYtnw7vCLx1g/EsNmZ9R/FqZBxeKkfC/WX 27wt1FNX6OLxLBYWxPL7cKADNRDo7GYde2bzAGN2mOsIMa8vdOebcMlYcoofNpgRyitQv5RuObA == X-Received: by 2002:a05:6830:4113:b0:862:cae6:db3d with SMTP id 46e09a7af769-862cae6e439mr1975678a34.11.1794832839406; Mon, 16 Nov 2026 04:40:39 -0800 (PST) Received: from ramen-dev-security-2.asia-south1-c.c.ramen-dev-345017.internal (90.156.200.35.bc.googleusercontent.com. [35.200.156.90]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-862c4dd9abesm2830937a34.20.2026.11.16.04.40.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 04:40:38 -0800 (PST) From: Anil Kaushik To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, idosch@nvidia.com, nicolas.dichtel@6wind.com, jacob.e.keller@intel.com, jiri@resnulli.us, fw@strlen.de, martineau@kernel.org, v3rdant.xiang@gmail.com, aliceryhl@google.com, linux-kernel@vger.kernel.org, nhorman@tuxdriver.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, anilkaushikwireless@gmail.com Subject: [PATCH net v7 0/2] genetlink: Reject joining multicast groups no family owns Date: Mon, 16 Nov 2026 12:40:28 +0000 Message-Id: <20261116124030.1595567-1-anilkaushikwireless@gmail.com> X-Mailer: git-send-email 2.25.1 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit genl_bind() lets any user join a multicast group ID that no family owns. A family registered later can get that ID, and the socket stays a member without a capability check. Patch 1 makes genl_bind() return -ENOENT for such an ID. Patch 2 adds a selftest for it. v7: - Add a selftest as patch 2, as Nicolas asked. - Say in the comments on the static IDs, and on NET_DM_GRP_ALERT, that they can be joined only after the family is registered (Sashiko). - Say in the commit message that the unregister window was already there for the capability check. v6: https://lore.kernel.org/netdev/20261112094205.1120090-1-anilkaushikwireless@gmail.com/ I used an LLM to help write and review the code, the tests and the commit messages of this series. I checked and tested every change myself. Anil Kaushik (2): genetlink: Reject joining multicast groups no family owns selftests: net: test joining genetlink groups no family owns include/linux/netlink.h | 3 + include/uapi/linux/net_dropmon.h | 2 + net/netlink/af_netlink.c | 6 + net/netlink/genetlink.c | 5 +- tools/testing/selftests/net/Makefile | 1 + tools/testing/selftests/net/nl_genl_mcast.py | 109 +++++++++++++++++++ 6 files changed, 125 insertions(+), 1 deletion(-) create mode 100755 tools/testing/selftests/net/nl_genl_mcast.py base-commit: 070411c1590c8172eb4d86f045d99c372f22fe23 -- 2.25.1