Netdev List
 help / color / mirror / Atom feed
From: Leonard Lausen <leonard@lausen.nl>
To: netdev@vger.kernel.org
Cc: leonard@lausen.nl, David Ahern <dsahern@kernel.org>,
	Ido Schimmel <idosch@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Florian Westphal <fw@strlen.de>, Phil Sutter <phil@nwl.cc>,
	Shuah Khan <shuah@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net v4 2/2] selftests: netfilter: cover IPv6 FIB prefix suppression
Date: Tue, 17 Nov 2026 11:08:12 +0000	[thread overview]
Message-ID: <20261117110813.9894-4-leonard@lausen.nl> (raw)
In-Reply-To: <20261117110813.9894-2-leonard@lausen.nl>

Extend nft_fib.sh using its existing namespaces and counter helper to
check that suppress_prefixlength 0 suppresses a default route while
retaining a more-specific route. Check that blackhole, unreachable and
prohibit routes remain terminal despite a usable route in a later table.
Include a blackhole nexthop object to distinguish result reject flags
from flags on the FIB entry.

Require a positive counter for the expected nftables FIB result. Compare
it with the output device or rejection error from an ordinary lookup.

Label ruleset-load failures and skip the affected checks when IPv6 prefix
suppression or nexthop objects are unavailable.

Run these checks after the existing default-table tests so that adding
policy rules does not remove coverage of the path without custom IPv6
rules. The router's logging RPF rules have already been removed by then,
allowing neighbour discovery during intentionally different reverse-route
states.

Signed-off-by: Leonard Lausen <leonard@lausen.nl>
---
v4:
- Drop the cached-default PMTU case and its fixture setup.
- Retain the six prefix-suppression and terminal-reject checks from v3.

Verified on the rebuilt v4 laptop kernel (7.4.0-rc2+ #6): all six added
checks pass in full normal and eight-second-delayed nft_fib.sh runs.
Both runs exit 0; twelve separate reject-route controls also pass.

V3 review:
https://lore.kernel.org/netdev/20261117091340.GA581197@shredder/T/#t

 .../selftests/net/netfilter/nft_fib.sh        | 90 +++++++++++++++++++
 1 file changed, 90 insertions(+)

diff --git a/tools/testing/selftests/net/netfilter/nft_fib.sh b/tools/testing/selftests/net/netfilter/nft_fib.sh
index 04544905c216..25e13197f057 100755
--- a/tools/testing/selftests/net/netfilter/nft_fib.sh
+++ b/tools/testing/selftests/net/netfilter/nft_fib.sh
@@ -202,6 +202,50 @@ check_fib_counter() {
 	return 0
 }
 
+# Count probes matching the expected FIB result, then drop them.
+test_fib_suppress() {
+	local label="$1" expected="$2"
+	local result="${3:-oifname}" error err=0
+
+	if ! ip netns exec "$nsrouter" nft -f /dev/stdin <<EOF
+flush table ip6 filter
+table ip6 filter {
+	chain prerouting {
+		type filter hook prerouting priority -1;
+		ip6 saddr dead:1::99 icmpv6 type echo-request \
+			fib saddr . mark $result "$expected" counter drop
+	}
+}
+EOF
+	then
+		echo "FAIL: $label (could not load ruleset)"
+		return 1
+	fi
+	ip netns exec "$ns1" ping -6 -c 1 -W 0.1 -q dead:1::1 > /dev/null 2>&1
+	if [ "$result" = type ]; then
+		case "$expected" in
+		blackhole) error="Invalid argument" ;;
+		unreachable) error="No route to host" ;;
+		prohibit) error="Permission denied" ;;
+		esac
+		LC_ALL=C ip -net "$nsrouter" -6 route get dead:1::99 \
+			from dead:1::1 2>&1 |
+			grep -Fxq "RTNETLINK answers: $error" || err=1
+	else
+		ip -net "$nsrouter" -6 route get dead:1::99 from dead:1::1 |
+			grep -q "dev $expected " || err=1
+	fi
+	if check_fib_type_counter_family ip6 1 "$nsrouter" prerouting \
+		"$result" "$label" &&
+	   [ "$err" -eq 0 ]; then
+		echo "PASS: $label"
+	else
+		echo "FAIL: $label"
+		ret=1
+		return 1
+	fi
+}
+
 load_ruleset "$nsrouter"
 load_ruleset "$ns1"
 load_ruleset "$ns2"
@@ -845,6 +889,52 @@ test_fib_type "default table"
 ip netns exec "$nsrouter" nft delete table ip filter
 ip netns exec "$nsrouter" nft delete table ip6 filter
 
+# Keep the earlier IPv6 checks on the path without custom rules.
+# The router's logging RPF rules have already been removed here.
+if ip -net "$nsrouter" -6 rule add pref 100 to dead:1::99 table 128 \
+	suppress_prefixlength 0; then
+	ip -net "$nsrouter" -6 route add table 128 default dev veth1 || exit 1
+	ip -net "$nsrouter" -6 route add table 129 dead:1::/64 \
+		dev veth0 || exit 1
+	ip -net "$nsrouter" -6 rule add pref 101 to dead:1::99 \
+		table 129 || exit 1
+	ip netns exec "$nsrouter" nft add table ip6 filter || exit 1
+
+	test_fib_suppress "suppress default route" veth0 || ret=1
+	ip -net "$nsrouter" -6 route add table 128 dead:1::/64 \
+		dev veth1 || exit 1
+	test_fib_suppress "retain non-default route" veth1 || ret=1
+	ip -net "$nsrouter" -6 route del table 128 dead:1::/64 \
+		dev veth1 || exit 1
+
+	for type in blackhole unreachable prohibit; do
+		ip -net "$nsrouter" -6 route replace "$type" default \
+			table 128 || exit 1
+		test_fib_suppress "retain $type" "$type" type || ret=1
+	done
+
+	if ip -net "$nsrouter" -6 nexthop add id 1 blackhole; then
+		ip -net "$nsrouter" -6 route replace default nhid 1 \
+			table 128 || exit 1
+		test_fib_suppress "retain blackhole nexthop" \
+			blackhole type || ret=1
+		ip -net "$nsrouter" -6 route del table 128 default
+		ip -net "$nsrouter" -6 nexthop del id 1
+	else
+		echo "SKIP: blackhole nexthop objects unavailable"
+		[ "$ret" -eq 0 ] && ret=$ksft_skip
+		ip -net "$nsrouter" -6 route del table 128 default
+	fi
+
+	ip -net "$nsrouter" -6 rule del pref 100
+	ip -net "$nsrouter" -6 rule del pref 101
+	ip -net "$nsrouter" -6 route flush table 129
+	ip netns exec "$nsrouter" nft delete table ip6 filter
+else
+	echo "SKIP: IPv6 prefix suppression unavailable"
+	[ "$ret" -eq 0 ] && ret=$ksft_skip
+fi
+
 test_fib_vrf
 
 exit $ret
-- 
2.55.0


  parent reply	other threads:[~2026-11-17 11:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:08 [PATCH net v4 0/2] ipv6: Honor suppress_prefixlength in fib6_lookup() Leonard Lausen
2026-11-17 11:08 ` [PATCH net v4 1/2] " Leonard Lausen
2026-11-17 11:08 ` Leonard Lausen [this message]
2026-11-17 12:56 ` [PATCH net v4 0/2] " Pablo Neira Ayuso
2026-11-17 13:01   ` Leonard Lausen
2026-11-17 13:07     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117110813.9894-4-leonard@lausen.nl \
    --to=leonard@lausen.nl \
    --cc=coreteam@netfilter.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox