From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.82 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794924450; b=MddHxkYl2beoSMlCJXIYO4UF5aQFbH7Q7PEA2flz4txZRvI9gxc4imG55YFjtc7PvVLh ce47Cks2ZcO7ANJYPUZddJw6D3TiFxWYaKyWACQwCDL8bP9GMf9fHHAiHV9nCvDDCTWdI aD4GwPZi9OAVkO9ACqfdiA5qqlm68Mf0nTkC+6tLWaFWRbjxDmVQqsYIepXb+qpKC0yB5 V4a3fTt7H+d+26DoYYJL+stQU86TlkS9viLMI0sK82W5JJx+AUnrP4I7UiSNlpDduEJeE AA9Gr55zq3AuorVwClgFE51oBKQQI3hM2laNMEeNEt+i4FviUb9vPU/5lFXws5xcj+A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794924450; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=iJaEvWg9OTe150EoeiisC+aMq2Yvr+r+9zDhXa6Y07Y=; b=kwX2mUlj5rQRNtYJSYQpBSIVdzFRihEECcLv94Bo5Jjm5RBRte7f+W7FDYRfKeU/g+re guBCOfciroreJuv/p0Gszx/cxRgmsfFrpvi9auIj1HU922XxlpOdcMLEtGq2rbJnZ8t3E Y5taLsp7mJ8tp+OOj6hzN7QyVFBBJgl6CF2+p7LiIgy+5QAL4xMRc7guhbP+S9/19H8j8 CX8ihwIPWqJ7AUSwwxdNyqg+irnrPns+ml4hmxiOeb2rqwuSF8j+Ihx+cRM0s6GYjM6Be /p77LRhL+CHUhjwcafyQ/OPUE7wDLLMOoY1PNZs51sWx7OZelgCQfDVe1sLfAtYvqDQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=MYANFeEf; arc=none smtp.remote-ip=95.215.58.82 Received: from mta1.migadu.com (out-82.mta1.migadu.com [95.215.58.82]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F125606A323 for ; Tue, 17 Nov 2026 14:07:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5F125606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=MYANFeEf X-Envelope-To: netdev@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=RtbqUEc0su7Puf8hCD/i/LQztiNRX0a2j2imIdT0dUc=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794924447; v=1; x=1795529247; b=MYANFeEfvWOZoglkBKsSFhUP/qr3jEAqkGvFlCHnXTexwF6gOlXA/dMwGRvHYZk10D9UUrqd S+peDi8RmHwpOYQ7LCgFRPunBFf+FqetwgRMQ+EAZMIj+wXWbw+UtUk/pzemVyzt3inKTDoxMC8 B4eYnX7A+B1Fvpe9UhekrPjs= X-Envelope-To: netdev@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 237cc9b92867efc5; Tue, 17 Nov 2026 14:07:27 +0000 X-Mizu-Trace-ID: 237cc9b92867efc5 X-Migadu-Flow: FLOW_OUT From: Jiayuan Chen To: netdev@vger.kernel.org, kuba@kernel.org Cc: Jiayuan Chen , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , John Fastabend , Sabrina Dubroca , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH net-next v2 2/2] selftests: drv-net: run tls_hw_offload on netdevsim Date: Tue, 17 Nov 2026 22:06:31 +0800 Message-ID: <20261117140642.4008-3-jiayuan.chen@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261117140642.4008-1-jiayuan.chen@linux.dev> References: <20261117140642.4008-1-jiayuan.chen@linux.dev> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Now that netdevsim offers kTLS device offload, let the test run on it too: drop nsim_test=False so the default netdevsim pair is used when no NETIF is set. Everything the test checks on the DUT, device MIB counters, echo data and record types, works there as is. The only thing netdevsim can't give is ethtool -S: nsim_ethtool_ops in drivers/net/netdevsim/ethtool.c has no get_sset_count or get_strings, so the command fails and every case died taking the NIC counter snapshot. That is a gap in netdevsim itself, not in the TLS emulation, and the NIC counters are optional in this test anyway, so skip the snapshot on netdevsim instead of adding ethtool stats to the driver. # ./tls_hw_offload.py # Interface: eth1, driver: netdevsim TAP version 13 1..8 ok 1 tls_hw_offload.test_tls_offload.tls12_aes128 ok 2 tls_hw_offload.test_tls_offload.tls12_aes256 ok 3 tls_hw_offload.test_tls_offload.tls12_aes128_ip6 ok 4 tls_hw_offload.test_tls_offload_sizes.small_buf ok 5 tls_hw_offload.test_tls_offload_sizes.large_buf ok 6 tls_hw_offload.test_tls_offload_sizes.random_buf ok 7 tls_hw_offload.test_tls_offload_record_type.handshake ok 8 tls_hw_offload.test_tls_offload_record_type.alert # Totals: pass:8 fail:0 xfail:0 xpass:0 skip:0 error:0 Signed-off-by: Jiayuan Chen --- tools/testing/selftests/drivers/net/hw/tls_hw_offload.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/drivers/net/hw/tls_hw_offload.py b/tools/testing/selftests/drivers/net/hw/tls_hw_offload.py index e720ce6547610..1197f17caa13c 100755 --- a/tools/testing/selftests/drivers/net/hw/tls_hw_offload.py +++ b/tools/testing/selftests/drivers/net/hw/tls_hw_offload.py @@ -125,6 +125,9 @@ def read_nic_stats(cfg): # before/after-delta caveat as read_tls_stats(): these are device-wide, # so concurrent kTLS traffic on this NIC would perturb the deltas. stats = defaultdict(int) + # netdevsim has no ethtool -S, and the NIC counters below are optional + if cfg.get_local_nsim_dev(): + return stats output = cmd(f"ethtool -S {cfg.ifname}").stdout for line in output.strip().split('\n'): key, sep, val = line.partition(':') @@ -307,7 +310,7 @@ def test_tls_offload_record_type(cfg, record_type): def main() -> None: """Set up the DUT/peer environment and run the offload test suites.""" - with NetDrvEpEnv(__file__, nsim_test=False) as cfg: + with NetDrvEpEnv(__file__) as cfg: cfg.bin_local = cfg.test_dir / "tls_hw_offload" cfg.bin_remote = None cfg.tls_skip_reason = None -- 2.43.0