From: Joe Damato <joe@dama.to>
To: netdev@vger.kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
linux-kernel@vger.kernel.org, daniel.machon@microchip.com,
Joe Damato <joe@dama.to>
Subject: [PATCH net-next v2 0/5] net/mlx4: TX helpers and deferred doorbell fix
Date: Tue, 17 Nov 2026 07:53:45 -0800 [thread overview]
Message-ID: <20261117155353.2250540-1-joe@dama.to> (raw)
Greetings:
I am working on adding support for SW USO to mlx4 and the branch I have with
those changes locally is becoming a bit long, so I thought I'd try to break it
up to make it easier to review and merge by first sending this prep series.
FWIW: I plan to include more detailed data in my SW USO series, but I'm
working on SW USO because it significantly improves performance on hosts with
an IOMMU and an mlx4 NIC. I have a lot of hosts like that in production that
would benefit.
Anyway, back to this series.
Patches 1-3 factor common code out into helpers which currently have only 1
call site each, but I will be calling these helpers in the SW USO code I plan
to submit next.
Patch 4 and 5 add code to track when a doorbell is deferred so that it can
be written in the drop path. This is technically a bug fix (and I need this
to avoid the same type of bug in SW USO), but since I have never seen this bug
occur in reality I am sending to net-next.
Thanks,
Joe
v2:
- Better cover letter subject line :)
- Added Daniel's Reviewed-by to all patches, including patch 4 which has a
minor change (hope that is OK, Daniel).
- Patch 4:
- Change the struct placement to address Sashiko's review. The new flag
is moved to the area of the struct marked as "cache line used and
dirtied in mlx4_en_xmit" and tx_dropped is moved down with the fields
not used in the fast path since it is only written on drop and read
for stats.
- Update the commit message to explain this.
v1: https://lore.kernel.org/netdev/20261110231304.1859217-1-joe@dama.to/
Joe Damato (5):
net/mlx4: factor VLAN parsing into mlx4_en_prep_vlan()
net/mlx4: factor csum flags into mlx4_en_csum_flags()
net/mlx4: factor HW loopback DMAC into mlx4_en_set_loopback_dmac()
net/mlx4: track whether a TX doorbell is pending
net/mlx4: flush pending doorbell when dropping a TX skb
drivers/net/ethernet/mellanox/mlx4/en_tx.c | 95 +++++++++++++-------
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +-
2 files changed, 66 insertions(+), 32 deletions(-)
base-commit: 6bc9aed3994cb04708fef02dd6d2f1cc5c5e8229
--
2.53.1-Meta
next reply other threads:[~2026-11-17 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 15:53 Joe Damato [this message]
2026-11-17 15:53 ` [PATCH net-next v2 1/5] net/mlx4: factor VLAN parsing into mlx4_en_prep_vlan() Joe Damato
2026-11-17 15:53 ` [PATCH net-next v2 2/5] net/mlx4: factor csum flags into mlx4_en_csum_flags() Joe Damato
2026-11-17 15:53 ` [PATCH net-next v2 3/5] net/mlx4: factor HW loopback DMAC into mlx4_en_set_loopback_dmac() Joe Damato
2026-11-17 15:53 ` [PATCH net-next v2 4/5] net/mlx4: track whether a TX doorbell is pending Joe Damato
2026-11-17 15:53 ` [PATCH net-next v2 5/5] net/mlx4: flush pending doorbell when dropping a TX skb Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117155353.2250540-1-joe@dama.to \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox