Netdev List
 help / color / mirror / Atom feed
From: Tim Douglas <me@timdoug.com>
To: netdev@vger.kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
	kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH net] net: lib8390: avoid truncating the expected receive page
Date: Tue, 17 Nov 2026 21:22:17 -0500	[thread overview]
Message-ID: <20261118022217.84500-1-me@timdoug.com> (raw)

For a receive ring ending at page 0xff, the expected next page can
exceed 0xff before the ring size is subtracted. The value is
truncated when stored in an unsigned char, so a valid frame that
wraps around the ring can be rejected and queued frames dropped.
Store the intermediate value in an int.

This was observed with the 64 KiB receive ring enabled on a
Farallon EtherMac LC-TP. With the fix, three 16 MiB downloads on a
Performa 6200CD using a kernel with local platform support completed
without receive errors. The pcnet_cs driver also uses a receive ring
ending at page 0xff for Socket EA cards with the large buffer enabled.

AI assistance was used to investigate the receive errors and draft
the fix.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Tim Douglas <me@timdoug.com>
---
 drivers/net/ethernet/8390/lib8390.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/8390/lib8390.c b/drivers/net/ethernet/8390/lib8390.c
index 84aeb8054..93c514602 100644
--- a/drivers/net/ethernet/8390/lib8390.c
+++ b/drivers/net/ethernet/8390/lib8390.c
@@ -660,7 +660,8 @@ static void ei_receive(struct net_device *dev)
 {
 	unsigned long e8390_base = dev->base_addr;
 	struct ei_device *ei_local = netdev_priv(dev);
-	unsigned char rxing_page, this_frame, next_frame;
+	unsigned char rxing_page, this_frame;
+	int next_frame;
 	unsigned short current_offset;
 	int rx_pkt_count = 0;
 	struct e8390_pkt_hdr rx_frame;

base-commit: 76115f0ab948a6aeb66a0b9bd4e074ed52cd6946
-- 
2.39.5


                 reply	other threads:[~2026-11-18  2:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118022217.84500-1-me@timdoug.com \
    --to=me@timdoug.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox