From: Zhao Li <enderaoelyther@gmail.com>
To: Joshua Washington <joshwash@google.com>,
Harshitha Ramamurthy <hramamurthy@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Willem de Bruijn <willemb@google.com>,
Jordan Rhee <jordanrhee@google.com>,
Ankit Garg <nktgrg@google.com>, Ziwei Xiao <ziweixiao@google.com>,
Jeroen de Borst <jeroendb@google.com>,
Praveen Kaligineedi <pkaligineedi@google.com>,
Tim Hostetler <thostet@google.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Matt Olson <maolson@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net] gve: clear flow rule cache state when freeing its buffers
Date: Wed, 18 Nov 2026 10:34:29 +0800 [thread overview]
Message-ID: <20261118023429.29330-1-enderaoelyther@gmail.com> (raw)
Freeing the flow-rule cache clears its pointers but retains the cached
counts and synchronization flag. A successful rule-reset command
invalidates the cache, but a failed reset does not. Recovery can then
allocate zeroed buffers while retaining a nonzero count and synced flag,
causing a later flow-rule query to return zeroed rules as if they were a
synchronized cache.
Clear the complete cache state after freeing its buffers so reallocation
always starts unsynchronized with zero cached entries.
Found by code review. Compile-tested with W=1.
AI assistance was used.
Fixes: 57718b60df9b ("gve: Add flow steering adminq commands")
Cc: stable@vger.kernel.org
Signed-off-by: Zhao Li <enderaoelyther@gmail.com>
---
No new W=1, sparse or smatch warnings.
drivers/net/ethernet/google/gve/gve_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
index 35cf0f06a0f2..747f5229d7ef 100644
--- a/drivers/net/ethernet/google/gve/gve_main.c
+++ b/drivers/net/ethernet/google/gve/gve_main.c
@@ -189,9 +189,8 @@ static void gve_free_flow_rule_caches(struct gve_priv *priv)
struct gve_flow_rules_cache *flow_rules_cache = &priv->flow_rules_cache;
kvfree(flow_rules_cache->rule_ids_cache);
- flow_rules_cache->rule_ids_cache = NULL;
kvfree(flow_rules_cache->rules_cache);
- flow_rules_cache->rules_cache = NULL;
+ memset(flow_rules_cache, 0, sizeof(*flow_rules_cache));
}
static int gve_alloc_rss_config_cache(struct gve_priv *priv)
base-commit: a2239d5dbbda3a61b6323df8836f605921a29f7f
--
2.56.1
reply other threads:[~2026-11-18 2:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118023429.29330-1-enderaoelyther@gmail.com \
--to=enderaoelyther@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=jordanrhee@google.com \
--cc=joshwash@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maolson@google.com \
--cc=netdev@vger.kernel.org \
--cc=nktgrg@google.com \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=thostet@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox