From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.68 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794977534; b=NVGVydqgMbBYV6clfY99PCY4boXwRjrY8lSLlbKI2r2geOkyFyf9zOZo1d/cTk1S5Q7C mlmP1U6awuAiCa5V/bj0+0IAoIk+xQZgQMLr22UMBqh7dNMPAdYlAvfU2pDHH1Rkz3eUc dG+k+5MVkXgw6eivEM1ooqcHlWE0IBXRBfDdETevI6OInU5T3xwPfhWK5ozufTQPHPUHM e31p0RXsxTgmPcSQymwz8juVI1XJv2nnvcqkWtnjBfpAeqtFRHDD7XwT/l0QXml71OoLr awIwewbRTGyA0F/ywANdXfb/q7f1p/p2hk9PLg8+UEfeU2965XkwU3NTGAKy7FoOfWA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794977534; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=D4Glb/phafOO2J4NO7289AZtRKHSGknHG2wh1OwjCi4=; b=y09Nk/TNAVtYD47KFnCxXXNCDYW/VEZgGlUTwdBocJjw/JVqd0WQzN4fO26SNDyWKRat 3aj5jfZYkW5RYCnQvitQZBta7Xec9blNjShf0hpx32FOfEgUnLeYT1h7kQaPzFyr2N3gJ 3jjqG9DMvNtr9gsLtJQWUDsxjybSbS/hsUg/6Dyuhbqa4bnEyCnx7JOiL/QSEonZS7zVR KQ3oJLn5pPoUDOGE1sXcjfBO9VUmcxxHM9ARmzLjc0DVW9oVH/fKjGUmlCw4Q95L3J4Y7 A3WqRWAQLChZXpC4mIjNE2PDkGWy+UoZtptLlqsl2UaxRvZZfmB0UDOGkCI9tXCGWtQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=qHk+1IWp; arc=none smtp.remote-ip=91.218.175.68 Received: from mta0.migadu.com (out-68.mta0.migadu.com [91.218.175.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1D85606A332 for ; Wed, 18 Nov 2026 04:52:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F1D85606A332 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=qHk+1IWp X-Envelope-To: netdev@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=D3DeV3YkG5u10TKSbuUfjvJgZyIgkf+zdkPJkso3qVI=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794977531; v=1; x=1795582331; b=qHk+1IWpFiYNCgRhRAelEnhQmvIkckZ8ZqfVdS5K2Vt0WdBoMSxfrgCpCETdXgMTlCFJ0euE oQS4GhrheBzYA+ru98V59USQr8qrUSQaao1SjIlasYWaXrR7fS9HSMS+SvLMLKrK7mQMQTxpEjO BWysdS1ye+jAjxR6ZOTWVllg= X-Envelope-To: netdev@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 9116fc7c9e291cd0; Wed, 18 Nov 2026 04:52:10 +0000 X-Mizu-Trace-ID: 9116fc7c9e291cd0 X-Migadu-Flow: FLOW_OUT From: Jiayuan Chen To: netdev@vger.kernel.org Cc: Jiayuan Chen , Simon Horman , David Ahern , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthieu Baerts , Mat Martineau , Geliang Tang , Allison Henderson , "D. Wythe" , Dust Li , Sidraya Jayagond , Mahanta Jambigi , Tony Lu , Wen Gu , linux-kernel@vger.kernel.org, mptcp@lists.linux.dev, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-s390@vger.kernel.org Subject: [PATCH net-next v2 1/5] inet: frags: annotate data-races around fqdir->timeout and fqdir->max_dist Date: Wed, 18 Nov 2026 12:51:16 +0800 Message-ID: <20261118045137.174026-2-jiayuan.chen@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261118045137.174026-1-jiayuan.chen@linux.dev> References: <20261118045137.174026-1-jiayuan.chen@linux.dev> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fqdir->timeout and fqdir->max_dist are read without any lock while their sysctl handlers update them with WRITE_ONCE(). Add READ_ONCE() to the readers. Signed-off-by: Jiayuan Chen Reviewed-by: Simon Horman --- net/ipv4/inet_fragment.c | 2 +- net/ipv4/ip_fragment.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c index f330d0a398233..8143162eb9f53 100644 --- a/net/ipv4/inet_fragment.c +++ b/net/ipv4/inet_fragment.c @@ -416,7 +416,7 @@ static struct inet_frag_queue *inet_frag_create(struct fqdir *fqdir, inet_frag_putn(q, 2); return NULL; } - mod_timer(&q->timer, jiffies + fqdir->timeout); + mod_timer(&q->timer, jiffies + READ_ONCE(fqdir->timeout)); spin_unlock_bh(&q->lock); return q; } diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c index ef7fd61284a3f..5ac69d716da2a 100644 --- a/net/ipv4/ip_fragment.c +++ b/net/ipv4/ip_fragment.c @@ -89,7 +89,7 @@ static void ip4_frag_init(struct inet_frag_queue *q, const void *a) q->key.v4 = *key; qp->ecn = 0; - if (q->fqdir->max_dist) { + if (READ_ONCE(q->fqdir->max_dist)) { rcu_read_lock(); p = inet_getpeer_v4(net->ipv4.peers, key->saddr, key->vif); if (p && !refcount_inc_not_zero(&p->refcnt)) @@ -220,7 +220,7 @@ static struct ipq *ip_find(struct net *net, struct iphdr *iph, static int ip_frag_too_far(struct ipq *qp) { struct inet_peer *peer = qp->peer; - unsigned int max = qp->q.fqdir->max_dist; + unsigned int max = READ_ONCE(qp->q.fqdir->max_dist); unsigned int start, end; int rc; @@ -242,7 +242,7 @@ static int ip_frag_too_far(struct ipq *qp) static int ip_frag_reinit(struct ipq *qp) { - if (!mod_timer_pending(&qp->q.timer, jiffies + qp->q.fqdir->timeout)) + if (!mod_timer_pending(&qp->q.timer, jiffies + READ_ONCE(qp->q.fqdir->timeout))) return -ETIMEDOUT; inet_frag_queue_flush(&qp->q, SKB_DROP_REASON_FRAG_TOO_FAR); -- 2.43.0