From: Eric Dumazet <edumazet@kernel.org>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Willem de Bruijn <willemb@google.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, edumazet@kernel.org,
Henry Martin <bsdhenrymartin@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jason Wang <jasowangio@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>
Subject: [PATCH net] tun: flush uc and mc addresses in TUNSETLINK
Date: Wed, 18 Nov 2026 13:54:43 +0100 [thread overview]
Message-ID: <20261118125443.1137177-1-edumazet@kernel.org> (raw)
TUNSETLINK changes dev->type and dev->addr_len, but leaves
dev->uc and dev->mc untouched.
Entries added with the old addr_len stay in lists and rb-trees
that are now searched and dumped with the new addr_len.
When addr_len grows (eg ARPHRD_NONE -> ARPHRD_IP6GRE), dumps like
/proc/net/dev_mcast and RTM_GETMULTICAST expose bytes of
netdev_hw_addr that were never initialized.
bonding and team already call dev_uc_flush() and dev_mc_flush()
between NETDEV_PRE_TYPE_CHANGE and the type change. Do the same
in tun, but only when addr_len changes: if it does not, existing
entries are still valid and there is no reason to drop them.
Fixes: cca8ea3b05c9 ("net: tun: set tun->dev->addr_len during TUNSETLINK processing")
Link: https://lore.kernel.org/netdev/20261116024056.1274402-1-bsdhenrymartin@gmail.com/
Signed-off-by: Eric Dumazet <edumazet@kernel.org>
---
Cc: Henry Martin <bsdhenrymartin@gmail.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Jason Wang <jasowangio@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>
---
drivers/net/tun.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index d4870bdc156f..a2f56a4febb5 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -3379,6 +3379,8 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
(unsigned short)arg == ARPHRD_MCTP) {
ret = -EINVAL;
} else {
+ unsigned char addr_len = tun_get_addr_len(arg);
+
ret = call_netdevice_notifiers(NETDEV_PRE_TYPE_CHANGE,
tun->dev);
ret = notifier_to_errno(ret);
@@ -3387,8 +3389,13 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
"Refused to change device type\n");
break;
}
+ /* Addresses were added with the old dev->addr_len. */
+ if (addr_len != tun->dev->addr_len) {
+ dev_uc_flush(tun->dev);
+ dev_mc_flush(tun->dev);
+ }
tun->dev->type = (int) arg;
- tun->dev->addr_len = tun_get_addr_len(tun->dev->type);
+ tun->dev->addr_len = addr_len;
netif_info(tun, drv, tun->dev, "linktype set to %d\n",
tun->dev->type);
call_netdevice_notifiers(NETDEV_POST_TYPE_CHANGE,
--
2.53.0
next reply other threads:[~2026-11-18 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 12:54 Eric Dumazet [this message]
2026-11-18 12:58 ` [PATCH net] tun: flush uc and mc addresses in TUNSETLINK netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118125443.1137177-1-edumazet@kernel.org \
--to=edumazet@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bsdhenrymartin@gmail.com \
--cc=davem@davemloft.net \
--cc=horms@kernel.org \
--cc=jasowangio@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox