From: Simon Horman <horms@kernel.org>
To: Li Yifan <yifan2.li@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Dima Ruinskiy <dima.ruinskiy@intel.com>,
Li Lili <lili.li@intel.com>, Wang Jie <jie.wang@intel.com>
Subject: Re: [PATCH iwl-net v2] igc: Disable PTM after the last device reset on remove
Date: Wed, 18 Nov 2026 14:01:46 +0000 [thread overview]
Message-ID: <20261118140146.GD860048@horms.kernel.org> (raw)
In-Reply-To: <20261110062051.2730678-1-yifan2.li@intel.com>
On Tue, Nov 10, 2026 at 02:20:51PM +0800, Li Yifan wrote:
> After a PTM dialog, I225/I226 can send a PTM Request at the next device
> reset through the RST bit of the device-specific CTRL register
> (CTRL.RST). The device sends it even when the PTM Enable bit in its PTM
> Capability is clear. This is a hardware defect: a PTM Requester is
> permitted to request PTM Master Time only when PTM is enabled (PCIe
> r7.1 sec 6.21.3.1). The EN bit of the device-specific PTM_CTRL register
> is also clear at that time, so the driver has no control that stops
> the request.
>
> The request is harmless while the upstream port has PTM enabled. Since
> commit e1092d5e15e6 ("PCI/PTM: Do not enable PTM automatically for Root
> and Switch Upstream Ports"), pci_disable_ptm() also disables PTM on the
> upstream port when the last user goes away. igc_remove() calls
> pci_disable_ptm() before unregister_netdev(). If the interface is up,
> unregister_netdev() then resets the device through igc_close() ->
> igc_down() -> igc_reset(). The upstream port now handles the PTM
> Request as an Unsupported Request, as the spec requires (sec 6.21.3).
> On an Intel Nova Lake-S system with an I226-LM, this triggers DPC on
> "modprobe -r igc". Recovery fails because the driver is unbinding, and
> the next probe fails:
>
> pcieport 0000:80:1d.0: DPC: containment event, status:0x1f01: unmasked uncorrectable error detected
> pcieport 0000:80:1d.0: [20] UnsupReq (First)
> pcieport 0000:80:1d.0: AER: TLP Header: 0x34000000 0x81000052 0x00000000 0x00000000
>
> Message code 0x52 in the TLP header is a PTM Request from 81:00.0.
>
> Call pci_disable_ptm() after the last reset of the device, so that the
> upstream port still has PTM enabled and responds to the request. If the
> interface is down, unregister_netdev() does not reset the device, so
> reset it explicitly. Skip this reset if error recovery is in progress
> or has failed, as igc_down() does before igc_reset().
>
> Tests on an I226-LM show that this reset also clears the state: the
> device sends the request only at the first CTRL.RST after a PTM dialog,
> so a later reset sends nothing unless a new dialog runs.
>
> No new dialog runs after this reset. The PCIe spec makes the mechanism
> that starts a PTM dialog implementation specific (sec 6.21.3.1), so a
> device can start dialogs at any time while PTM is enabled. I225/I226
> start a dialog only when PTM_CTRL.EN is set and the driver sets the
> TRIG bit in PTM_CTRL (the "PTM trigger mode" in commit 8e404ad95d2c
> ("igc: fix PTM cycle trigger logic")), or in an automatic cycle mode
> that igc does not use. The request at CTRL.RST is the only exception
> that we know of. igc sets EN and TRIG only in the PTP code, and
> igc_ptp_stop() runs before the reset:
>
> - igc_ptp_suspend() -> igc_ptm_stop() clears PTM_CTRL.EN.
> - ptp_clock_unregister() removes the PHC and waits for the
> igc_ptp_getcrosststamp() calls in progress, so no new TRIG comes.
> - IGC_PTP_ENABLED is cleared, so igc_ptp_reset() returns early in the
> reset path and does not set EN or TRIG again.
>
> pci_clear_master() stays where it is, so PTM Enable is now cleared
> after bus mastering is disabled. This keeps what commit c080fe262f9e
> ("igc: Fix possible system crash when loading module") needs: the
> device starts no PTM dialog while bus mastering is disabled, because
> PTM_CTRL.EN is already clear.
>
> Fixes: e1092d5e15e6 ("PCI/PTM: Do not enable PTM automatically for Root and Switch Upstream Ports")
> Suggested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Co-developed-by: Li Lili <lili.li@intel.com>
> Signed-off-by: Li Lili <lili.li@intel.com>
> Signed-off-by: Li Yifan <yifan2.li@intel.com>
> Tested-by: Wang Jie <jie.wang@intel.com>
> ---
> v2:
> - Call CTRL the device-specific CTRL register. Describe the defect as a
> PTM Request with PTM Enable clear, and remove Bus Master Enable from
> the description of the defect (Bjorn).
> - Leave pci_clear_master() where it is and move only pci_disable_ptm()
> (Bjorn). Retested this order on the I226-LM (v7.2.7 with the same
> change): reload x20 with the
> interface up; unload with the interface down or never up, then a
> manual CTRL.RST (no PTM Request); S3 and s2idle; unbind/bind;
> remove/rescan; runtime suspend; reload in parallel with S3 for 10
> minutes. No DPC.
> - Explain why no new PTM dialog starts after the reset, and that
> starting dialogs only on TRIG is device-specific (Bjorn).
> - Add PCIe r7.1 references for the defect, the Unsupported Request at
> the upstream port, and the dialog trigger.
> - Keep only the pci_channel_offline() check before the reset (Bjorn).
> - Drop the pcie_ptm_enabled() check before pci_disable_ptm(). The PCI
> core fix [1] (applied to pci/ptm for v7.5) handles a failed
> pci_enable_ptm() for all drivers. Without [1], this is the same as
> the current code, which also calls pci_disable_ptm() without a check.
> - No erratum covers the PTM Request at CTRL.RST yet. I reported it to
> the I225/I226 hardware team and waiting update now. I
>
> [1] https://lore.kernel.org/r/20261104121457.2108515-1-yifan2.li@intel.com
>
> v1: https://lore.kernel.org/r/20261031021928.1714612-1-yifan2.li@intel.com
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-11-18 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 6:20 [PATCH iwl-net v2] igc: Disable PTM after the last device reset on remove Li Yifan
2026-11-18 14:01 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118140146.GD860048@horms.kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=bhelgaas@google.com \
--cc=dima.ruinskiy@intel.com \
--cc=helgaas@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jie.wang@intel.com \
--cc=lili.li@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=yifan2.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox