From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.208.42 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795051789; b=3K5rP4g3/Ati10lcP/HMxXnPLMIfREgZojkPE+xBfudFhMYtjpAxlhT2PA7bEGNWIBBG mJR9kz8Ng8DnWmzqaBimFpZuR101NWvPJyMbWmNE1FOj8ZyZSICzGLQ7PgvUtNJiVnvRv D1sVhXiePgNYH23HKevgvvpJ2ygx4OFbtUEbjtoE34n+2hOHh9rM8qFJNQ8zFIXf2JtCg 5CulCy2EpxngHnTQnhzb21rFY2YT6xbFaWotOW1R4aqGRWv3vpQvbGzanQG5BfPzPph3y cGKJOewJQxSI1qVgCz4sn4HSpRj1aJwBfodX0r/oZdiaJ5v7WSpVP9DLa4InqLuYzAg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795051789; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=IMUfFg2iR1Z91GxSjPkov61aiB2ViYWc3Z9M9ZmX54Q=; b=ziFGYdyeapLZz5FmWWjHGxd75Xi1KsLPrMqp3/6/zAwsEdsL2LwhCNiE0evvxpD8SRiu PpU+a9JNanuOlhLdWTxUEW89bAAQJlId5gpY9VEFe/HBhcaI6D5OpEms0iiAPDErqKlll 9dEe9pC0O+NQ7RGc4yYs2ITMJXNCEEB0elHluuKwz6M92Yngw0cspJJLhV+OhOMb5fGPm 9PZn9o/YSdbBtVNugpA9It/0BLl+BDVmdH/q9YER/jopy219pAeEnI0CSjA/HjJcYYxi6 mdCnOrNB9VJZ0UQ7by4fIMncLHH6ZYTVTLzSSMI7xEWAeGI0hll0HJnoqb2IztLtBgw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass header.d=cloudflare.com header.i=@cloudflare.com header.a=rsa-sha256 header.s=google09082023 header.b=X6RUl5nX; arc=none smtp.remote-ip=209.85.208.42 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CAF9606A32A for ; Thu, 19 Nov 2026 01:29:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9CAF9606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.a=rsa-sha256 header.s=google09082023 header.b=X6RUl5nX Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-6b596afb4c5so1901048a12.1 for ; Wed, 18 Nov 2026 17:29:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1795051787; x=1795656587; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=IMUfFg2iR1Z91GxSjPkov61aiB2ViYWc3Z9M9ZmX54Q=; b=X6RUl5nXPwSwt5c/kUdF+d/qAIPpu4B78KXEgoYgO1Ifwmp9Un0wXT9O03brHfdkj0 Iw/NgiWtHQkg9OjzyksdTG/Yk3SubNSObINPdaZ1LH3tMW9lWXcM2a5r0nkclDrg2smC Zb0YGB4IT7dNKxmFRti4PmVmxBxhrgJIsbGdXjpReO5gHaAFEaHL7kPg6Eg7L+Kh2w1f 9UmlkTUkG7mvaMEWNHvsqbuMBWDQO8hWN6c3xb4rEMyQKIx7BNQiPLSzNI0tNGSeJsfo 60BiL735Nn8IsGlBj2912I24qTnwkLODMQpnOlSR6NzHZK8QstcQRJPAG1XWTsTRcE5b m+WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795051787; x=1795656587; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IMUfFg2iR1Z91GxSjPkov61aiB2ViYWc3Z9M9ZmX54Q=; b=H4xj+1Rhw9FWGCWBcpA8WxTHhm/bh9z+eCTXBdCUZRQ+wBBAzDGL8FnZEKhMycJhf7 lHyMcoqOI8DPnq9yKKXMsCydWbXO4Wz0e89Qm6liMUfxYhDGGLaV3DGG+Z7wm1gDQi7c kzCl5XH7pL0iHCb+qDfG00Gpmdgq+zS69h3vj/6jSeL/txFxGCxRq/p2302xmOQsS00i gp7zr45Q3bwIK6v7lDM4y7nul4HSkx4WJUjlV1JcLNK2g6vathpjScRku/I7bJfBfvcq 0PwJQSZ48HrX69aDAkgST7oX6k+fJ/srsrkISfqU3eaXUsnjI3kmc8JstBwpxiljjphD tSkw== X-Forwarded-Encrypted: i=1; AL+hErH5sregtvjYhBe12uKL6g5r0OnuK6Gufx0byLPGnY/pw1lHgJ6YrcJ8eiNEtKklZW1do6fIcYs=@vger.kernel.org X-Gm-Message-State: APuU4Z+/hsHMu4psAPpty2W3rqcKgHfw7UQcsyPAcOv4t5yLkjjVsvo9 ybTDqDFg4Miw4qFBAdabAfv54lamkQ2vbpjh/qb4kOn5XdC57+DNRFJA6bVtueJgEg4= X-Gm-Gg: AYBFou1joCNKRk11++wNHCQg0Iv7TQGArLDswIZ80enDdDkaAALoJ6l0qYU52UwTu+R k0xdfpxcZTvwXh6PGXSVFxLA83SM1X9JFhhsW4czvMyj0Y0bEtnYubegKpvAQ4ptZFyDiFbdsjh KorOHs/BCaOGjiyceL1dr+Exm6AZdW7xo3yJobD7vsQfoJJAQKtkjmxeFLV8YNtUdwFUk7I++gU 6f6+Xas/PuvOFNmxAFlyoTYrHy+Tx1OjCh4RdlhjwYreUm4wm8zcRWXcdsmqc3ooqWKsirQUvhB Sti8af9oVJ2ffVRURAQ0KCgVU815WEg+i2yFjte0aLhd07JeQP/uUv9W8Cobx9Md1Ns3Xjg35fc ngCM6TYoG0nvhlidDe1ko4lONjMf0/yk+wRxviQijZZ0+B/Cg6FPblDdvpUAXgjdOGkdGkEjTBB I2B57qFLmS4dqz0MdlPcKuaOLmQ2YIoesJXFHG5ChGO+r1+b2lUQy5mLsc01liIToG3O1Q5Ufwt 1PoiyeXcPD7+VeauAWlVtuFOOt1WVtBPDu/KHo7z6aIGvx0/gg7yqnRFKWX6PmLM4FMlPRa2TiM zaP3jHW3ATD7uUS6iZes5FSHUDI4gAmFDIqKmT+0UlCVh/tY51bcKh6WaA== X-Received: by 2002:a05:6402:c4e2:10b0:6b8:afbd:64e6 with SMTP id 4fb4d7f45d1cf-6b8afbd6722mr1777470a12.42.1795051787085; Wed, 18 Nov 2026 17:29:47 -0800 (PST) Received: from L9JK9NPFH9 ([104.28.20.56]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6b88a1eb813sm1711016a12.26.2026.11.18.17.29.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Nov 2026 17:29:45 -0800 (PST) From: Tianyi Gao To: Omokefe Emmanuel Onanaroghene Cc: Hangbin Liu , kuba@kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net, edumazet@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, skhan@linuxfoundation.org, kernel-team@cloudflare.com, tianyi.gao@linux.dev Subject: Re: [PATCH net v4 0/3] selftests: net: veth: propagate check failures to exit status Date: Thu, 19 Nov 2026 01:29:40 +0000 Message-ID: <20261119012940.32838-1-tianyi@cloudflare.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261119003003.40482-1-emmaonana18@gmail.com> References: <20261119003003.40482-1-emmaonana18@gmail.com> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Hi Omokefe, On Thu, 19 Nov 2026 01:29:59 +0100 Omokefe Emmanuel Onanaroghene wrote: > Changes v3 -> v4: > - Patch 2: use if/else instead of "&& { ...; } ||" chains, keep > lines within 80 columns (thanks Tianyi for the review). > - Add patch 3 deriving the invalid tx value from the kernel maximum. Sorry for being annoying, but I see three problems with how v4 was sent: 1. Patch 3 lost its subject prefix. It went out as "[PATCH] selftests: net: veth: derive invalid-tx test value from kernel max", so patchwork put it in a series of its own [1]. 2. Patch 3 should come first. Patch 1 makes a chk_channels() failure fail the script, and from then on the nproc + 1 check can fail on a correct kernel. With the fix first, no commit in the series reports a false failure. 3. v4 was posted as a reply to my review of v3. A new version should start a new thread, and its change log should link the previous postings [2]. [1] https://patchwork.kernel.org/series/1215530/ [2] https://docs.kernel.org/process/maintainer-netdev.html#resending-after-review Cheers, Tianyi