From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.218.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795052331; b=o9l0zGBDlOWlryrW2AgmtZg9tCFC3NV515JX7KQ5NNEELteznits6PjrjvIN5AeKsxyr Ut5kCzvJEtQhHUiqkHXlb29GVntTwge5FA63kuN0Lda+sUwRNtFRIsooJy/9CVNYx/s8D YoU7dsq9lBlcLZ/Xb/bu9rrOI8kD7/B3ZCa8Byd/z13qzwgamXmJzkIbb5RT0hDrlDsW4 Cjuui7Ska0s5TfwhanF3kyBwT1ZWCfWBBQiVGmcF6zHdtcrjPxkHIqI35bZah5txmm82y 7FCeVcXAXU2EfjhjG3hPEALqi/0CXLPbTY5BsxkUIW4kBoa+ldCrALecXe3SK8qbMng== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795052331; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=yVcHqzXkcmRmeetpAor6laiPG64o4Do4e1KDubpvDQA=; b=c9X3+PQ2DrBBzrLmzhoqBqX2wmPb4+Lp6gzWbuH7qBlHcnrEcgZspw6ODAMlBcsuwlDB rFb9bvYHzUc9pq3si4UD2Yif/rtxo3kHvxny95YP+e+yFYVV+4EY662SZYqZJP5rhdxA+ jzgPYjUq+PcWBzSYJEDZL2c368zbhEpTwQ/2p5vNIdpEEWELu6HMHEzs4qGyS3reUiWgM T9HK+GgNLV3upZrudeaL+tLSpvkkQ9c5ApZt8sPKj7t3romYKkuOz2t/6XE8H4zi+bykL UcB66BQdC22aH0+jEp4rEzW3CHmoUTlEb80tfIaS9zOkLYkj9jMgL9h2NBZuhpjH93w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass header.d=cloudflare.com header.i=@cloudflare.com header.a=rsa-sha256 header.s=google09082023 header.b="Eh7C/lX8"; arc=none smtp.remote-ip=209.85.218.41 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D09260A262A for ; Thu, 19 Nov 2026 01:38:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5D09260A262A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.a=rsa-sha256 header.s=google09082023 header.b=Eh7C/lX8 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-c4cb6834eaaso276236866b.2 for ; Wed, 18 Nov 2026 17:38:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1795052330; x=1795657130; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yVcHqzXkcmRmeetpAor6laiPG64o4Do4e1KDubpvDQA=; b=Eh7C/lX85Oa77jtB8/DFYZO+O9JzEG3DMq5syaMAz6SYmftKF83P6kGE2jMl3ya1ho dcDrWR0Yjk571vjfMXLmb1qYoyp6zVnHBIJyjiAwmoaBlYEVOlje4cMf96MC7SujRAyK CSJlfAg8RbfEIpBnKIbF9YUAaFdpd5eJbQCfxwFUgS90pld+VB9oqcZwRGA68tjglwkH DGSOQKbLQKUB+ZxilP1l0UZRPQqWLP+udcn2MvhffPDURz8xz1SujAOV6xIYRvvD8ji2 pyc3/EX2bV8GqF4v/uGZE+Z17G+PNd+0NP19RB87s3AEKOhKUrYjCG+OhSzA3sKVvJFQ Cr9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795052330; x=1795657130; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yVcHqzXkcmRmeetpAor6laiPG64o4Do4e1KDubpvDQA=; b=HBI06dMAAtBQSuy/Nfq0IKIUoTHo8neIheHnyhak6+aolGubvM7YRHUFxiu97PF3Gz vGhfF0iOEJWVg/N4JcgucYxSWcsDdfyDecm57xZq9B1xre0hGrE/ICmjloW9zGGko4O1 yrPnlUYFbgGnxq9QLUVQWIamQiQfNdmYvIEozqQQZ2uA+IxV5xc/UflcT+EdohBm1hKn lAZLADJ5VPEkM+RBKC0t7eNwf3iafOiBgR7NjwgXFeAhEhma8Rxnuw3edWcbvmO0wcsa 0vfvsYXDa8a3tE2mfRzWNE4rjVnm38M28ZJ6IsgM8QrSoDwvRgkBjGG0rt63DBojFFK+ 2EgA== X-Gm-Message-State: APuU4Z8DxByKWGwGuAOAAxmkw7nImybPLINYrOQvL7Ya4UNBf1RfqiRC yy2yuX99lAlglcKlJmTFNzp8IpTcO2TW9tXZX7vwOopBubDyFUAQVYJxZRbg4yed02TLfg0M3Vm 05NoZfYw= X-Gm-Gg: AYBFou1WKbVhtKf7CufhY//D7j8D5KwJmQGcRNZktL7nBggldK0LDXZxFefi6igvjp/ HuzdcCMCGBaqbC3f7YoNhizNLXdPe7ONHFQmhYa0vWks/1vwTMsXIUaJT3fZkSROzYXO+2l7B0F pWnxUShs2xjXq6alfXcAOfUxosSi2akGih6IMwrhMv7Qge7e4VrrUaO/EoSG2+fiDf2rxbDtoW0 MGti6Q4/OQHrDyghVDImj/+siJQyNU4GgX+vZCE+0NUoDzPMhA7GZXeQ/gfUZBazwmEnQH/rNvp GuwTGaAeIhNzAz7+zpDc3khkCBigJu+mUYkSd8m8RDHw5Lx68elIHY6QaU2Ppee1UGm4QZD9rJ7 VXCd2rXft+p14Gu0+xqffIo8LdMwVR/cbPwLfyjG7AOuisSOxfmptvwIEPsJs5PjH8ZPopx/GBO 5+ircq4tBvCsgECS6DP50DCzeHvn5ok8BSukoJTEE8nFEXggJTMLOXk0RWVjUwOgeChNiez2SDy Rcas4jtMm+VGRJnK4YffLUAzaQsMiovWDch3PZmaVY4+UeGD15Er1US9qEbPC6A9z0y0WW14rxE lgsViayriF2RblQ3x0YjF13ABvDZpMHBqLwD6vM/nXc7ElEJQ0OcSr83Qw== X-Received: by 2002:a17:907:9613:b0:c40:9b75:84af with SMTP id a640c23a62f3a-c510e15bbd9mr437677766b.8.1795052329834; Wed, 18 Nov 2026 17:38:49 -0800 (PST) Received: from L9JK9NPFH9 ([104.28.20.56]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c51233c4080sm59785966b.16.2026.11.18.17.38.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Nov 2026 17:38:48 -0800 (PST) From: Tianyi Gao To: netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: "David S. Miller" , Simon Horman , David Keogh , Jesper Dangaard Brouer , Daniel Borkmann , David Woodhouse , Dragos Tatulea , Nimrod Oren , Alasdair McWilliam , Willem de Bruijn , Maciej Fijalkowski , Stanislav Fomichev , Magnus Karlsson , David Ahern , Ido Schimmel , Alexei Starovoitov , John Fastabend , Donald Hunter , Andrew Lunn , Jonathan Corbet , Shuah Khan , Shuah Khan , Randy Dunlap , Breno Leitao , =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Danielle Ratson , Kuniyuki Iwashima , bpf@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@cloudflare.com, nh-open-source@amazon.com, Stephen Hemminger , "Gustavo A. R. Silva" , "Remy D. Farley" , Amery Hung , Andrii Nakryiko , Andy Roulin , Anil Kaushik , Demos Ra , Eduard Zingerman , Emil Tsalapatis , Hangbin Liu , Ihor Solodrai , Jiayuan Chen , Jiri Olsa , Joe Damato , Kumar Kartikeya Dwivedi , Li RongQing , Louis Scalbert , Marc Kleine-Budde , Martin KaFai Lau , Martin Karsten , Matt Bobrowski , Michael Bommarito , Nikolay Aleksandrov , Runyu Xiao , Song Liu , Thorsten Leemhuis , Wang Zhan , Yonghong Song , Zhou Qiuyue , Tianyi Gao , Tianyi Gao Subject: [PATCH net-next v2 04/11] selftests: net: add flag to send a frame in xdp_helper Date: Thu, 19 Nov 2026 01:38:23 +0000 Message-ID: <20261119013830.36935-5-tianyi@cloudflare.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261119013830.36935-1-tianyi@cloudflare.com> References: <20261119013830.36935-1-tianyi@cloudflare.com> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xdp_helper only binds an XDP socket and waits. Tests in selftests/net have no way to send a frame through the AF_XDP TX path. Add a -t option that takes one Ethernet frame in hex. With -t, the helper also creates a TX ring, sends the frame and exits. It returns 1 if sendto() fails. Without -t, nothing changes. The test passes the whole frame in hex, so xdp_helper does not need to know about IP or UDP. veth has no AF_XDP zerocopy support, so the socket runs in copy mode. In copy mode the kernel allocates an skb for the frame in xsk_build_skb(), which uses the extra headroom. As a test helper, -t takes one well-formed frame and does not wait for TX completion, because copy mode sends the frame within sendto(). A driver with zerocopy support may send it later, so -t is meant for copy mode. send_frame() follows tools/testing/selftests/net/lib/xsk/xsk.c and tools/testing/selftests/bpf/prog_tests/xdp_metadata.c. XDP_PGOFF_TX_RING (0x80000000) does not fit in a 32-bit off_t. xsk.c also passes it to mmap() without _FILE_OFFSET_BITS, so xdp_helper does not define it either. Signed-off-by: Tianyi Gao --- v2: - Exit after sendto() and do not wait for the TX completion, as xdp_metadata.c does. - Drop the _FILE_OFFSET_BITS define, as xsk.c does. --- tools/testing/selftests/net/lib/xdp_helper.c | 80 ++++++++++++++++++-- 1 file changed, 73 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/net/lib/xdp_helper.c b/tools/testing/selftests/net/lib/xdp_helper.c index eb025a9f35b1..1111631efd73 100644 --- a/tools/testing/selftests/net/lib/xdp_helper.c +++ b/tools/testing/selftests/net/lib/xdp_helper.c @@ -19,15 +19,65 @@ static void print_usage(const char *bin) { - fprintf(stderr, "Usage: %s ifindex queue_id [-z]\n\n" - "where:\n\t-z: force zerocopy mode", bin); + fprintf(stderr, "Usage: %s ifindex queue_id [-z] [-t frame_hex]\n\n" + "where:\n\t-z: force zerocopy mode\n" + "\t-t: send one frame, given in hex, and exit\n", bin); +} + +static int parse_frame(unsigned char *buf, const char *hex) +{ + size_t len = strlen(hex) / 2; + size_t i; + + if (!len || len > 2048 || strlen(hex) % 2) + return -1; + for (i = 0; i < len; i++) + if (sscanf(hex + 2 * i, "%2hhx", &buf[i]) != 1) + return -1; + return len; +} + +static int send_frame(int sock_fd, __u32 len) +{ + struct xdp_mmap_offsets off; + socklen_t optlen = sizeof(off); + struct xdp_desc *desc; + size_t tx_sz; + int ret = 0; + char *tx; + + if (getsockopt(sock_fd, SOL_XDP, XDP_MMAP_OFFSETS, &off, &optlen)) { + perror("getsockopt failed"); + return 1; + } + + tx_sz = off.tx.desc + NUM_DESC * sizeof(*desc); + tx = mmap(NULL, tx_sz, PROT_READ | PROT_WRITE, MAP_SHARED, sock_fd, + XDP_PGOFF_TX_RING); + if (tx == MAP_FAILED) { + perror("TX ring mmap failed"); + return 1; + } + + desc = (struct xdp_desc *)(tx + off.tx.desc); + desc->addr = 0; + desc->len = len; + __atomic_store_n((__u32 *)(tx + off.tx.producer), 1, __ATOMIC_RELEASE); + + if (sendto(sock_fd, NULL, 0, MSG_DONTWAIT, NULL, 0) < 0) { + perror("sendto failed"); + ret = 1; + } + + munmap(tx, tx_sz); + return ret; } /* this is a simple helper program that creates an XDP socket and does the * minimum necessary to get bind() to succeed. * - * this test program is not intended to actually process packets, but could be - * extended in the future if that is actually needed. + * without -t it does not process packets. with -t it sends one frame + * through the TX ring and exits. * * it is used by queues.py to ensure the xsk netlinux attribute is set * correctly. @@ -37,13 +87,15 @@ int main(int argc, char **argv) struct xdp_umem_reg umem_reg = { 0 }; struct sockaddr_xdp sxdp = { 0 }; int num_desc = NUM_DESC; + int frame_len = 0; void *umem_area; int retry = 0; int ifindex; int sock_fd; int queue; + int i; - if (argc != 3 && argc != 4) { + if (argc < 3) { print_usage(argv[0]); return 1; } @@ -94,9 +146,20 @@ int main(int argc, char **argv) sxdp.sxdp_queue_id = queue; sxdp.sxdp_flags = 0; - if (argc > 3) { - if (!strcmp(argv[3], "-z")) { + for (i = 3; i < argc; i++) { + if (!strcmp(argv[i], "-z")) { sxdp.sxdp_flags = XDP_ZEROCOPY; + } else if (!strcmp(argv[i], "-t") && i + 1 < argc) { + frame_len = parse_frame(umem_area, argv[++i]); + if (frame_len < 0) { + print_usage(argv[0]); + return 1; + } + if (setsockopt(sock_fd, SOL_XDP, XDP_TX_RING, &num_desc, + sizeof(num_desc))) { + perror("setsockopt XDP_TX_RING failed"); + return 1; + } } else { print_usage(argv[0]); return 1; @@ -119,6 +182,9 @@ int main(int argc, char **argv) } } + if (frame_len) + return send_frame(sock_fd, frame_len); + ksft_ready(); ksft_wait(); -- 2.56.0