From: Eric Joyner <eric.joyner@amd.com>
To: <netdev-bot+sashiko@kernel.org>
Cc: Eric Joyner <eric.joyner@amd.com>, <netdev@vger.kernel.org>,
<brett.creeley@amd.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<horms@kernel.org>, <vadim.fedorenko@linux.dev>,
<nikhil.rao@amd.com>, <edumazet@kernel.org>
Subject: Re: [PATCH net-next v4 2/6] ionic: report FEC off as a supported link mode
Date: Wed, 18 Nov 2026 18:54:46 -0800 [thread overview]
Message-ID: <20261119025548.53327-1-eric.joyner@amd.com> (raw)
In-Reply-To: <179495702693.3136.14857089621112634448@kernel.org>
On Tue, 17 Nov 2026 23:10:26 +0000 netdev-bot+sashiko@kernel.org wrote:
> Is the claim in this comment accurate? The firmware ABI in ionic_if.h
> seems to define a per-port list of supported FEC types:
[...]
> If firmware fills identity.fec_type[], could the supported FEC set be
> built from it instead of extending the hardcoded list?
Firmware does not fill it. The port identify handler zeroes the identity
and sets only the port type and config, which is why the driver never
reads fec_type[].
> If firmware does not fill it, should the comment say that the field
> exists but is not populated? As written, the comment contradicts the
> documented ABI.
Fair point. v5 rewords the comment and the commit message to say that
the field exists but firmware leaves it unset.
> There is also another way to tell the parts apart. The driver already
> reads dev_info.asic_type in ionic_init_devinfo(), and
> ionic_doorbell_wa() uses it for per-ASIC behaviour. Could asic_type be
> used to leave FEC_NONE out on parts whose firmware rejects FEC off?
Whether FEC off is accepted is decided by firmware, and keying it on
asic_type would hardcode that firmware policy in the driver. The list
already includes BaseR and RS on every port, whatever its speed, and
firmware rejects a mode a port cannot run, so FEC off follows the same
rule.
Thanks,
Eric
pw-bot: cr
next prev parent reply other threads:[~2026-11-19 2:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 23:06 [PATCH net-next v4 0/6] ionic: FEC reporting fixes and .get_fec_stats handler Eric Joyner
2026-11-16 23:06 ` [PATCH net-next v4 1/6] ionic: write the extra_stats invalid markers one counter at a time Eric Joyner
2026-11-16 23:06 ` [PATCH net-next v4 2/6] ionic: report FEC off as a supported link mode Eric Joyner
2026-11-17 23:10 ` netdev-bot+sashiko
2026-11-19 2:54 ` Eric Joyner [this message]
2026-11-16 23:06 ` [PATCH net-next v4 3/6] ionic: report the configured FEC mode in ethtool_fecparam.fec Eric Joyner
2026-11-16 23:06 ` [PATCH net-next v4 4/6] ionic: map the FEC type through a helper in ionic_get_fecparam() Eric Joyner
2026-11-17 23:10 ` netdev-bot+sashiko
2026-11-16 23:06 ` [PATCH net-next v4 5/6] ionic: report the operational FEC mode from ethtool --show-fec Eric Joyner
2026-11-17 23:10 ` netdev-bot+sashiko
2026-11-19 2:54 ` Eric Joyner
2026-11-16 23:06 ` [PATCH net-next v4 6/6] ionic: Add .get_fec_stats ethtool handler Eric Joyner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119025548.53327-1-eric.joyner@amd.com \
--to=eric.joyner@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.rao@amd.com \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox