Netdev List
 help / color / mirror / Atom feed
From: "Frank.sae" <frank.sae@motor-comm.com>
To: andrew@lunn.ch
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, kuba@kernel.org,
	pabeni@redhat.com, edumazet@kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org, lingyu.zou@motor-comm.com,
	xiaoyong.li@motor-comm.com, jie.han@motor-comm.com
Subject: Re: [PATCH net-next v3] net: phy: motorcomm: add YT8831 2.5G PHY support
Date: Thu, 19 Nov 2026 05:56:45 +0000	[thread overview]
Message-ID: <20261119055645.653216-1-frank.sae@motor-comm.com> (raw)
In-Reply-To: <20261118033539.36633-1-frank.sae@motor-comm.com>

> Please break the patch up. Add basic support as a patch, then
> downshift and WoL as additional patches.
>
> The WoL code looks wrong, i don't see any calls to
> device_may_wakeup(), device_set_wakeup_capable() etc.
>
> What exactly is AUTO_BX2500_SGMII and how does it differ from SGMII?

Hi Andrew,

Thanks for your review.

I have split the submission:
This v4 only contains basic YT8831 PHY support.
Downshift is not implemented for YT8831 at this time.
WoL support is removed from this series; I will fix the wakeup API handling
(device_set_wakeup_capable() / device_may_wakeup()) and send WoL as a separate follow-up patch later.

AUTO_BX2500_SGMII is YT8831 chip-specific mode:
When operating in AUTO_BX2500_SGMII mode, the YT8831 adjusts the PHY media side to 2500-BaseX or SGMII based on the connection speed on the PHY UTP side.
1. Media: 2500BX – UTP: 2.5G
2. Media: SGMII – UTP: 1000M/100M/10M
Differnece from SGMII is it also includes the 2500-BaseX mode, which is switched automatically.

The v4 basic support patch will follow shortly.

Frank


  parent reply	other threads:[~2026-11-19  5:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  3:35 [PATCH net-next v3] net: phy: motorcomm: add YT8831 2.5G PHY support Frank.sae
2026-11-18 14:14 ` Andrew Lunn
2026-11-18 14:17 ` Andrew Lunn
2026-11-19  5:56 ` Frank.sae [this message]
2026-11-19  6:42 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119055645.653216-1-frank.sae@motor-comm.com \
    --to=frank.sae@motor-comm.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=jie.han@motor-comm.com \
    --cc=kuba@kernel.org \
    --cc=lingyu.zou@motor-comm.com \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=xiaoyong.li@motor-comm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox