Netdev List
 help / color / mirror / Atom feed
From: Zhefu Peng <ilskdw@gmail.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, kuniyu@google.com,
	mschiffer@universe-factory.net, nicolas.dichtel@6wind.com,
	shuah@kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v5 1/2] vxlan: reset the remote's dst cache when snooping moves a MAC
Date: Thu, 19 Nov 2026 17:52:46 +0800	[thread overview]
Message-ID: <20261119095246.41685-1-ilskdw@gmail.com> (raw)
In-Reply-To: <179480495432.3136.17109064150958616332@kernel.org>

> [Severity: Medium]
> Can a transmitter on another CPU still cache the route to the old remote
> after this reset?

Yes, as answered for v2: dst_cache tracks freshness in jiffies, so a
transmit that built its key before the reset can refill the cache in a
later jiffy. vxlan_fdb_replace() has the same window. Closing it means
replacing the remote, or its dst_cache, through RCU instead of updating
it in place, which would also change vxlan_fdb_replace(). I would
rather do that, if wanted, as a separate net-next change. Without this
patch every move uses the stale route; with it only this race does.

> [Severity: Medium]
> Can concurrent snoops of the same MAC leave remote_ip and remote_ifindex
> inconsistent?

Yes. v6 updates the remote under vxlan->hash_lock and checks the entry
again once the lock is held, so concurrent snoops are serialized with
each other and with vxlan_fdb_replace(). v6 also addresses the three
notes on patch 2.

pw-bot: cr

  reply	other threads:[~2026-11-19  9:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15  4:06 [PATCH net v5 0/2] vxlan: reset the remote's dst cache when snooping moves a MAC Zhefu Peng
2026-11-15  4:06 ` [PATCH net v5 1/2] " Zhefu Peng
2026-11-16  4:55   ` netdev-bot+sashiko
2026-11-19  9:52     ` Zhefu Peng [this message]
2026-11-15  4:06 ` [PATCH net v5 2/2] selftests: net: add a test for vxlan snooping moving " Zhefu Peng
2026-11-16  4:55   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119095246.41685-1-ilskdw@gmail.com \
    --to=ilskdw@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mschiffer@universe-factory.net \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox