From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795100718; b=wxx7u5qgEQYqWQbNzWniH2uXRTFmJt5uYg7DAQaudABEAR/jn5zpPjoyWLX9PmcQApCs SsIx1gdhURnwUOAAh7HkN3QKmVC/DzloClnLzYDAf77Kt1tGCjLlPCzzuK2ECrZHFdocE bOzdl1VaFI8Z1qQQY808Bjvqy0QC/4yDcGbMToheaXavCvbsTxHvuXKmcuKmccpuUL1pJ 0rNcNf/VOjo5Rdgs2kv52iGv5AASiCGqs124FXbGZDo80/SJR/9uheCFvbJxpyNDp67y9 c1w76vPGdbH7fNC9W/SmpBswVNVRbGNvmVS8rs7U+CrZ/zuXN22Goib/DHrjr0i6baQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795100718; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=cra6Vs20NtPqxX9EfP/IC1RWThkucYohNUCRfJABY3A=; b=VYG0N1Y6wrrwdHWghUY+Q4sUpBAmxWrcY9cXopCOR/uW7qNNGLxJ55GIh/fPyKkJ8cGK 1VKXeK4wTIHGQaau6jPaBK/Z5PWOLfVOeXZXexILPHzT1tOUzYC3niyrp4dtrjUyGJub3 SmlBeUwQf88UlRK70H5Iup7laoujAQG3Lnm04psu/vPtkueV2AviDmc/YNNXH6U89LeUk 2Zd+YZg9A725CGIFWy3PHmTEpO+b9HNo18/kwvyAbJ+fuUrTImeQhxoKx1VyO/mtQlAEF gdbYjqP7auQSyPey3WYIpJ+h73SNKw1mjVVZRPMj1TkRExBuJ0oHSW8BqrPXT2gXKCg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QOfZmYHN; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b="M/u5pjsP"; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C163606A32F for ; Thu, 19 Nov 2026 15:05:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2C163606A32F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QOfZmYHN; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=M/u5pjsP DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795100717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cra6Vs20NtPqxX9EfP/IC1RWThkucYohNUCRfJABY3A=; b=QOfZmYHNys9bR2nbd1exheChTNjkPoAodW3ImevLtfz07NoverccJ+VI8Y4wGZkukD89Nn H9O2XRVqaQ1En6ZsjXQLk/7rGmhgbfdY8sfIRkJVOlxkhpoDu58otsUm/vS9r8zMfpxGqD U9EV5U2rWxeH+LmiiAIbIVK9O7IXUZ0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-VEBXWpTiMhWGZUnyGIh7cw-1; Thu, 19 Nov 2026 10:05:14 -0500 X-MC-Unique: VEBXWpTiMhWGZUnyGIh7cw-1 X-Mimecast-MFC-AGG-ID: VEBXWpTiMhWGZUnyGIh7cw_1795100713 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-49034831bb3so1611284f8f.1 for ; Thu, 19 Nov 2026 07:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1795100713; x=1795705513; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=cra6Vs20NtPqxX9EfP/IC1RWThkucYohNUCRfJABY3A=; b=M/u5pjsPyc/9N48N/0EssEYRJNakgsn9YHzqC55V6mGYpInsHPPwTiFmhSBQO/BNZV 47Kpio0IOkENBcK9jv3h+/TjwnmbJ2XGS0YtNGeWAYwhvdPzkgGuyEjhWabd4gma47rW i2eUQQSi7w0yJ2Fi/tlkxRAXz6GKQNJi2/ljwIsdjmFgBclryKidDJpR+gwmiBh0HW2o dsKTdRjIvuSYyb2z6vL7dtmSrF+B96YFT+sVc7u0qKw5xxvnY1tyBxtsYsefkJXSf8/C uOhND8uVg4zZEtSa+qnHT/eisLZ4jO9wuU01H4loGp/MneMJHowW2nIWRIvykEkgWaSz eigg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795100713; x=1795705513; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cra6Vs20NtPqxX9EfP/IC1RWThkucYohNUCRfJABY3A=; b=pz3P3oQZtTKawhQClejvbUJ1IFu61FWqOCKztB1iv/R0uesfFbWEH0OVwtSzRIdkiV 77xqI24taBJDyTVTyr5q8GNJydJuGdZgBIcMhxQ8NwwW+wnGIvRUZu9+Y/i+YLMxrdCI yzFvgA1yMK+URD6EPMmr76TXxO6LUKzbxqdkJLoY9lU6GYoGWWahdblqpMUz1m24lqdE i7Q81RV+bLcXKEhlfuTzMQ/QdfIjptreU4yGdmmpI+wSfRlj/InaHU2kVte1IJe430Up 3qM5Ie0uZtoE/aAfuWDshlNWPVheCXBTV3uQQJ5AjysfQDq61QSYkhaYJSLyVm95Bc4k KErQ== X-Forwarded-Encrypted: i=1; AL+hErEL3kwYcN+N9JnTWNRAZN+wy+3NaBYdY2e1hVnRaOvpGvKoR4sivKXXELuF9xmLR5Y4l5NYiI4=@vger.kernel.org X-Gm-Message-State: APuU4Z8HGcbqfg8ZttkiUvUYKVDciI8W+EkvQ+fix/fibKyluezgnYa/ gSahlNNmmz/LxNIeQNtVDH4cUrG8maeqS4JommJVJvloGxWA+QCp6PRz3IBoOoPQeRLw9A3o0M7 EGcEk9+dnGjqJVURSsrECU1gy2ma+9ZaqzgfwS1tmEVEHkwODnl/jZDY7vQ== X-Gm-Gg: AZFdTZczSKEdUv1Xm3nuTV3/0mg9P9X7bVYjiy3z1P9WZBGlxpvdEn6Ixa0trJCFI/z vX9t3nAkVvwIHZjF0WIVuy07DHDZlRHq8jErcLfsX1DY/gWRsONcL83Kau+TfmKBh5sWV4EBh6U kARVvcaaW2s1Pr7PjPDleUs7jXmxS30yCt1FEvRdHyqVGlvC6fd7QPYOv04JAjx/QsJGFQjN5jU if0jg6XJNnuyw53NWhPAeBdJmHfWEaWMSduswhh7s1GofQoVPWTxdU+h2etHEttzGvQmKgF0xKY 01dpwli1v8ZVhRKU6NAMkA0nt/PmHYt5jaGlL8lanz7g8YwgUbaONclWSVvtCxlIfuHyyV4phJE KEzC0722bxeMvlH2O19a3h+R57NOTZ0Cx+eAS9cc2Kw== X-Received: by 2002:a05:6000:2608:b0:4a9:2728:fdfc with SMTP id ffacd0b85a97d-4a92728ff7amr4686370f8f.28.1795100713228; Thu, 19 Nov 2026 07:05:13 -0800 (PST) X-Received: by 2002:a05:6000:2608:b0:4a9:2728:fdfc with SMTP id ffacd0b85a97d-4a92728ff7amr4686266f8f.28.1795100712535; Thu, 19 Nov 2026 07:05:12 -0800 (PST) Received: from redhat.com ([2a0d:6fc0:1522:6500:ac93:c62:f076:48c6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4ab6c61e53asm61225f8f.59.2026.11.19.07.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2026 07:05:11 -0800 (PST) Date: Thu, 19 Nov 2026 10:05:05 -0500 From: "Michael S. Tsirkin" To: "Lorenzo Stoakes (ARM)" Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Madhavan Srinivasan , Nicholas Piggin , Michael Ellerman , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , Shrikanth Hegde , Haiyang Zhang , Wei Liu , Dexuan Cui , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Jan Kara , Paul Moore , Stephen Smalley , Ondrej =?utf-8?B?TW9zbsOhxI1law==?= , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Jens Wiklander , Sumit Garg , Scott Branden , Broadcom internal kernel review list , Arnd Bergmann , Greg Kroah-Hartman , Richard Cochran , David Woodhouse , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-sgx@vger.kernel.org, selinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, netdev@vger.kernel.org Subject: Re: [PATCH 14/14] vhost-vdpa: convert mmap hook to mmap_prepare Message-ID: <20261119100450-mutt-send-email-mst@kernel.org> References: <20261105-late-2026-mmap_prepare-v1-0-c56aadfbab8a@kernel.org> <20261105-late-2026-mmap_prepare-v1-14-c56aadfbab8a@kernel.org> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105-late-2026-mmap_prepare-v1-14-c56aadfbab8a@kernel.org> On Thu, Nov 05, 2026 at 09:05:45PM +0000, Lorenzo Stoakes (ARM) wrote: > Move from the deprecated mmap hook to the new mmap_prepare hook. The hook > only validates the request and sets the VMA flags, operations and page > protection. > > Signed-off-by: Lorenzo Stoakes (ARM) feel free to merge with rest of this. > --- > drivers/vhost/vdpa.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index ff7d90719171..993b2d7c8927 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -1573,19 +1573,19 @@ static const struct vm_operations_struct vhost_vdpa_vm_ops = { > .fault = vhost_vdpa_fault, > }; > > -static int vhost_vdpa_mmap(struct file *file, struct vm_area_struct *vma) > +static int vhost_vdpa_mmap_prepare(struct vm_area_desc *desc) > { > - struct vhost_vdpa *v = vma->vm_file->private_data; > + struct vhost_vdpa *v = desc->file->private_data; > struct vdpa_device *vdpa = v->vdpa; > const struct vdpa_config_ops *ops = vdpa->config; > struct vdpa_notification_area notify; > - unsigned long index = vma->vm_pgoff; > + unsigned long index = desc->pgoff; > > - if (vma->vm_end - vma->vm_start != PAGE_SIZE) > + if (vma_desc_size(desc) != PAGE_SIZE) > return -EINVAL; > - if ((vma->vm_flags & VM_SHARED) == 0) > + if (!vma_desc_test(desc, VMA_SHARED_BIT)) > return -EINVAL; > - if (vma->vm_flags & VM_READ) > + if (vma_desc_test(desc, VMA_READ_BIT)) > return -EINVAL; > if (!ops->get_vq_notification) > return -ENOTSUPP; > @@ -1598,12 +1598,13 @@ static int vhost_vdpa_mmap(struct file *file, struct vm_area_struct *vma) > return -EINVAL; > if (notify.addr & (PAGE_SIZE - 1)) > return -EINVAL; > - if (vma->vm_end - vma->vm_start != notify.size) > + if (vma_desc_size(desc) != notify.size) > return -ENOTSUPP; > > - vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > - vm_flags_set(vma, VM_IO | VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); > - vma->vm_ops = &vhost_vdpa_vm_ops; > + desc->page_prot = pgprot_noncached(desc->page_prot); > + vma_desc_set_flags(desc, VMA_IO_BIT, VMA_PFNMAP_BIT, VMA_DONTEXPAND_BIT, > + VMA_DONTDUMP_BIT); > + desc->vm_ops = &vhost_vdpa_vm_ops; > return 0; > } > #endif /* CONFIG_MMU */ > @@ -1615,7 +1616,7 @@ static const struct file_operations vhost_vdpa_fops = { > .write_iter = vhost_vdpa_chr_write_iter, > .unlocked_ioctl = vhost_vdpa_unlocked_ioctl, > #ifdef CONFIG_MMU > - .mmap = vhost_vdpa_mmap, > + .mmap_prepare = vhost_vdpa_mmap_prepare, > #endif /* CONFIG_MMU */ > .compat_ioctl = compat_ptr_ioctl, > }; > > -- > 2.56.0