From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=217.74.67.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795095074; b=ZR8fHRnq9twgTmYQOk0uQbwzjWVQYLoVygaz1SaD/n3xYUIbHvmRcpbFxOgM8saGigWh lRQpcXtwFFX7FEKImw3qKpmyPMY0Up1byXWbWGt+404WTkHzjJcusNgXQ60I3pQ5HNU5+ ZeaZa3IGWEEEcSVxLTZdpmiHubpuyMDHDmnAyE0oX5+G8vmsfO2Sr5J5ByVDebHwrwij9 1ka6EKut+8+jqCB807CO3szMabSAZjF+VX2mmiMERfbbSpSHT4cJhfne0KyZBNeeupsd/ BEJlcdIR2fv1Ty+3thbBN/6K4xLdSbhGQbq/Xt7anC5ctKTmgSVEhOFpyNCcD0LCh4w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795095074; h=DMARC-Filter:Received:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: DKIM-Signature; bh=ek7NZSZk66IEwU0BTvcPsgNpxaCLENhsZm176O6DDyU=; b=soN9AF7CFJ02rkj+9Nh9X5YKzK/LaM8lPDNyRBXS2CiXdNeA39B5OhN898UhHi63BIHT MXcFH9QEj2a2JfBuIth6pu92BiN7WgLAgVyKaSKVHyB+J9v4jOR5f6Uw3mn+a7Ccvorgd ZIi6vvgj6Szv72JflS+92TWlbrtaoFAVw0LDMQPSkPRlPjD1mK0LzPiKonOAaMqPqcWjb hYh8H/7maNWvJQd68FRHyIZwruChcLslQodlsxSGHpn9zO8ChynTEUNNIQ5GE+lX9C626 3+FSCeBheOOcTlbje/HhySb8gy9jQAV+TkxT34XD5Ex6eoYQCRfuBDfDo2+CnH1Sy9Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=poczta.fm; spf=pass smtp.mailfrom=poczta.fm; dkim=pass header.d=poczta.fm header.i=@poczta.fm header.a=rsa-sha256 header.s=dk header.b="yQjV/pXu"; arc=none smtp.remote-ip=217.74.67.49 Received: from smtpo49.interia.pl (smtpo49.interia.pl [217.74.67.49]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E9EC60A261E for ; Thu, 19 Nov 2026 13:31:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0E9EC60A261E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=poczta.fm Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=poczta.fm Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=poczta.fm header.i=@poczta.fm header.a=rsa-sha256 header.s=dk header.b=yQjV/pXu Received: from localhost (unknown [80.68.231.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by poczta.interia.pl (INTERIA.PL) with ESMTPSA; Thu, 19 Nov 2026 14:31:09 +0100 (CET) From: Slawomir Stepien To: Alexei Starovoitov , Daniel Borkmann , "David S . Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, Maciej Fijalkowski , Tianyi Gao , Octavian Purdila , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Alexander Lobakin , Ilias Apalodimas , Lorenzo Bianconi , Magnus Karlsson , Ihor Solodrai , Eric Dumazet , Paolo Abeni , Andrew Lunn , Simon Horman , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , Jiri Olsa , Kumar Kartikeya Dwivedi , Shuah Khan , linux-kselftest@vger.kernel.org, Slawomir Stepien Subject: [PATCH v7 bpf 5/5] selftests/bpf: Shrink test_run frags after generic XDP ran on lo Date: Thu, 19 Nov 2026 14:30:32 +0100 Message-ID: <20261119133032.2015656-6-sst@poczta.fm> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261119133032.2015656-1-sst@poczta.fm> References: <20261119133032.2015656-1-sst@poczta.fm> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poczta.fm; s=dk; t=1795095072; bh=ek7NZSZk66IEwU0BTvcPsgNpxaCLENhsZm176O6DDyU=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=yQjV/pXuU8HvAJ67XKahDyNu0UxnWZKUj0AmBXyw+8ifxEwFUjIKPkzycztwVaYGN HhOgkZwdjbb6J8Lh4XCSAbl9UNl8ei6mIp2hL4IEZDWDnTgUQewAkQc7cBDzmEt3r2 riOZp2fpp/3a9i11AES5XMN7KD5z4Hh9k3q1a2OM= bpf_prog_test_run_xdp() used the rxq info of the loopback device's queue 0, and generic XDP sets the mem type of that rxq info for the packets it handles. Run a packet through generic XDP on lo in a new netns, then repeat xdp_adjust_frags_tail_shrink there, which frees test_run frags from the program. Without the test_run fix this hits WARN_ON() in page_pool_unref_netmem() and leaks the frag pages; the test itself still passes, so the failure shows up in the kernel log (and as a panic with panic_on_warn). Signed-off-by: Slawomir Stepien --- .../bpf/prog_tests/xdp_adjust_tail.c | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c b/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c index 43264347e7d7..c0d54cf421d8 100644 --- a/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c +++ b/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c @@ -1,6 +1,9 @@ // SPDX-License-Identifier: GPL-2.0 #include #include +#include +#include +#include "xdp_dummy.skel.h" static void test_xdp_adjust_tail_shrink(void) { @@ -355,6 +358,52 @@ static void test_xdp_adjust_frags_tail_grow_64k(void) bpf_object__close(obj); } +/* bpf_prog_test_run_xdp() runs on the rxq of lo's queue 0, where generic + * XDP sets the mem type of the frags it hands to its program. Let generic + * XDP see a packet on lo first, then free test_run frags from the program. + */ +static void test_xdp_adjust_frags_tail_shrink_after_generic(void) +{ + struct sockaddr_in addr = { + .sin_family = AF_INET, + .sin_addr.s_addr = htonl(INADDR_LOOPBACK), + .sin_port = htons(9), + }; + struct netns_obj *ns = NULL; + struct xdp_dummy *skel; + int fd = -1, lo; + + skel = xdp_dummy__open_and_load(); + if (!ASSERT_OK_PTR(skel, "xdp_dummy__open_and_load")) + return; + + ns = netns_new("xdp_adjust_tail_ns", true); + if (!ASSERT_OK_PTR(ns, "netns_new")) + goto out; + + SYS(out, "ip link set dev lo up"); + lo = if_nametoindex("lo"); + if (!ASSERT_GT(lo, 0, "lo ifindex")) + goto out; + + if (!ASSERT_OK(bpf_xdp_attach(lo, bpf_program__fd(skel->progs.xdp_dummy_prog), + XDP_FLAGS_SKB_MODE, NULL), "attach generic XDP")) + goto out; + + fd = socket(AF_INET, SOCK_DGRAM, 0); + if (ASSERT_GE(fd, 0, "socket")) + ASSERT_EQ(sendto(fd, "x", 1, 0, (struct sockaddr *)&addr, sizeof(addr)), + 1, "sendto"); + bpf_xdp_detach(lo, XDP_FLAGS_SKB_MODE, NULL); + + test_xdp_adjust_frags_tail_shrink(); +out: + if (fd >= 0) + close(fd); + netns_free(ns); + xdp_dummy__destroy(skel); +} + void test_xdp_adjust_tail(void) { int page_size = getpagesize(); @@ -367,6 +416,8 @@ void test_xdp_adjust_tail(void) test_xdp_adjust_tail_grow2(); if (test__start_subtest("xdp_adjust_frags_tail_shrink")) test_xdp_adjust_frags_tail_shrink(); + if (test__start_subtest("xdp_adjust_frags_tail_shrink_after_generic")) + test_xdp_adjust_frags_tail_shrink_after_generic(); if (test__start_subtest("xdp_adjust_frags_tail_grow")) { if (page_size == 65536) test_xdp_adjust_frags_tail_grow_64k(); -- 2.56.0