From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: netdev-bot+sashiko@kernel.org, netdev@vger.kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
horms@kernel.org, kernel-team@meta.com, pabeni@redhat.com
Subject: Re: [net PATCH 1/6] fbnic: Wait for in-flight PTP timestamps before treating Tx as idle
Date: Thu, 19 Nov 2026 15:33:59 -0800 [thread overview]
Message-ID: <20261119153359.06277f25@kernel.org> (raw)
In-Reply-To: <CAKgT0UcDxJHs2jCUtMDPzTBX2pFahFOSO=Qd01mO-4xCwZ1Ozg@mail.gmail.com>
On Tue, 17 Nov 2026 13:31:33 -0800 Alexander Duyck wrote:
> This is assuming the worst case, but in the worst case we are talking
> about the Terminus Tx or Rx path essentially being locked up to
> trigger us being stuck in the wait that long.
>
> The likelihood of this is incredibly low, and the change that was
> already made reduced the worst case to under 10 seconds which I feel
> is reasonable in the case of shutting down an interface that is
> potentially in a stuck setup and requiring additional time to flush.
Could be the "don't add defines for meaningless constants" in me trying
to break thru, but in cases like this I wonder if the AI would have
complained if the AI writing the code did not over-comment this stuff.
None of this matters :S
next prev parent reply other threads:[~2026-11-19 23:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 20:41 [net PATCH 0/6] fbnic: Follow-up fixes for the Tx idle check, HW stats and FW mailbox allocations Alexander Duyck
2026-11-13 20:41 ` [net PATCH 1/6] fbnic: Wait for in-flight PTP timestamps before treating Tx as idle Alexander Duyck
2026-11-17 21:14 ` netdev-bot+sashiko
2026-11-17 21:31 ` Alexander Duyck
2026-11-19 23:33 ` Jakub Kicinski [this message]
2026-11-13 20:41 ` [net PATCH 2/6] fbnic: Do not accumulate HW stats from failed register reads Alexander Duyck
2026-11-17 21:14 ` netdev-bot+sashiko
2026-11-17 22:11 ` Alexander Duyck
2026-11-13 20:41 ` [net PATCH 3/6] fbnic: Cover all of the HW stats with the stats lock Alexander Duyck
2026-11-17 21:14 ` netdev-bot+sashiko
2026-11-17 22:01 ` Alexander Duyck
2026-11-13 20:41 ` [net PATCH 4/6] fbnic: Initialize and reset the HW stats before they can be read Alexander Duyck
2026-11-13 20:42 ` [net PATCH 5/6] fbnic: Stamp heartbeat and ownership requests after allocating them Alexander Duyck
2026-11-13 20:42 ` [net PATCH 6/6] fbnic: Allocate FW completions with kvzalloc Alexander Duyck
2026-11-19 23:49 ` [net PATCH 0/6] fbnic: Follow-up fixes for the Tx idle check, HW stats and FW mailbox allocations Jakub Kicinski
2026-11-19 23:50 ` patchwork-bot+netdevbpf
2026-11-19 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119153359.06277f25@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox