From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Cc: dsahern@kernel.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH iproute2-next 0/7] bpf: fix mount point parsing and drop the legacy loader
Date: Thu, 19 Nov 2026 11:02:35 -0800 [thread overview]
Message-ID: <20261119190312.578885-1-stephen@networkplumber.org> (raw)
While looking at OSS Scanner reports noticed a pattern of issues
around the BPF loader. The first set related to parsing of
mount points with fscanf("%s").
The next part were issues from the legacy BPF loader which
is no longer needed. This series rips the band-aid off
and related parts no longer needed.
There were also some bugs in error handling found
while changing all this.
Note: lib/bpf_legacy.c becomes lib/bpf_util.c. "ar rcs" does not
drop members that are no longer built, so a stale bpf_legacy.o and
sha1.o stay in lib/libutil.a and are picked up by the link. The
build still succeeds, but run "make distclean" to be rid of them.
The libbpf build options are gone: libbpf is now always required,
and pkg-config is the only way it is found. Both --libbpf_force and
--libbpf_dir are now rejected rather than silently ignored.
The last patch adds a tc bpf test, there was none before. It caught
a regression in this series that the build did not: the tc/ pin
subdirectory quietly went missing.
Since v1: squashed the four libbpf configure patches into one,
dropped the bpf_pinning fallback fix since the loader removal
deletes that code anyway, moved the tc-bpf(8) update next to the
change it documents, and reworded the export removal after Jamal
pointed out that LIBBPF_FORCE=off builds did have a working
import/run. Dropped Toke's Reviewed-by from the mount point check:
it now also restores the pin subdirectory, so it is not the patch
he reviewed.
Stephen Hemminger (7):
lib/bpf: parse /proc/mounts with getmntent and check fs magic
lib/fs: parse /proc/mounts with getmntent and check fs magic
tc: remove eBPF map export and exec bpf import
man: tc-bpf: drop references to the removed eBPF agent
lib/bpf: require libbpf 1.0 and remove legacy ELF loader
lib/bpf: check for missing bpf fs mount point
testsuite: add tc bpf test
bash-completion/tc | 18 +-
configure | 129 +-
etc/iproute2/bpf_pinning | 6 -
examples/bpf/README | 18 +-
examples/bpf/bpf_map_in_map.c | 4 +-
examples/bpf/bpf_shared.c | 14 +-
examples/bpf/legacy/bpf_cyclic.c | 35 -
examples/bpf/legacy/bpf_graft.c | 66 -
examples/bpf/legacy/bpf_map_in_map.c | 56 -
examples/bpf/legacy/bpf_shared.c | 53 -
examples/bpf/legacy/bpf_tailcall.c | 117 -
include/bpf_api.h | 7 +-
include/bpf_elf.h | 35 +-
include/bpf_scm.h | 77 -
include/bpf_util.h | 41 +-
include/sha1.h | 18 -
ip/iplink.c | 4 -
lib/Makefile | 10 +-
lib/bpf_glue.c | 15 +-
lib/bpf_legacy.c | 3306 --------------------------
lib/bpf_libbpf.c | 260 +-
lib/bpf_util.c | 1105 +++++++++
lib/fs.c | 33 +-
lib/sha1.c | 108 -
man/man8/ip-link.8.in | 5 +-
man/man8/tc-bpf.8 | 173 +-
misc/ss.c | 946 +++++---
tc/e_bpf.c | 157 +-
tc/f_bpf.c | 12 +-
tc/m_bpf.c | 13 +-
testsuite/tests/tc/bpf.t | 153 ++
31 files changed, 2095 insertions(+), 4899 deletions(-)
delete mode 100644 etc/iproute2/bpf_pinning
delete mode 100644 examples/bpf/legacy/bpf_cyclic.c
delete mode 100644 examples/bpf/legacy/bpf_graft.c
delete mode 100644 examples/bpf/legacy/bpf_map_in_map.c
delete mode 100644 examples/bpf/legacy/bpf_shared.c
delete mode 100644 examples/bpf/legacy/bpf_tailcall.c
delete mode 100644 include/bpf_scm.h
delete mode 100644 include/sha1.h
delete mode 100644 lib/bpf_legacy.c
create mode 100644 lib/bpf_util.c
delete mode 100644 lib/sha1.c
create mode 100755 testsuite/tests/tc/bpf.t
--
2.53.0
next reply other threads:[~2026-11-19 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 19:02 Stephen Hemminger [this message]
2026-11-19 19:02 ` [PATCH iproute2-next v2 1/7] lib/bpf: parse /proc/mounts with getmntent and check fs magic Stephen Hemminger
2026-11-19 19:02 ` [PATCH iproute2-next v2 2/7] lib/fs: " Stephen Hemminger
2026-11-19 19:02 ` [PATCH iproute2-next v2 3/7] tc: remove eBPF map export and exec bpf import Stephen Hemminger
2026-11-19 19:02 ` [PATCH iproute2-next v2 4/7] man: tc-bpf: drop references to the removed eBPF agent Stephen Hemminger
2026-11-19 19:02 ` [PATCH iproute2-next v2 5/7] lib/bpf: require libbpf 1.0 and remove legacy ELF loader Stephen Hemminger
2026-11-19 19:02 ` [PATCH iproute2-next v2 6/7] lib/bpf: check for missing bpf fs mount point Stephen Hemminger
2026-11-19 19:02 ` [PATCH iproute2-next v2 7/7] testsuite: add tc bpf test Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119190312.578885-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox