Netdev List
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <eballetb@redhat.com>
To: netdev@vger.kernel.org
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
	s32@nxp.com, Vladimir Oltean <vladimir.oltean@nxp.com>,
	Wei Fang <wei.fang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Saravana Kannan <saravanak@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	imx@lists.linux.dev, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Enric Balletbo i Serra <eballetb@redhat.com>
Subject: Re: [PATCH v4 0/6] net: enetc: S32N79 pseudo-MAC (PPM) networking support
Date: Thu, 19 Nov 2026 23:00:34 +0100	[thread overview]
Message-ID: <20261119220034.1658710-1-eballetb@redhat.com> (raw)
In-Reply-To: <4f51bfd237fa584c7d9187d7b82f36e261853ea3.1794581338.git.claudiu.manoil@nxp.com.mbx>

On Fri, Nov 13, 2026 at 05:02:31PM +0200, Claudiu Manoil wrote:
> This series adds networking support for the ENETCv4.4 pseudo-MAC (PPM)
> ports found on the NXP S32N79 SoC. On S32N79, the ENETCv4 ports are
> not wired to any external PHY/MII; instead they are internal "pseudo-MAC"
> links into the on-chip NETC switch. These links are proprietary, expose
> no standard IEEE interface, and run at a speed fixed at boot time by the
> Port PCR[PSPEED] register.
> 
> A key use case is a port that has no "ethernet" DT node at all: NETC is
> reached over PCI from a host that probes the ENETC, while the internal
> NETC switch it connects to is not owned by Linux. Such a port must have
> its fixed link synthesized at probe time.
> 
> The driver synthesizes the fixed link directly in C using an of_changeset:
> of_changeset_create_node() adds a "fixed-link" subnode onto the PCI
> function's dynamic OF node (CONFIG_PCI_DYNAMIC_OF_NODES), with the "speed"
> property read from PCR[PSPEED] at probe time and "full-duplex" set.
> phylink then picks up the fixed-link node through dev_fwnode().
> 
> The series touches three subsystems:
>   - net/enetc:  pseudo-MAC fixed-link support, probing of 4.4 devices
>                 and a fix for more than 6 ring interrupt vectors
>   - arm64 dts:  NETC IEP18 ECAM node on S32N79 and its RDB board enable
>   - PCI:        a quirk creating the OF node for the ENETC PMAC functions
> 
> Because this is primarily a networking feature and the pieces are
> interdependent at runtime, it would be most convenient to merge the
> whole series through the netdev tree.
> 
> Patch 1 has a runtime (not Kconfig) dependency on
> CONFIG_PCI_DYNAMIC_OF_NODES; absent that, the pseudo-MAC probe path
> fails gracefully with -ENODEV.
> 

Hi Claudiu,

I tested this series on the S32N79-RDB board running latest mainline kernel
and applied your v4 pseudo-MAC/PPM patches on top.

I used, though, the MRU MSI controller for NETC IEP18 overriding
the upstream msi-map property with msi-parent pointing to
the NXP MRU MSI controller (this driver is not upstream yet but I ported it).

With that configuration the ENETC PF probes successfully and networking is
functional on the board. So,

Tested-by: Enric Balletbo i Serra <eballetb@redhat.com>

[1] device-tree diff

diff --git a/arch/arm64/boot/dts/freescale/s32n79-rdb.dts b/arch/arm64/boot/dts/freescale/s32n79-rdb.dts
index 897ba24ac03a..a8a3602505e2 100644
--- a/arch/arm64/boot/dts/freescale/s32n79-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/s32n79-rdb.dts
@@ -70,5 +70,37 @@ &usdhc0 {
 };
 
 &netc_iep18 {
+       /delete-property/ msi-map;
+       msi-parent = <&mru_msi_controller>;
        status = "okay";
 };
+
+/ {
+       aps-bus {
+               compatible = "simple-bus";
+               ranges = <0x40a00000 0x0 0x40a00000 0x2000000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+
+               mru_msi_controller: msi-controller {
+                       compatible = "nxp,s32n79-mru-msi";
+                       msi-controller;
+                       reg = <0x40a40000 0x40000>,
+                             <0x40a80000 0x40000>,
+                             <0x40ac0000 0x40000>,
+                             <0x40b00000 0x40000>,
+                             <0x41a40000 0x40000>,
+                             <0x41a80000 0x40000>,
+                             <0x41ac0000 0x40000>,
+                             <0x41b00000 0x40000>;
+                       interrupts = <GIC_SPI 705 IRQ_TYPE_LEVEL_HIGH>,
+                                    <GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>,
+                                    <GIC_SPI 707 IRQ_TYPE_LEVEL_HIGH>,
+                                    <GIC_SPI 708 IRQ_TYPE_LEVEL_HIGH>,
+                                    <GIC_SPI 735 IRQ_TYPE_LEVEL_HIGH>,
+                                    <GIC_SPI 736 IRQ_TYPE_LEVEL_HIGH>,
+                                    <GIC_SPI 737 IRQ_TYPE_LEVEL_HIGH>,
+                                    <GIC_SPI 738 IRQ_TYPE_LEVEL_HIGH>;
+               };
+       };
+};


           reply	other threads:[~2026-11-19 22:00 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <4f51bfd237fa584c7d9187d7b82f36e261853ea3.1794581338.git.claudiu.manoil@nxp.com.mbx>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119220034.1658710-1-eballetb@redhat.com \
    --to=eballetb@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=s32@nxp.com \
    --cc=saravanak@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=wei.fang@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox