From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de,
Chaosheng Qu <chaosheng.qu.linux@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH net-next 08/13] can: at91_can: don't discard the IRQ lookup error in probe
Date: Thu, 19 Nov 2026 22:58:44 +0100 [thread overview]
Message-ID: <20261119220936.155728-9-mkl@pengutronix.de> (raw)
In-Reply-To: <20261119220936.155728-1-mkl@pengutronix.de>
From: Chaosheng Qu <chaosheng.qu.linux@gmail.com>
This is a robustness and consistency cleanup, this issue has not been seen
on real hardware.
at91_can_probe() looks up the memory resource and the interrupt together
and collapses both failures into -ENODEV:
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
irq = platform_get_irq(pdev, 0);
if (!res || irq <= 0) {
err = -ENODEV;
goto exit_put;
}
The irq <= 0 test also covers a 0 return, which platform_get_irq() never
produces; it warns and returns -EINVAL instead.
Split the two lookups: the memory resource keeps -ENODEV, the interrupt
returns the lookup error unchanged, as the neighbouring CAN platform
drivers do, e.g. commit ("can: cc770: don't discard the IRQ lookup error in
probe"). This also drops an IRQ lookup that cannot succeed when the memory
resource is missing.
A device tree without an interrupt now reports -ENXIO rather than
-ENODEV; the driver core treats both as a failed probe.
Build tested on x86_64.
Signed-off-by: Chaosheng Qu <chaosheng.qu.linux@gmail.com>
Link: https://patch.msgid.link/303815792800553c34842147941cab083823c212.1792118040.git.chaosheng.qu.linux@gmail.com
[mkl: update patch description]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/at91_can.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
index 58da323f14d7..3977de761636 100644
--- a/drivers/net/can/at91_can.c
+++ b/drivers/net/can/at91_can.c
@@ -1069,12 +1069,17 @@ static int at91_can_probe(struct platform_device *pdev)
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- irq = platform_get_irq(pdev, 0);
- if (!res || irq <= 0) {
+ if (!res) {
err = -ENODEV;
goto exit_put;
}
+ irq = platform_get_irq(pdev, 0);
+ if (irq < 0) {
+ err = irq;
+ goto exit_put;
+ }
+
if (!request_mem_region(res->start,
resource_size(res),
pdev->name)) {
--
2.53.0
next prev parent reply other threads:[~2026-11-19 22:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 21:58 [PATCH net-next 0/13] pull-request: can-next 2026-11-19 Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 01/13] MAINTAINERS: add entry for PEAK-System CAN drivers Marc Kleine-Budde
2026-11-19 22:18 ` netdev-bot+sinfo
2026-11-19 22:24 ` Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 02/13] can: raw: remove redundant NULL check before netdev_hold() Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 03/13] can: dev: remove unused safe_candev_priv() Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 04/13] can: convert to DEFINE_SIMPLE_DEV_PM_OPS() Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 05/13] can: sun4i_can: sun4ican_probe(): fix clk leak on unbound Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 06/13] can: cc770: don't discard the IRQ lookup error in probe Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 07/13] can: sun4i_can: " Marc Kleine-Budde
2026-11-19 21:58 ` Marc Kleine-Budde [this message]
2026-11-19 21:58 ` [PATCH net-next 09/13] can: janz-ican3: " Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 10/13] can: ifi_canfd: " Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 11/13] can: remove Softing CANcard driver Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 12/13] can: ucan: fix repeated word 'is' in comment Marc Kleine-Budde
2026-11-19 21:58 ` [PATCH net-next 13/13] can: xilinx_can: set CAN FD flags on received frames Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119220936.155728-9-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=chaosheng.qu.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox