Netdev List
 help / color / mirror / Atom feed
From: Daniel Pawlik <pawlik.dan@gmail.com>
To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, kabel@kernel.org,
	petr.wozniak@gmail.com, maxime.chevallier@bootlin.com,
	olek2@wp.pl, Daniel Pawlik <pawlik.dan@gmail.com>
Subject: [PATCH net-next v3 0/2] net: sfp: skip PHY probe on bridge-less OEM SFP-10G-T
Date: Fri, 20 Nov 2026 07:37:54 +0100	[thread overview]
Message-ID: <20261120063756.3677554-1-pawlik.dan@gmail.com> (raw)

Some "OEM SFP-10G-T" copper modules have no RollBall I2C-to-MDIO
bridge, but the SFP-10G-T quirk forces RollBall on all of them. The PHY
probe then retries for over nine minutes under rtnl_lock before the
module links up without a PHY. This series skips the PHY probe for the
bridge-less revisions A and B, and leaves other revisions, which do
have a bridge, unchanged.

Patch 1 moves sfp_strlen() so the fixup can use it, with no functional
change. Patch 2 adds the fixup.

This does not re-introduce the generic RollBall bridge probe reverted
in commit b521003c27eb ("Revert "net: phy: sfp: probe for RollBall
I2C-to-MDIO bridge in mdio-i2c""): the probe path, its timeouts and the
MDIO bus creation for genuine RollBall modules are untouched. Further
bridge-less revisions of this part number may exist; they can be added
once their lack of a bridge is confirmed on hardware.

Changes in v3:
- Target net-next and drop the Fixes: tag: rev A never worked without
  the stall, so this is not a regression (Andrew Lunn).
- Split the sfp_strlen() move into its own patch (Andrew Lunn).

Changes in v2:
- Match the vendor revision with sfp_strlen(), so NUL-padded revisions
  are accepted like the rest of the quirk matching.
- Spell out in the commit message how the rev B module reaches this
  quirk entry (its part number depends on the peer speed).

v2: https://lore.kernel.org/netdev/20261118221450.1764790-1-pawlik.dan@gmail.com/
v1: https://lore.kernel.org/netdev/20261116093605.294365-1-pawlik.dan@gmail.com/

Daniel Pawlik (2):
  net: sfp: move sfp_strlen() above the quirk fixups
  net: sfp: skip PHY probe on bridge-less OEM SFP-10G-T revisions A and
    B

 drivers/net/phy/sfp.c | 54 +++++++++++++++++++++++++++++++------------
 1 file changed, 39 insertions(+), 15 deletions(-)

-- 
2.56.1


             reply	other threads:[~2026-11-20  6:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  6:37 Daniel Pawlik [this message]
2026-11-20  6:37 ` [PATCH net-next v3 1/2] net: sfp: move sfp_strlen() above the quirk fixups Daniel Pawlik
2026-11-20  6:37 ` [PATCH net-next v3 2/2] net: sfp: skip PHY probe on bridge-less OEM SFP-10G-T revisions A and B Daniel Pawlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120063756.3677554-1-pawlik.dan@gmail.com \
    --to=pawlik.dan@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=kabel@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=olek2@wp.pl \
    --cc=pabeni@redhat.com \
    --cc=petr.wozniak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox